Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-03-04 19:30:51 +01:00
Code Issues Packages Projects Releases Activity

Arrow icon of secondary navigation is inconsistent (#2060)

Browse Source 
The toggle icon in the secondary navigation points in the wrong direction.
In the changeset and code view, the current status is displayed with the icon. This should also be the case for this component.
This commit is contained in:
Florian Scholdei
2022-06-08 13:36:16 +02:00
committed by GitHub
parent 03a87be521
commit 1f5ebc04d6
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/changelog/secondary_nav_toogle_icon.yaml Normal file
View File

@@ -0,0 +1,2 @@
- type: fixed
description: Arrow icon of secondary navigation is inconsistent ([#2060](https://github.com/scm-manager/scm-manager/pull/2060))

8
scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
View File

@@ -70444,7 +70444,7 @@ exports[`Storyshots Secondary Navigation Active when match 1`] = `
className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium"
>
<i
className="fas fa-caret-right"
className="fas fa-caret-down"
/>
</i>
Hitchhiker
@@ -70506,7 +70506,7 @@ exports[`Storyshots Secondary Navigation Default 1`] = `
className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium"
>
<i
className="fas fa-caret-right"
className="fas fa-caret-down"
/>
</i>
Hitchhiker
@@ -70568,7 +70568,7 @@ exports[`Storyshots Secondary Navigation Extension Point 1`] = `
className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium"
>
<i
className="fas fa-caret-right"
className="fas fa-caret-down"
/>
</i>
Hitchhiker
@@ -70656,7 +70656,7 @@ exports[`Storyshots Secondary Navigation Sub Navigation 1`] = `
className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium"
>
<i
className="fas fa-caret-right"
className="fas fa-caret-down"
/>
</i>
Hitchhiker

2
scm-ui/ui-components/src/navigation/SecondaryNavigation.tsx
View File

@@ -78,7 +78,7 @@ const SecondaryNavigation: FC<Props> = ({ label, children, collapsible = true })
}
};
const arrowIcon = isCollapsed ? <i className="fas fa-caret-down" /> : <i className="fas fa-caret-right" />;
const arrowIcon = isCollapsed ? <i className="fas fa-caret-left" /> : <i className="fas fa-caret-down" />;
const menuAriaLabel = isCollapsed ? t("secondaryNavigation.showContent") : t("secondaryNavigation.hideContent");
return (