From 1f5ebc04d6ef85624ed088b5d3f866629b2791de Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Wed, 8 Jun 2022 13:36:16 +0200 Subject: [PATCH] Arrow icon of secondary navigation is inconsistent (#2060) The toggle icon in the secondary navigation points in the wrong direction. In the changeset and code view, the current status is displayed with the icon. This should also be the case for this component. --- gradle/changelog/secondary_nav_toogle_icon.yaml | 2 ++ .../src/__snapshots__/storyshots.test.ts.snap | 8 ++++---- .../ui-components/src/navigation/SecondaryNavigation.tsx | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) create mode 100644 gradle/changelog/secondary_nav_toogle_icon.yaml diff --git a/gradle/changelog/secondary_nav_toogle_icon.yaml b/gradle/changelog/secondary_nav_toogle_icon.yaml new file mode 100644 index 0000000000..d7d6be5b32 --- /dev/null +++ b/gradle/changelog/secondary_nav_toogle_icon.yaml @@ -0,0 +1,2 @@ +- type: fixed + description: Arrow icon of secondary navigation is inconsistent ([#2060](https://github.com/scm-manager/scm-manager/pull/2060)) diff --git a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap index b0c9df3905..92dd75efee 100644 --- a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap +++ b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap @@ -70444,7 +70444,7 @@ exports[`Storyshots Secondary Navigation Active when match 1`] = ` className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium" > Hitchhiker @@ -70506,7 +70506,7 @@ exports[`Storyshots Secondary Navigation Default 1`] = ` className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium" > Hitchhiker @@ -70568,7 +70568,7 @@ exports[`Storyshots Secondary Navigation Extension Point 1`] = ` className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium" > Hitchhiker @@ -70656,7 +70656,7 @@ exports[`Storyshots Secondary Navigation Sub Navigation 1`] = ` className="SecondaryNavigation__Icon-sc-8p1rgi-1 hDCYCs is-medium" > Hitchhiker diff --git a/scm-ui/ui-components/src/navigation/SecondaryNavigation.tsx b/scm-ui/ui-components/src/navigation/SecondaryNavigation.tsx index d04d8979e9..58051e612a 100644 --- a/scm-ui/ui-components/src/navigation/SecondaryNavigation.tsx +++ b/scm-ui/ui-components/src/navigation/SecondaryNavigation.tsx @@ -78,7 +78,7 @@ const SecondaryNavigation: FC = ({ label, children, collapsible = true }) } }; - const arrowIcon = isCollapsed ? : ; + const arrowIcon = isCollapsed ? : ; const menuAriaLabel = isCollapsed ? t("secondaryNavigation.showContent") : t("secondaryNavigation.hideContent"); return (