IconsHelper#scm_change_icon ignores passed options (#43964).

Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24593 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/helpers/icons_helper.rb

@@ -79,7 +79,7 @@ module IconsHelper
     sprite_icon(icon_name, **)
   end
 
-  def scm_change_icon(action, name, **options)
+  def scm_change_icon(action, name, **)
     icon_name = case action
                 when 'A'
                   "add"
@@ -88,7 +88,7 @@ module IconsHelper
                 else
                   "circle-dot-filled"
                 end
-    sprite_icon(icon_name, name, size: 14)
+    sprite_icon(icon_name, name, size: 14, **)
   end
 
   def notice_icon(type, **)

test/helpers/icons_helper_test.rb

@@ -245,4 +245,10 @@ class IconsHelperTest < Redmine::HelperTest
   def test_icon_for_mime_type_should_return_generic_file_icon_for_unknown_mime_types
     assert_equal 'file', icon_for_mime_type('unknown-type')
   end
+
+  def test_scm_change_icon_should_set_default_size
+    expected = %r{<svg class="s14 icon-svg" aria-hidden="true"><use href="/assets/icons-\w+.svg#icon--add"></use></svg><span class="icon-label hidden">Added</span>}
+
+    assert_match expected, scm_change_icon('A', 'Added', icon_only: true)
+  end
 end