From 53e297f073494c30869eabde1a075e5e5581aa9d Mon Sep 17 00:00:00 2001
From: Go MAEDA <maeda@farend.jp>
Date: Tue, 21 Apr 2026 01:10:03 +0000
Subject: [PATCH] `IconsHelper#scm_change_icon` ignores passed options
 (#43964).

Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24593 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 app/helpers/icons_helper.rb       | 4 ++--
 test/helpers/icons_helper_test.rb | 6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/helpers/icons_helper.rb b/app/helpers/icons_helper.rb
index 794e5bd46..627f8c8cf 100644
--- a/app/helpers/icons_helper.rb
+++ b/app/helpers/icons_helper.rb
@@ -79,7 +79,7 @@ module IconsHelper
     sprite_icon(icon_name, **)
   end
 
-  def scm_change_icon(action, name, **options)
+  def scm_change_icon(action, name, **)
     icon_name = case action
                 when 'A'
                   "add"
@@ -88,7 +88,7 @@ module IconsHelper
                 else
                   "circle-dot-filled"
                 end
-    sprite_icon(icon_name, name, size: 14)
+    sprite_icon(icon_name, name, size: 14, **)
   end
 
   def notice_icon(type, **)
diff --git a/test/helpers/icons_helper_test.rb b/test/helpers/icons_helper_test.rb
index 07a656222..a1c9cab6e 100644
--- a/test/helpers/icons_helper_test.rb
+++ b/test/helpers/icons_helper_test.rb
@@ -245,4 +245,10 @@ class IconsHelperTest < Redmine::HelperTest
   def test_icon_for_mime_type_should_return_generic_file_icon_for_unknown_mime_types
     assert_equal 'file', icon_for_mime_type('unknown-type')
   end
+
+  def test_scm_change_icon_should_set_default_size
+    expected = %r{<svg class="s14 icon-svg" aria-hidden="true"><use href="/assets/icons-\w+.svg#icon--add"></use></svg><span class="icon-label hidden">Added</span>}
+
+    assert_match expected, scm_change_icon('A', 'Added', icon_only: true)
+  end
 end