Commit Graph

1281 Commits

Author SHA1 Message Date
Ilan Biala
7f99fd16d3 Merge pull request #1149 from mleanos/bugfix/article-remove-button-show
fix(articles): Article edit/delete validation
2016-02-10 11:06:30 -05:00
Cody B. Daig
46a0a39a3b Merge pull request #1194 from francisdaigle/fix/safe-user-object
fix(core): Add "additionalProvidersData" to "safeUserObject"
2016-02-09 13:26:06 -07:00
Francis Daigle
ba85dccb00 fix(core): Add "additionalProvidersData" to "safeUserObject"
Needed for management of social accounts.
2016-02-08 14:49:33 -07:00
mleanos
69b8a05ea2 fix(articles): Article edit/delete validation
Adds a custom field named `isCurrentUserOwner` to the Article document before
it's returned to the client. This field is used to determine if the current
User should is the "owner", and should see the edit/delete controls on the
client-side when viewing a single article. This custom (ad-hoc) field is NOT
persisted to the database; it's merely attached to the document.

Added server-side route tests for verifying the ad-hoc
"isCurrentUserOwner" field is properly set on the a single Article document.

Fixes #1146
2016-02-07 21:29:18 -08:00
Ilan Biala
ce3d0061ec Merge pull request #1190 from meanjs/feat/asyncVersion
feat(package.json): Set Async version to ~ from ^
2016-02-06 13:46:53 -05:00
Cody B. Daig
2ee7194bbc feat(package.json): Set Async version to ~ from ^ 2016-02-06 10:16:39 -07:00
Cody B. Daig
e24fd27961 Merge pull request #1169 from trainerbill/BowerAlpha
fix(bower): Alphabetize list
2016-01-29 14:58:09 -07:00
Andrew Throener
9fe05866e3 fix(bower): Aphabetize list 2016-01-29 13:07:54 -06:00
Cody B. Daig
43b8caeb58 Merge pull request #1143 from trendzetter/master
feat(config): upgrade angular-bootstrap from 0.13 to 1.0
2016-01-29 11:49:39 -07:00
Ilan Biala
cbd0c2c5cb Merge pull request #1167 from codydaig/fix/dependencies
fix(dependencies): Lock dependencies major and minor versions
2016-01-28 13:05:59 -05:00
Cody B. Daig
a2c43c29eb fix(dependencies): Lock dependencies major and minor versions 2016-01-27 17:02:27 -07:00
Cody B. Daig
68c01ac927 Merge pull request #1154 from trainerbill/MenusFixes
fix(core menu): Menuize the account routes so they can be added to by…
2016-01-27 11:15:05 -07:00
Cody B. Daig
271ec36336 Merge pull request #1165 from trainerbill/TravisFixes
fix(Travis build): PhantomJS and SocketIO dependencies
2016-01-27 11:13:50 -07:00
Andrew Throener
64884b8925 fix(Travis build): PhantomJS and SocketIO dependencies 2016-01-27 11:42:54 -06:00
Andrew Throener
48eabd02ed fix(core menu): Menuize the account routes so they can be added to by submodules
Newlines fix

Removed Comment
2016-01-25 19:40:05 -06:00
Cody B. Daig
3ab760a1e0 Merge pull request #1144 from farajfarook/server-output
fix(core): Adding server info to log initialization
2016-01-18 13:10:44 -08:00
Joris Willems
9cd4ceca46 feat(config): Upgrade angular-bootstrap 0.13 to 1.0
Many issues arise when using angular-bootstrap 0.13. Migration to 1.0 is
straightforward, offers a more stable interface, extra directives and fixes
many bugs.
Migration guide:
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

Fixes #1142
Fixes #1131
2016-01-17 22:06:34 +01:00
Liran Tal
6658774569 Merge pull request #1128 from mleanos/bugfix/gh-1127
fix(users): ProfileImageURL sanitize with ngSanitize
2016-01-17 19:16:30 +02:00
Ilan Biala
959d03c31e Merge pull request #1130 from combefis/enhance-comments
fix(docs): Fix comments content and style
2016-01-17 11:16:16 -05:00
Faraj Farook
36e956ea71 fix(core): Adding server info to log initialization
Adding host information to the log initialization and aligning the
texts.
2016-01-17 19:26:52 +05:30
Sébastien Combéfis
d2b2dfd606 fix(docs): Fix comments content and style
Changed some bad comments referencing the Articles module in other modules.
Typo fixed in xxx.client.modules.js files ("Application" => "Applicaion")
Full stop character removed at the end of line comments
2016-01-17 11:46:11 +01:00
Ilan Biala
3dee3fc47a Merge pull request #1134 from farajfarook/master
fix(users): Removing redundant variables
2016-01-16 14:09:09 -05:00
Faraj Farook
f9c7403825 fix(users): Removing redundant variables
Removing redundant variables defined and not used
2016-01-16 16:17:07 +05:30
Cody B. Daig
6c5b630b99 Merge pull request #1126 from Gym/article-styleguide
feat(articles): Modify articles module to implement style guidelines.
2016-01-15 14:57:44 -08:00
Cody B. Daig
aa42cc0a43 Merge pull request #1139 from simison/patch-15
fix(build): Linting error at gulpfile.js
2016-01-15 14:27:22 -08:00
mleanos
f88f28e035 fix(users): Profile image path is invalid after escaping
Removes the validator.escape on the profileImageUrl field in core server
controller.

The escaping was causing the profileImageUrl field to be an invalid path
for the image. We don't need to worry about xss vulnerabilities on this
field because no user input is provided; the name & path are generated
by the application logic.

Fixes #1127
2016-01-15 12:39:17 -08:00
Mikael Korpela
80c08a34a0 fix(build): Linting error at gulpfile.js
Fixes an error occurring when running `gulp`:
```bash
/mean/gulpfile.js
  199:22  error  A space is required after '{'   object-curly-spacing
  199:42  error  A space is required before '}'  object-curly-spacing
```
2016-01-15 12:09:41 -08:00
Ilan Biala
039d9de4a4 Merge pull request #1135 from JulianLaval/fix/gruntfile-lint
fix(config): Added Gruntfile linting
2016-01-14 15:41:57 -05:00
Ilan Biala
96a56e86ba Merge pull request #1137 from JulianLaval/fix/contrib-typo
fix(documentation): Contributing.md typo
2016-01-14 15:41:10 -05:00
Julian Laval
9d29e4491f fix(documentation): Contributing.md typo
Fixes 'consice' typo to 'concise' in CONTRIBUTING.md

Fixes #1136
2016-01-14 18:29:49 +00:00
Julian Laval
6748a7fbf9 fix(config): Added Gruntfile linting
Changed config properties to arrays for inclusion in Gruntfile Lodash unions, e.g. linting

Fixes #1125
2016-01-14 18:23:54 +00:00
Ilan Biala
bf05dbcca8 Merge pull request #1104 from accraze/gulp-imagemin
Added imagemin to gulp
2016-01-13 22:39:31 -05:00
accraze
1a3f6f8195 feat(build): added imagemin to gulp
in order to minify images,
gulp is now given an imagemin task
2016-01-13 19:23:19 -08:00
Liran Tal
b9e3fd1625 Merge pull request #1119 from lirantal/bugfix/xss_and_validations
fix(security): fixing possible xss issue in parsed objects
2016-01-02 10:45:15 +02:00
Ryan Hutchison
b3ad56efa3 feat(articles): Modify articles module to implement style guidelines.
Update the articles module to implement the style guidelines.

Much of this work is from @trainerbill

Closes #874
Closes #339
2016-01-02 01:53:59 -05:00
Cody B. Daig
169d4cd3e2 Merge pull request #1100 from mleanos/bugfix/ClientRoutes-Guest-Access
fix(core): Client routes guest access bug
2015-12-31 08:17:20 -08:00
Cody B. Daig
a89d82f7e0 Merge pull request #1122 from Gym/chat-styleguide
feat(chat): Modify chat module to implement johnpapa styleguide.
2015-12-31 08:15:30 -08:00
Ryan Hutchison
5d15e64a6d feat(chat): Modify chat module to implement johnpapa styleguide. 2015-12-30 20:54:35 -05:00
Liran Tal
2b0ae863a0 fix(security): fixing possible xss issue in parsed objects
Fixes #1106
2015-12-30 16:41:05 +02:00
mleanos
bfcfb555ff fix(core): Client routes guest access bug
Adds a check for the existence of the "guest" role in the state configuration
that we're transitioning to, in the core $stateChangeStart event handler. If
it exists, then we allow access.

Also, added validation of Authentication.user object. While writing
tests, I ran into an issue here when the Authentication service wasn't injected
into a controller. Probably best to have this check in place.

Fixes https://github.com/meanjs/mean/issues/1098
2015-12-29 23:28:14 -08:00
Cody B. Daig
b12be5fca5 Merge pull request #1107 from pgrodrigues/master
fix(core): Remove duplicate angular interceptor
2015-12-28 19:41:24 -08:00
Liran Tal
e52ccfc5cc Merge pull request #1120 from lirantal/bugfix/logger_assertions_fix
fix(tests) fixing assertion test for logger which failed
2015-12-29 00:43:28 +02:00
Liran Tal
0744ce5d96 fix(tests) fixing assertion test for logger which failed on undefined variable 2015-12-28 10:24:32 +02:00
Liran Tal
e6a8f0feaf Merge pull request #1101 from farajfarook/master
Adding host configuration feature
2015-12-25 08:39:24 +02:00
Liran Tal
111d85bee2 Merge pull request #1108 from mleanos/hotfix/Articles-Orphaned-Users
fix(articles): Orphaned User reference throws server error
2015-12-23 19:57:54 +02:00
Faraj Farook
6e4c54f712 feat(config): Adding host configuration feature
Adding the functionality of configuring the host to bind the server. By
default this is set to 0.0.0.0.
2015-12-23 03:11:25 +05:30
mleanos
2bdde4e9e2 fix(articles): Orphaned User reference throws server error
Adds an additional check for the existence of a populated user
reference, when determining if the current user has immediate access to
the requested article.

Without this fix, the server will throw an error if the requested
article doesn't have a populated user field.

Modified the article & articles list view's to check if the article has
a populated user. If not, then it will display "Deleted User" in place
of the missing user reference.

Added a server-side test that ensures we can get a single article if
the article.user field is referencing a deleted user.

Fixes #1082
2015-12-21 19:40:25 -08:00
Ilan Biala
7e8d2ed43e Merge pull request #1083 from mleanos/feature/Gulp-TestWatch-Server
feat(config): Gulp Server Watch for Mocha
2015-12-21 14:52:51 -05:00
mleanos
bf2eeed219 feat(gulp): Gulp Server Watch for Mocha
Adds a Gulp task that watches all server files (including server tests),
and upon any changes it will perform the Gulp *test:server* task.

Added a watch for server assets, to the main gulp watch config. This will only
add the watch when the NODE_ENV is set to "test".

Also, includes an **optional** argument for the task that can specify
that if the changed file is a test, then it will only run that test
file.

Example usage: gulp test:server:watch --onlyChanged
2015-12-16 17:56:53 -08:00
Pedro Rodrigues
996976ac66 fix(core): Remove duplicate angular interceptor
Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096
2015-12-16 14:55:07 +00:00