Nemcio/meanTorrent
1
0
Fork 0
mirror of https://github.com/taobataoma/meanTorrent.git synced 2026-07-07 19:11:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #720 from vaucouleur/getErrorMessage

Browse Source 
Article middleware was calling getErrorMessage with a null argument
This commit is contained in:
Liran Tal
2015-07-29 16:53:54 +03:00
parent 88b8f9e74a 71167b0e75
commit 09870db9ce
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/articles/server/controllers/articles.server.controller.js
View File

@@ -100,7 +100,7 @@ exports.articleByID = function(req, res, next, id) {
if (err) return next(err);
if (!article) {
return res.status(404).send({
message: errorHandler.getErrorMessage(err)
message: 'No article with that identifier has been found'
});
}
req.article = article;

15
modules/articles/tests/server/article.server.routes.tests.js
View File

@@ -223,7 +223,8 @@ describe('Article CRUD tests', function () {
});
});
it('should return proper error for single article which doesnt exist, if not signed in', function (done) {
it('should return proper error for single article with an invalid Id, if not signed in', function (done) {
// test is not a valid mongoose Id
request(app).get('/api/articles/test')
.end(function (req, res) {
// Set assertion
@@ -234,6 +235,18 @@ describe('Article CRUD tests', function () {
});
});
it('should return proper error for single article which doesnt exist, if not signed in', function (done) {
// This is a valid mongoose Id but a non-existent article
request(app).get('/api/articles/559e9cd815f80b4c256a8f41')
.end(function (req, res) {
// Set assertion
res.body.should.be.instanceof(Object).and.have.property('message', 'No article with that identifier has been found');
// Call the assertion callback
done();
});
});
it('should be able to delete an article if signed in', function (done) {
agent.post('/api/auth/signin')
.send(credentials)