mirror of
https://github.com/mnauw/git-remote-hg.git
synced 2026-07-20 21:50:02 +02:00
remote-bzr, remote-hg: fix email address regular expression
Before, strings like "foo.bar@example.com" would be converted to "foo. <bar@example.com>" when they should be "unknown <foo.bar@example.com>". Signed-off-by: Richard Hansen <rhansen@bbn.com> Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Felipe Contreras
parent
fdac7e0789
commit
2bae32df86
@@ -51,8 +51,8 @@ import time as ptime
|
||||
#
|
||||
|
||||
NAME_RE = re.compile('^([^<>]+)')
|
||||
AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')
|
||||
EMAIL_RE = re.compile('^([^<>]+[^ \\\t<>])?\\b(?:[ \\t<>]*?)\\b([^ \\t<>]+@[^ \\t<>]+)')
|
||||
AUTHOR_RE = re.compile('^([^<>]+?)? ?[<>]([^<>]*)(?:$|>)')
|
||||
EMAIL_RE = re.compile(r'([^ \t<>]+@[^ \t<>]+)')
|
||||
AUTHOR_HG_RE = re.compile('^(.*?) ?<(.*?)(?:>(.+)?)?$')
|
||||
RAW_AUTHOR_RE = re.compile('^(\w+) (?:(.+)? )?<(.*)> (\d+) ([+-]\d+)')
|
||||
|
||||
@@ -316,8 +316,7 @@ def fixup_user_git(user):
|
||||
else:
|
||||
m = EMAIL_RE.match(user)
|
||||
if m:
|
||||
name = m.group(1)
|
||||
mail = m.group(2)
|
||||
mail = m.group(1)
|
||||
else:
|
||||
m = NAME_RE.match(user)
|
||||
if m:
|
||||
|
||||
@@ -215,7 +215,8 @@ test_expect_success 'authors' '
|
||||
author_test theta "theta < test@example.com >" "theta <test@example.com>" &&
|
||||
author_test iota "iota >test@example.com>" "iota <test@example.com>" &&
|
||||
author_test kappa "kappa < test <at> example <dot> com>" "kappa <unknown>" &&
|
||||
author_test lambda "lambda@example.com" "Unknown <lambda@example.com>"
|
||||
author_test lambda "lambda@example.com" "Unknown <lambda@example.com>" &&
|
||||
author_test mu "mu.mu@example.com" "Unknown <mu.mu@example.com>"
|
||||
) &&
|
||||
|
||||
git clone "hg::hgrepo" gitrepo &&
|
||||
|
||||
Reference in New Issue
Block a user