Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-03-06 04:10:52 +01:00
Code Issues Packages Projects Releases Activity

do not allow "." as part of repository ids

Browse Source
This commit is contained in:
Sebastian Sdorra
2018-11-30 11:04:33 +01:00
parent 2383702417
commit f74a89c9d8
2 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scm-core/src/main/java/sonia/scm/repository/InitialRepositoryLocationResolver.java
View File

@@ -23,7 +23,7 @@ public class InitialRepositoryLocationResolver {
private static final String DEFAULT_REPOSITORY_PATH = "repositories";
private static final CharMatcher ID_MATCHER = CharMatcher.anyOf("/\\");
private static final CharMatcher ID_MATCHER = CharMatcher.anyOf("/\\.");
/**
* Returns the initial path to repository.

23
scm-core/src/test/java/sonia/scm/repository/InitialRepositoryLocationResolverTest.java
View File

@@ -13,9 +13,10 @@ import static org.assertj.core.api.Assertions.assertThat;
@ExtendWith({MockitoExtension.class})
class InitialRepositoryLocationResolverTest {
private InitialRepositoryLocationResolver resolver = new InitialRepositoryLocationResolver();
@Test
void shouldComputeInitialPath() {
InitialRepositoryLocationResolver resolver = new InitialRepositoryLocationResolver();
Path path = resolver.getPath("42");
assertThat(path).isRelative();
@@ -24,17 +25,21 @@ class InitialRepositoryLocationResolverTest {
@Test
void shouldThrowIllegalArgumentExceptionIfIdHasASlash() {
InitialRepositoryLocationResolver resolver = new InitialRepositoryLocationResolver();
Assertions.assertThrows(IllegalArgumentException.class, () -> {
resolver.getPath("../../../passwd");
});
Assertions.assertThrows(IllegalArgumentException.class, () -> resolver.getPath("../../../passwd"));
}
@Test
void shouldThrowIllegalArgumentExceptionIfIdHasABackSlash() {
InitialRepositoryLocationResolver resolver = new InitialRepositoryLocationResolver();
Assertions.assertThrows(IllegalArgumentException.class, () -> {
resolver.getPath("..\\..\\..\\users.ntlm");
});
Assertions.assertThrows(IllegalArgumentException.class, () -> resolver.getPath("..\\..\\..\\users.ntlm"));
}
@Test
void shouldThrowIllegalArgumentExceptionIfIdIsDotDot() {
Assertions.assertThrows(IllegalArgumentException.class, () -> resolver.getPath(".."));
}
@Test
void shouldThrowIllegalArgumentExceptionIfIdIsDot() {
Assertions.assertThrows(IllegalArgumentException.class, () -> resolver.getPath("."));
}
}