Merge pull request #1277 from scm-manager/bugfix/git_extension_not_allowed

repository name may not end with ".git" extension

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+### Fixed
+- Repository names may not end with ".git" ([#1277](https://github.com/scm-manager/scm-manager/pull/1277))
+
 ## [2.3.1] - 2020-08-04
 ### Added
 - New api to resolve SCM-Manager root url ([#1276](https://github.com/scm-manager/scm-manager/pull/1276))

scm-ui/ui-webapp/src/repos/components/form/repositoryValidation.test.ts

@@ -37,7 +37,7 @@ describe("repository name validation", () => {
   });
 
   it("should allow same names as the backend", () => {
-    const validPaths = ["scm", "s", "sc", ".hiddenrepo", "b.", "...", "..c", "d..", "a..c"];
+    const validPaths = ["scm", "scm.gitz", "s", "sc", ".hiddenrepo", "b.", "...", "..c", "d..", "a..c"];
 
     validPaths.forEach(path => expect(validator.isNameValid(path)).toBe(true));
   });
@@ -91,7 +91,8 @@ describe("repository name validation", () => {
       "a/..b",
       "scm/main",
       "scm/plugins/git-plugin",
-      "scm/plugins/git-plugin"
+      "scm/plugins/git-plugin",
+      "scm.git"
     ];
 
     invalidPaths.forEach(path => expect(validator.isNameValid(path)).toBe(false));

scm-ui/ui-webapp/src/repos/components/form/repositoryValidation.ts

@@ -24,7 +24,7 @@
 
 import { validation } from "@scm-manager/ui-components";
 
-const nameRegex = /(?!^\.\.$)(?!^\.$)(?!.*[\\\[\]])^[A-Za-z0-9\.][A-Za-z0-9\.\-_]*$/;
+const nameRegex = /(?!^\.\.$)(?!^\.$)(?!.*[.]git$)(?!.*[\\\[\]])^[A-Za-z0-9\.][A-Za-z0-9\.\-_]*$/;
 
 export const isNameValid = (name: string) => {
   return nameRegex.test(name);