Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-07-09 05:23:29 +02:00
Code Issues Packages Projects Releases Activity

Fix overview document title (#1885)

Browse Source
This commit is contained in:
Eduard Heimbuch
2021-12-03 13:56:31 +01:00
committed by GitHub
parent f7d8636b35
commit e4936260a1
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/changelog/overview_document_title.yaml Normal file
View File

@@ -0,0 +1,2 @@
- type: fixed
description: Overview document title ([#1885](https://github.com/scm-manager/scm-manager/pull/1885))

15
scm-ui/ui-webapp/src/repos/containers/Overview.tsx
View File

@@ -32,7 +32,7 @@ import {
OverviewPageActions,
Page,
PageActions,
urls,
urls
} from "@scm-manager/ui-components";
import RepositoryList from "../components/list";
import { useNamespaces, useRepositories } from "@scm-manager/ui-api";
@@ -65,7 +65,7 @@ const useOverviewData = () => {
const search = urls.getQueryStringFromLocation(location);
const request = {
namespace: namespaces?._embedded.namespaces.find((n) => n.namespace === namespace),
namespace: namespaces?._embedded.namespaces.find(n => n.namespace === namespace),
// ui starts counting by 1,
// but backend starts counting by 0
page: page - 1,
@@ -75,7 +75,7 @@ const useOverviewData = () => {
// also do not fetch repositories if an invalid namespace is selected
disabled:
(!!namespace && !namespaces) ||
(!!namespace && !namespaces?._embedded.namespaces.some((n) => n.namespace === namespace)),
(!!namespace && !namespaces?._embedded.namespaces.some(n => n.namespace === namespace))
};
const { isLoading: isLoadingRepositories, error: errorRepositories, data: repositories } = useRepositories(request);
@@ -86,7 +86,7 @@ const useOverviewData = () => {
namespace,
repositories,
search,
page,
page
};
};
@@ -152,7 +152,7 @@ const Overview: FC = () => {
const allNamespacesPlaceholder = t("overview.allNamespaces");
let namespacesToRender: string[] = [];
if (namespaces) {
namespacesToRender = [allNamespacesPlaceholder, ...namespaces._embedded.namespaces.map((n) => n.namespace).sort()];
namespacesToRender = [allNamespacesPlaceholder, ...namespaces._embedded.namespaces.map(n => n.namespace).sort()];
}
const namespaceSelected = (newNamespace: string) => {
if (newNamespace === allNamespacesPlaceholder) {
@@ -166,6 +166,7 @@ const Overview: FC = () => {
return (
<Page
documentTitle={t("overview.title")}
title={<ExtensionPoint name="repository.overview.title">{t("overview.title")}</ExtensionPoint>}
subtitle={<ExtensionPoint name="repository.overview.subtitle">{t("overview.subtitle")}</ExtensionPoint>}
loading={isLoading}
@@ -174,7 +175,7 @@ const Overview: FC = () => {
<div className="columns">
{hasExtensions ? (
<StickyColumn className="column is-one-third">
{extensions.map((extension) => React.createElement(extension))}
{extensions.map(extension => React.createElement(extension))}
</StickyColumn>
) : null}
<div className="column is-clipped">
@@ -193,7 +194,7 @@ const Overview: FC = () => {
<OverviewPageActions
showCreateButton={showCreateButton}
currentGroup={
namespace && namespaces?._embedded.namespaces.some((n) => n.namespace === namespace) ? namespace : ""
namespace && namespaces?._embedded.namespaces.some(n => n.namespace === namespace) ? namespace : ""
}
groups={namespacesToRender}
groupSelected={namespaceSelected}