Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-07-04 15:09:28 +02:00
Code Issues Packages Projects Releases Activity

Double check directory creation

Browse Source
This commit is contained in:
Rene Pfeuffer
2019-07-03 17:27:59 +02:00
parent 0ad291ea7d
commit ca68b6346e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scm-core/src/main/java/sonia/scm/util/IOUtil.java
View File

@@ -471,8 +471,14 @@ public final class IOUtil
{
if (!directory.exists() &&!directory.mkdirs())
{
throw new IllegalStateException(
"could not create directory ".concat(directory.getPath()));
// Sometimes, the previous check simply has the wrong result (either the 'exists()' returnes false though the
// directory exists or 'mkdirs()' returns false though the directory was created successfully.
// We therefore have to double check here. Funny though, in these cases a second check with 'directory.exists()'
// still returns false. As it seems, 'directory.getAbsoluteFile().exists()' creates a new object that fixes this
// problem.
if (!directory.getAbsoluteFile().exists()) {
throw new IllegalStateException("could not create directory ".concat(directory.getPath()));
}
}
}