Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-05-07 15:16:54 +02:00
Code Issues Packages Projects Releases Activity

Add exception class to failed span of AdvancedHttpClient

Browse Source
This commit is contained in:
Sebastian Sdorra
2020-11-04 08:55:23 +01:00
parent 3c32073853
commit b91d9e6b60
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java
View File

@@ -201,7 +201,8 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
}
return response;
} catch (IOException ex) {
span.label("exception", ex.getMessage());
span.label("exception", ex.getClass().getName());
span.label("message", ex.getMessage());
span.failed();
throw ex;
}

3
scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java
View File

@@ -302,7 +302,8 @@ public class DefaultAdvancedHttpClientTest
verify(tracer).span("failures");
verify(span).label("url", "http://failing.host");
verify(span).label("method", "DELETE");
verify(span).label("exception", "failed");
verify(span).label("exception", IOException.class.getName());
verify(span).label("message", "failed");
verify(span).failed();
verify(span).close();
}