Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-01-23 07:52:13 +01:00
Code Issues Packages Projects Releases Activity

improve DefaultNamespaceStrategy, added tests and javadoc

Browse Source
This commit is contained in:
Sebastian Sdorra
2018-07-13 12:10:19 +02:00
parent 31ca22fe47
commit 82da801280
2 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scm-webapp/src/main/java/sonia/scm/repository/DefaultNamespaceStrategy.java
View File

@@ -1,18 +1,17 @@
package sonia.scm.repository;
import org.apache.shiro.SecurityUtils;
import org.apache.shiro.subject.Subject;
import sonia.scm.plugin.Extension;
import sonia.scm.user.User;
/**
* The DefaultNamespaceStrategy returns the username of the currently logged in user as namespace.
* @since 2.0.0
*/
@Extension
public class DefaultNamespaceStrategy implements NamespaceStrategy {
@Override
public String getNamespace() {
Subject subject = SecurityUtils.getSubject();
String displayName = subject.getPrincipals().oneByType(User.class).getName();
return displayName;
return SecurityUtils.getSubject().getPrincipal().toString();
}
}

24
scm-webapp/src/test/java/sonia/scm/repository/DefaultNamespaceStrategyTest.java Normal file
View File

@@ -0,0 +1,24 @@
package sonia.scm.repository;
import com.github.sdorra.shiro.ShiroRule;
import com.github.sdorra.shiro.SubjectAware;
import org.junit.Rule;
import org.junit.Test;
import static org.junit.Assert.*;
@SubjectAware(configuration = "classpath:sonia/scm/shiro-001.ini")
public class DefaultNamespaceStrategyTest {
@Rule
public ShiroRule shiroRule = new ShiroRule();
private DefaultNamespaceStrategy namespaceStrategy = new DefaultNamespaceStrategy();
@Test
@SubjectAware(username = "trillian", password = "secret")
public void testNamespaceStrategy() {
assertEquals("trillian", namespaceStrategy.getNamespace());
}
}