fix code smells

This commit is contained in:
Konstantin Schaper
2020-08-12 13:10:07 +02:00
parent 5f986530ae
commit 80e18b47b7
6 changed files with 6 additions and 6 deletions

View File

@@ -30,7 +30,6 @@ import de.otto.edison.hal.Links;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.Setter;
import sonia.scm.repository.Signature;
import java.time.Instant;
import java.util.List;

View File

@@ -38,6 +38,7 @@ import java.util.Set;
@Getter
@Setter
@NoArgsConstructor
@SuppressWarnings("squid:S2160")
public class SignatureDto extends HalRepresentation {
private String keyId;

View File

@@ -135,7 +135,7 @@ public final class RepositoryServiceFactory {
public RepositoryServiceFactory(ScmConfiguration configuration,
CacheManager cacheManager, RepositoryManager repositoryManager,
Set<RepositoryServiceResolver> resolvers, PreProcessorUtil preProcessorUtil,
Set<ScmProtocolProvider> protocolProviders, WorkdirProvider workdirProvider) {
@SuppressWarnings("rawtypes") Set<ScmProtocolProvider> protocolProviders, WorkdirProvider workdirProvider) {
this(
configuration, cacheManager, repositoryManager, resolvers,
preProcessorUtil, protocolProviders, workdirProvider, ScmEventBus.getInstance()
@@ -348,9 +348,7 @@ public final class RepositoryServiceFactory {
}
RepositoryCacheKeyPredicate predicate = new RepositoryCacheKeyPredicate(repositoryId);
caches.forEach((cache) -> {
cache.removeAll(predicate);
});
caches.forEach(cache -> cache.removeAll(predicate));
}
}

View File

@@ -29,6 +29,7 @@ import sonia.scm.ContextEntry;
import java.util.List;
@SuppressWarnings("squid:S110")
public class NotPublicKeyException extends BadRequestException {
public NotPublicKeyException(List<ContextEntry> context, String message) {
super(context, message);

View File

@@ -27,6 +27,7 @@ package sonia.scm.security.gpg;
import sonia.scm.BadRequestException;
import sonia.scm.ContextEntry;
@SuppressWarnings("squid:S110")
public final class DeletingReadonlyKeyNotAllowedException extends BadRequestException {
public DeletingReadonlyKeyNotAllowedException(String keyId) {

View File

@@ -41,7 +41,7 @@ import java.security.NoSuchAlgorithmException;
import java.security.NoSuchProviderException;
import java.security.Security;
public class GPGKeyPairGeneratorTest {
class GPGKeyPairGeneratorTest {
private static void registerBouncyCastleProviderIfNecessary() {
if (Security.getProvider(BouncyCastleProvider.PROVIDER_NAME) == null) {