Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-05-06 02:16:55 +02:00
Code Issues Packages Projects Releases Activity

Fix character encoding for basic authentication (#2038)

Browse Source 
Regarding to RFC 7617 (see
https://datatracker.ietf.org/doc/html/rfc7617), the default
encoding for basic auth strings should be UTF-8.
This commit is contained in:
René Pfeuffer
2022-05-18 09:44:38 +02:00
committed by GitHub
parent 9bfb074805
commit 256106545d
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/changelog/basic_auth.yaml Normal file
View File

@@ -0,0 +1,2 @@
- type: fixed
description: character encoding for basic authentication ([#2038](https://github.com/scm-manager/scm-manager/pull/2038))

2
scm-core/src/main/java/sonia/scm/web/UserAgent.java
View File

@@ -264,7 +264,7 @@ public final class UserAgent
private boolean scmClient = false;
/** basic authentication charset */
private Charset basicAuthenticationCharset = StandardCharsets.ISO_8859_1;
private Charset basicAuthenticationCharset = StandardCharsets.UTF_8;
}

2
scm-core/src/test/java/sonia/scm/web/UserAgentParserTest.java
View File

@@ -88,7 +88,7 @@ public class UserAgentParserTest
{
UserAgent ua = parser.parse(UA_1);
assertEquals(Charsets.ISO_8859_1, ua.getBasicAuthenticationCharset());
assertEquals(Charsets.UTF_8, ua.getBasicAuthenticationCharset());
assertFalse(ua.isBrowser());
}