added tests for repositoryhandlers

plugins/scm-git-plugin/pom.xml

@@ -45,6 +45,15 @@
       <version>${jgit.version}</version>
     </dependency>
 
+    <!-- test scope -->
+
+    <dependency>
+      <groupId>sonia.scm</groupId>
+      <artifactId>scm-test</artifactId>
+      <version>1.0-M3-SNAPSHOT</version>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
 
   <properties>

plugins/scm-git-plugin/src/test/java/sonia/scm/repository/GitRepositoryHandlerTest.java

@@ -0,0 +1,102 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.repository;
+
+//~--- non-JDK imports --------------------------------------------------------
+
+import sonia.scm.store.StoreFactory;
+
+import static org.junit.Assert.*;
+
+//~--- JDK imports ------------------------------------------------------------
+
+import java.io.File;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public class GitRepositoryHandlerTest extends SimpleRepositoryHandlerTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @param directory
+   */
+  @Override
+  protected void checkDirectory(File directory)
+  {
+    File head = new File(directory, "HEAD");
+
+    assertTrue(head.exists());
+    assertTrue(head.isFile());
+
+    File config = new File(directory, "config");
+
+    assertTrue(config.exists());
+    assertTrue(config.isFile());
+
+    File refs = new File(directory, "refs");
+
+    assertTrue(refs.exists());
+    assertTrue(refs.isDirectory());
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @param factory
+   * @param directory
+   *
+   * @return
+   */
+  @Override
+  protected RepositoryHandler createRepositoryHandler(StoreFactory factory,
+          File directory)
+  {
+    GitRepositoryHandler repositoryHandler = new GitRepositoryHandler(factory);
+
+    repositoryHandler.init(contextProvider);
+
+    GitConfig config = new GitConfig();
+
+    config.setRepositoryDirectory(directory);
+    repositoryHandler.setConfig(config);
+
+    return repositoryHandler;
+  }
+}

plugins/scm-hg-plugin/pom.xml

@@ -26,6 +26,15 @@
       <scope>provided</scope>
     </dependency>
 
+    <!-- test scope -->
+
+    <dependency>
+      <groupId>sonia.scm</groupId>
+      <artifactId>scm-test</artifactId>
+      <version>1.0-M3-SNAPSHOT</version>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
  
 </project>

plugins/scm-hg-plugin/src/main/java/sonia/scm/repository/HgInitialConfigBuilder.java

@@ -123,7 +123,7 @@ public class HgInitialConfigBuilder
    *
    * @return
    */
-  private String search(String cmd)
+  public static String search(String cmd)
   {
     String cmdPath = null;
 

plugins/scm-hg-plugin/src/test/java/sonia/scm/repository/HgRepositoryHandlerTest.java

@@ -0,0 +1,103 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.repository;
+
+//~--- non-JDK imports --------------------------------------------------------
+
+import sonia.scm.store.StoreFactory;
+import sonia.scm.util.Util;
+
+import static org.junit.Assert.*;
+import static org.junit.Assume.*;
+
+//~--- JDK imports ------------------------------------------------------------
+
+import java.io.File;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public class HgRepositoryHandlerTest extends SimpleRepositoryHandlerTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @param directory
+   */
+  @Override
+  protected void checkDirectory(File directory)
+  {
+    File hgDirectory = new File(directory, ".hg");
+
+    assertTrue(hgDirectory.exists());
+    assertTrue(hgDirectory.isDirectory());
+
+    File hgrc = new File(hgDirectory, "hgrc");
+
+    assertTrue(hgrc.exists());
+    assertTrue(hgrc.isFile());
+    assertTrue(hgrc.length() > 0);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @param factory
+   * @param directory
+   *
+   * @return
+   */
+  @Override
+  protected RepositoryHandler createRepositoryHandler(StoreFactory factory,
+          File directory)
+  {
+    HgRepositoryHandler handler = new HgRepositoryHandler(factory);
+
+    handler.init(contextProvider);
+    handler.getConfig().setRepositoryDirectory(directory);
+
+    // skip tests if hg not in path
+    if (Util.isEmpty(handler.getConfig().getHgBinary()))
+    {
+      System.out.println("WARNING could not find hg, skipping test");
+      assumeTrue(false);
+    }
+
+    return handler;
+  }
+}

plugins/scm-svn-plugin/pom.xml

@@ -37,6 +37,15 @@
       <version>${svnkit.version}</version>
     </dependency>
 
+    <!-- test scope -->
+
+    <dependency>
+      <groupId>sonia.scm</groupId>
+      <artifactId>scm-test</artifactId>
+      <version>1.0-M3-SNAPSHOT</version>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
 
   <properties>

plugins/scm-svn-plugin/src/test/java/sonia/scm/repository/SvnRepositoryHandlerTest.java

@@ -0,0 +1,97 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.repository;
+
+//~--- non-JDK imports --------------------------------------------------------
+
+import sonia.scm.store.StoreFactory;
+
+import static org.junit.Assert.*;
+
+//~--- JDK imports ------------------------------------------------------------
+
+import java.io.File;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public class SvnRepositoryHandlerTest extends SimpleRepositoryHandlerTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @param directory
+   */
+  @Override
+  protected void checkDirectory(File directory)
+  {
+    File format = new File(directory, "format");
+
+    assertTrue(format.exists());
+    assertTrue(format.isFile());
+
+    File db = new File(directory, "db");
+
+    assertTrue(db.exists());
+    assertTrue(db.isDirectory());
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @param factory
+   * @param directory
+   *
+   * @return
+   */
+  @Override
+  protected RepositoryHandler createRepositoryHandler(StoreFactory factory,
+          File directory)
+  {
+    SvnRepositoryHandler handler = new SvnRepositoryHandler(factory);
+
+    handler.init(contextProvider);
+
+    SvnConfig config = new SvnConfig();
+
+    config.setRepositoryDirectory(directory);
+    handler.setConfig(config);
+
+    return handler;
+  }
+}

scm-core/pom.xml

@@ -48,15 +48,6 @@
       <version>${jersey.version}</version>
     </dependency>
 
-    <!-- test scope -->
-
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-simple</artifactId>
-      <version>${slf4j.version}</version>
-      <scope>test</scope>
-    </dependency>
-
   </dependencies>
 
 </project>

scm-test/pom.xml

@@ -41,6 +41,12 @@
       <version>${mokito.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>${slf4j.version}</version>
+    </dependency>
+
   </dependencies>
   
 </project>

scm-test/src/main/java/sonia/scm/repository/SimpleRepositoryHandlerTestBase.java

@@ -0,0 +1,208 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.repository;
+
+//~--- non-JDK imports --------------------------------------------------------
+
+import org.junit.Test;
+
+import sonia.scm.AbstractTestBase;
+import sonia.scm.store.MemoryStoreFactory;
+import sonia.scm.store.StoreFactory;
+import sonia.scm.util.IOUtil;
+
+import static org.junit.Assert.*;
+
+//~--- JDK imports ------------------------------------------------------------
+
+import java.io.File;
+import java.io.IOException;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public abstract class SimpleRepositoryHandlerTestBase extends AbstractTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @param directory
+   */
+  protected abstract void checkDirectory(File directory);
+
+  /**
+   * Method description
+   *
+   *
+   * @param factory
+   * @param directory
+   *
+   * @return
+   */
+  protected abstract RepositoryHandler createRepositoryHandler(
+          StoreFactory factory, File directory);
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws RepositoryException
+   */
+  @Test
+  public void testCreate() throws RepositoryException, IOException
+  {
+    createRepository();
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws RepositoryException
+   */
+  @Test(expected = RepositoryAllreadyExistExeption.class)
+  public void testCreateExisitingRepository()
+          throws RepositoryException, IOException
+  {
+    createRepository();
+    createRepository();
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws RepositoryException
+   */
+  @Test
+  public void testCreateResourcePath() throws RepositoryException, IOException
+  {
+    Repository repository = createRepository();
+    String path = handler.createResourcePath(repository);
+
+    assertNotNull(path);
+    assertTrue(path.trim().length() > 0);
+    assertTrue(path.contains(repository.getName()));
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws RepositoryException
+   */
+  @Test
+  public void testDelete() throws RepositoryException, IOException
+  {
+    Repository repository = createRepository();
+
+    handler.delete(repository);
+
+    File directory = new File(baseDirectory, repository.getName());
+
+    assertFalse(directory.exists());
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws Exception
+   */
+  @Override
+  protected void postSetUp() throws Exception
+  {
+    MemoryStoreFactory storeFactory = new MemoryStoreFactory();
+
+    storeFactory.init(contextProvider);
+    baseDirectory = new File(contextProvider.getBaseDirectory(),
+                             "repositories");
+    IOUtil.mkdirs(baseDirectory);
+    handler = createRepositoryHandler(storeFactory, baseDirectory);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws Exception
+   */
+  @Override
+  protected void preTearDown() throws Exception
+  {
+    if (handler != null)
+    {
+      handler.close();
+    }
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @return
+   *
+   * @throws IOException
+   * @throws RepositoryException
+   */
+  private Repository createRepository() throws RepositoryException, IOException
+  {
+    Repository repository = RepositoryTestData.createHeartOfGold();
+
+    handler.create(repository);
+
+    File directory = new File(baseDirectory, repository.getName());
+
+    assertTrue(directory.exists());
+    assertTrue(directory.isDirectory());
+    checkDirectory(directory);
+
+    return repository;
+  }
+
+  //~--- fields ---------------------------------------------------------------
+
+  /** Field description */
+  protected File baseDirectory;
+
+  /** Field description */
+  private RepositoryHandler handler;
+}