Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-03-18 02:00:22 +01:00
Code Issues Packages Projects Releases Activity

Fixes incorrect warning "could not set executable flag"

Browse Source 
This warning was triggered, when the change was successful. Of course,
this should be the other way.
This commit is contained in:
René Pfeuffer
2022-04-01 11:28:17 +02:00
parent de9984ae2c
commit 07afe4b439
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/changelog/fix_executable_warning.yaml Normal file
View File

@@ -0,0 +1,2 @@
- type: fixed
description: Incorrect log warning "could not set executable flag"

2
scm-core/src/main/java/sonia/scm/repository/spi/ModifyWorkerHelper.java
View File

@@ -164,7 +164,7 @@ public interface ModifyWorkerHelper extends ModifyCommand.Worker {
}
boolean executable = Files.isExecutable(targetFile);
Files.move(file.toPath(), targetFile, REPLACE_EXISTING);
if (targetFile.toFile().setExecutable(executable)) {
if (!targetFile.toFile().setExecutable(executable)) {
LOG.warn("could not set executable flag for file {}", targetFile);
}
addFileToScm(path, targetFile);