Commit Graph

141 Commits

Author SHA1 Message Date
Marius Balteanu
8bf7f09112 Refactors parse_hires_images and parse_inline_attachments methods from ApplicationHelper to scrubbers (#43745).
git-svn-id: https://svn.redmine.org/redmine/trunk@24406 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-12 02:52:28 +00:00
Marius Balteanu
84483d6382 Stop traversal of child elements at @Loofah::Scrubber::STOP@ signal (#42737).
Patch by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@24400 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-07 10:38:27 +00:00
Marius Balteanu
a56413532c Optimize Loofah performance by passing the HTML only once (#42737).
git-svn-id: https://svn.redmine.org/redmine/trunk@24399 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-07 10:27:50 +00:00
Marius Balteanu
da5245ea06 Add stimulus clipboard_controller and render copy button on the backend using copypre_scrubber (#43643).
Patch by Takashi Kato (user:tohosaku).



git-svn-id: https://svn.redmine.org/redmine/trunk@24360 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-23 16:14:04 +00:00
Marius Balteanu
d46e990d5a Adds missing files from previous commit (#43643).
git-svn-id: https://svn.redmine.org/redmine/trunk@24359 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-23 16:09:34 +00:00
Marius Balteanu
f7f585a6d3 Unify syntax_highlight_scrubber in textile and common (#43643).
Patch by Takashi Kato (user:tohosaku).
 


git-svn-id: https://svn.redmine.org/redmine/trunk@24358 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-23 16:08:33 +00:00
Marius Balteanu
acf0f9019e Support Loofah for textile (#43643):
* Add TablesortScrubber to both CommonMark and Textile Formatters. It will now be determined on the server-side whether to use tablesort.
* Migrate tablesort to Stimulus controller.
* Update tablesort to v5.7.0.
* Switch tablesort to ESM.

Patch by Takashi Kato (user:tohosaku).



git-svn-id: https://svn.redmine.org/redmine/trunk@24357 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-23 16:05:42 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887).
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:38:01 +00:00
Go MAEDA
b3d1deeece Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:45:54 +00:00
Go MAEDA
6e21ae7209 Fix RuboCop offense Layout/SpaceAfterComma, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:36:05 +00:00
Go MAEDA
de76bb3a4a Fix RuboCop offense Layout/EmptyLinesAroundClassBody, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 07:42:12 +00:00
Marius Balteanu
b4bfb6b581 Replaces use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digest (#35217).
Patch by Jens Krämer (@jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@22816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-07 18:36:46 +00:00
Go MAEDA
1c17ae733d Fix initial_page_content method to avoid referencing @page instance variable in wiki formatting helpers (#40513).
Patch by Takuya Kodama (@otegami).


git-svn-id: https://svn.redmine.org/redmine/trunk@22781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-10 02:48:29 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
4607e90b43 Updates JS toolbar help button to use the new route (#39111, #40137).
git-svn-id: https://svn.redmine.org/redmine/trunk@22722 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:58:13 +00:00
Go MAEDA
5b77092be4 Replace regular expression matches with String#start_with? / end_with? (#40010).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-11 11:27:25 +00:00
Marius Balteanu
1f7f1a2db7 Allow consecutive footnote references inTextile (#39884).
Patch by @hjust.

git-svn-id: https://svn.redmine.org/redmine/trunk@22546 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-22 01:44:02 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888).
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
303abf0783 Use uri_with_link_safe_scheme? in Redcloth3 (#38807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22303 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-09-18 07:55:40 +00:00
Go MAEDA
ba181c7328 HTML-escape the entire tag content of escaped HTML tags in textile (#38807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22302 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-09-18 07:45:03 +00:00
Go MAEDA
0befc3a23c Fix RuboCop offense Style/RedundantSelfAssignmentBranch (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22263 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 01:37:24 +00:00
Go MAEDA
e0e751f5bc Fix RuboCop offense Style/RedundantRegexpArgument (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 00:39:58 +00:00
Go MAEDA
95f3b5cf38 Revert the change made in error in r22197 (#38435).
git-svn-id: https://svn.redmine.org/redmine/trunk@22198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-16 08:31:50 +00:00
Go MAEDA
0f6507a607 Change the notation of "contains any of" filter operator to "*~" (#38435).
git-svn-id: https://svn.redmine.org/redmine/trunk@22197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-16 08:02:30 +00:00
Go MAEDA
e010d90207 Fix RuboCop offense Performance/RedundantSplitRegexpArgument (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22033 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:33:32 +00:00
Go MAEDA
62a930cc65 Fix RuboCop offense Performance/RedundantMatch (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22032 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:31:57 +00:00
Go MAEDA
70ef2a3db1 Fix RuboCop offense Performance/ConstantRegexp (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:26:31 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
1d9f5c6742 Escape tags that start with pre (#37767).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-17 13:35:20 +00:00
Marius Balteanu
ba635eace9 Escape blockquote citation in textile formatting (#37751).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-04 18:58:37 +00:00
Marius Balteanu
1a7b2fe907 Move methods related to wiki section to a helper file and include it in all 3 formatters (#37119).
git-svn-id: https://svn.redmine.org/redmine/trunk@21643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-16 21:39:27 +00:00
Go MAEDA
b51d40fe38 Comments for Textile text formatting (#20511).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-17 03:55:24 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
87097f2204 Move preparation code to redmine/preparation.rb (#29914, #32938).
Patch by Takashi Kato.

git-svn-id: http://svn.redmine.org/redmine/trunk@21284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-17 20:45:39 +00:00
Marius Balteanu
b7798e6e1c Unify code block and add "data-language" attribute with the user-supplied language for Textile and Markdown formaters (#35104).
Patch by Martin Cizek.

git-svn-id: http://svn.redmine.org/redmine/trunk@21183 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-15 21:00:16 +00:00
Go MAEDA
f5ac84a516 Inline image in Textile is not displayed if the image URL contains ampersands (#35441).
Contributed by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-28 08:25:15 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
e6b7534345 shorten long line of lib/redmine/wiki_formatting/textile/helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20610 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-10 13:34:07 +00:00
Toshi MARUYAMA
385ac98c9d add empty line after guard clause to lib/redmine/wiki_formatting/textile/formatter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20227 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-28 14:43:21 +00:00
Go MAEDA
78dfef0978 Replace gsub with tr, delete, or squeeze (#34161).
git-svn-id: http://svn.redmine.org/redmine/trunk@20176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 06:46:50 +00:00
Go MAEDA
fdba424d77 Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20168 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-23 00:13:38 +00:00
Toshi MARUYAMA
a830a23d7b fix source indent of lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-03 11:45:37 +00:00
Jean-Philippe Lang
895fc12d56 XSS vulnerabilities in textile links (#32934).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19672 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:41:33 +00:00
Jean-Philippe Lang
d257990868 Reverts r19489 (#32934).
git-svn-id: http://svn.redmine.org/redmine/trunk@19671 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:35:44 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
0ba13a0bd3 Fix a RuboCop offence Style/NegatedWhile (#32971).
git-svn-id: http://svn.redmine.org/redmine/trunk@19542 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 11:18:18 +00:00
Go MAEDA
2253032ebc Newline between list items break a list (#32971).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19536 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 04:21:53 +00:00
Jean-Philippe Lang
e9d5b0b8dc White list protocols allowed for Textile links (#32934).
git-svn-id: http://svn.redmine.org/redmine/trunk@19489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 10:19:16 +00:00
Go MAEDA
6611f5bf5d Make languages in Highlighted code button in toolbar customizable (#32528).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19429 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-14 14:38:48 +00:00
Toshi MARUYAMA
5876324372 filter all possibly class values on code tags in Textile (#25742)
Contributed by Holger Just from Planio.

git-svn-id: http://svn.redmine.org/redmine/trunk@19333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-05 11:25:24 +00:00