Optimize Loofah performance by passing the HTML only once (#42737).

git-svn-id: https://svn.redmine.org/redmine/trunk@24399 e93f8b46-1217-0410-a6f0-8f06a7374b81

lib/redmine/wiki_formatting/common_mark/formatter.rb

@@ -73,9 +73,13 @@ module Redmine
           html = MarkdownFilter.new(@text, PIPELINE_CONFIG).call
           fragment = Redmine::WikiFormatting::HtmlParser.parse(html)
           SANITIZER.call(fragment)
-          SCRUBBERS.each do |scrubber|
-            fragment.scrub!(scrubber)
+          scrubber = Loofah::Scrubber.new do |node|
+            SCRUBBERS.each do |s|
+              s.scrub(node)
+              break if node.parent.nil?
+            end
           end
+          fragment.scrub!(scrubber)
           fragment.to_s
         end
       end

lib/redmine/wiki_formatting/html_sanitizer.rb

@@ -27,9 +27,13 @@ module Redmine
       def self.call(html)
         fragment = HtmlParser.parse(html)
         SANITIZER.call(fragment)
-        SCRUBBERS.each do |scrubber|
-          fragment.scrub!(scrubber)
+        scrubber = Loofah::Scrubber.new do |node|
+          SCRUBBERS.each do |s|
+            s.scrub(node)
+            break if node.parent.nil?
+          end
         end
+        fragment.scrub!(scrubber)
         fragment.to_s
       end
     end

lib/redmine/wiki_formatting/textile/formatter.rb

@@ -39,9 +39,13 @@ module Redmine
         def to_html(*rules)
           html = @filter.to_html(rules)
           fragment = Loofah.html5_fragment(html)
-          SCRUBBERS.each do |scrubber|
-            fragment.scrub!(scrubber)
+          scrubber = Loofah::Scrubber.new do |node|
+            SCRUBBERS.each do |s|
+              s.scrub(node)
+              break if node.parent.nil?
+            end
           end
+          fragment.scrub!(scrubber)
           fragment.to_s
         end
       end