Commit Graph

130 Commits

Author SHA1 Message Date
Marius Balteanu
fffed57cd7 Reverts unwanted change (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24205 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-08 08:35:17 +00:00
Marius Balteanu
c749dc2bd3 Adds webooks for versions (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24204 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-06 13:59:14 +00:00
Go MAEDA
7e4acb6b23 Optimize Version::FixedIssuesExtension#issues_progress by avoiding repeated Issue#closed? calls (#42673).
Since the issues are already filtered by open or closed status using the `open` argument through the `self.open(open)` scope, the call to expensive method `Issue#closed?` can be safely replaced with a check of the `open` argument.

Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-06 06:45:36 +00:00
Go MAEDA
a1b5495e89 Fix Rubocop Style/ArgumentsForwarding (#42496).
git-svn-id: https://svn.redmine.org/redmine/trunk@23698 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-21 05:57:01 +00:00
Go MAEDA
2ffe3fa547 Optimize Version#wiki_page method (#42121).
Avoid unnecessary evaluation of `project.wiki` when `wiki_page_title` is blank, reducing redundant SQL queries.

Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-20 08:36:22 +00:00
Go MAEDA
b3308d126a Optimize Version#behind_schedule? by avoiding the call to completed_percent when due_date or start_date is nil (#40798).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22882 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 07:10:29 +00:00
Go MAEDA
35aa00f7ac Optimize FixedIssuesExtension#closed_percent by bypassing issues_progress when all issues are closed (#40798).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 06:57:57 +00:00
Go MAEDA
c132b178a1 Optimize Version model by reducing redundant SQL count queries (#40798).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 06:55:36 +00:00
Go MAEDA
ddde0ff47d Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 03:11:08 +00:00
Go MAEDA
c1335f5126 Suppress RuboCop false positive for Security/Open (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-06 01:20:23 +00:00
Go MAEDA
f9eb77227a Fix RuboCop offense Naming/MemoizedInstanceVariableName (#37862, #1671).
git-svn-id: https://svn.redmine.org/redmine/trunk@22860 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-05 08:21:59 +00:00
Marius Balteanu
82c88b3700 Adds estimated remaining time to version page (#37862, #1671).
git-svn-id: https://svn.redmine.org/redmine/trunk@22858 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:17:01 +00:00
Go MAEDA
b42d7984b1 Fix RuboCop offense Style/SuperArguments (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-23 11:25:16 +00:00
Marius Balteanu
1a96ee225d Fixes RuboCop offense Performance/Sum (#24457, #4682).
git-svn-id: https://svn.redmine.org/redmine/trunk@22805 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-02 21:35:16 +00:00
Marius Balteanu
cd8d4fe444 Progress of version should be calculated the same way as parent tasks (#24457, #4682).
git-svn-id: https://svn.redmine.org/redmine/trunk@22803 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-02 20:58:03 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 14:42:54 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
05e9d7883b Use sanitize_sql_like in like scopes (#35073).
Patch Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Go MAEDA
2a564a1376 DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
581fb1f96d use "do end" instead of {} at ActiveRecord scope lambda of app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20343 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:27 +00:00
Toshi MARUYAMA
aaebab85c5 add empty line after guard clause to app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20264 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-05 13:42:31 +00:00
Toshi MARUYAMA
52eba6ead5 remove spaces inside {} of app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-03 15:36:35 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
4696722a53 cleanup: rubocop: fix Layout/AlignArguments in app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-06 08:59:53 +00:00
Toshi MARUYAMA
4c22248143 code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 05:07:29 +00:00
Go MAEDA
c37d1b43a4 Reject version custom field values not visible for the user (#31954, #23997).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:44:39 +00:00
Go MAEDA
22165fd071 Per role visibility settings for version custom fields (#23997).
Patch by Jens Krämer and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18386 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-24 08:50:17 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
f0d579adeb Fix that deleting a version silently deletes its attachments (#31087).
Patch by Karel Pičman and Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18008 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-26 11:05:20 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
537f162f27 Moved Version#fixed_issues extension to a module (#30115).
Patch by Jérôme BATAILLE.

git-svn-id: http://svn.redmine.org/redmine/trunk@17754 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-16 16:01:00 +00:00
Jean-Philippe Lang
d8a2024715 Dangerous query method deprecation warnings (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@17411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-23 05:19:07 +00:00
Go MAEDA
8662c7ef8b Filter for version name should be case-insensitive (#27122).
Patch by Holger Just and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17316 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-28 23:31:49 +00:00
Jean-Philippe Lang
d0b10af3ff Performance opt - cache AR Proxy for Version#fixed_issues.visible (#27676).
Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17052 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:01 +00:00
Jean-Philippe Lang
96a854a4b3 Moves issue calculations into the fixed_issues relation (#27676).
This way, we can reuse them on refined relations,
e.g. @version.fixed_issues.closed_count@ vs. @version.fixed_issues.visible.closed_count@

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17050 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:36:13 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
cfda8cdb91 remove trailing white space from app/models/version.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-08 06:20:07 +00:00
Jean-Philippe Lang
7b3f2b51c0 Add length validations for string fields (#24283).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@15989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-19 11:13:41 +00:00
Jean-Philippe Lang
eb023bdcce Add option to set a new version as default directly from New Version page (#24011).
git-svn-id: http://svn.redmine.org/redmine/trunk@15922 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-23 11:31:20 +00:00
Jean-Philippe Lang
efabbedebe Enable filtering versions on Project -> Settings -> Versions (#22608).
git-svn-id: http://svn.redmine.org/redmine/trunk@15759 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-08-30 21:05:22 +00:00
Jean-Philippe Lang
050d2bee84 2 spaces instead of a tab.
git-svn-id: http://svn.redmine.org/redmine/trunk@15602 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-02 10:01:37 +00:00
Jean-Philippe Lang
0b16423104 Group versions by status in issue filters (#10412).
git-svn-id: http://svn.redmine.org/redmine/trunk@15601 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-02 09:44:53 +00:00