Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2026-01-27 17:59:58 +01:00
Code Issues Packages Projects Releases Activity

Optimize Version#behind_schedule? by avoiding the call to completed_percent when due_date or start_date is nil (#40798).

Browse Source 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22882 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2024-06-17 07:10:29 +00:00
parent 35aa00f7ac
commit b3308d126a
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/models/version.rb
View File

@@ -269,14 +269,11 @@ class Version < ApplicationRecord
end
def behind_schedule?
if completed_percent == 100
return false
elsif due_date && start_date
done_date = start_date + ((due_date - start_date+1)* completed_percent/100).floor
return done_date <= User.current.today
else
false # No issues so it's not late
end
# Blank due date, no issues, or 100% completed, so it's not late
return false if due_date.nil? || start_date.nil? || completed_percent == 100
done_date = start_date + ((due_date - start_date + 1) * completed_percent / 100).floor
done_date <= User.current.today
end
# Returns the completion percentage of this version based on the amount of open/closed issues