Commit Graph

1391 Commits

Author SHA1 Message Date
Julian Lam
aaeb0be0d8 Merge branch 'develop' into bootstrap5 2022-11-09 13:31:50 -05:00
Julian Lam
892ac2eb20 Merge branch 'master' into develop 2022-11-09 13:31:31 -05:00
Julian Lam
2f9d8c350e fix: pass csrf_token into calls to /register/abort, #11017 2022-11-09 13:20:28 -05:00
Julian Lam
515af200ee Merge branch 'develop' into bootstrap5 2022-11-09 12:17:21 -05:00
Julian Lam
97d8b53fd3 Merge branch 'master' into develop 2022-11-09 12:15:24 -05:00
Barış Soner Uşaklı
06d1539137 test: fix tests again 2022-10-29 17:40:33 -04:00
Barış Soner Uşaklı
c833d3cdc4 test: fix test 2022-10-29 17:05:16 -04:00
Julian Lam
6da286c22b test: abort controller for interstitials 2022-10-24 15:33:52 -04:00
Julian Lam
ddf7537301 test: fix tests for changes to membershipBtn helper 2022-10-24 14:57:00 -04:00
Julian Lam
96b46411b1 Merge branch 'master' into develop 2022-10-18 15:38:36 -04:00
Julian Lam
c1081f7039 Merge branch 'master' into bootstrap5 2022-10-18 15:21:20 -04:00
Julian Lam
9c576a0758 Email confirmation QOL updates (#10987)
* breaking: remove `SocketUser.emailConfirm`, re: #10954

* chore: move email confirmation related configs to own section in Settings > Email

* feat: new user email method `getValidationExpiry`, returns expiration in ms.. probably.

* fix: bug where `user.email.isValidationPending` returned an u nexpected non-boolean value if there was no confirmation pending (only when checking email as well)

* fix: update getValidationExpiry to return ms

* test: use emailConfirmInterval for tests, for now

* fix: throw friendly error when attempting an email change within email confirmation window

* feat: new config option `emailConfirmExpiry` in days, governs how long the confirm link is good for

* test: additional tests for user email methods

* fix: add back missing handling of  option

* test: fix tests
2022-10-18 15:12:13 -04:00
Julian Lam
c285f72e12 fix: bug that allowed for bypass of GDPR interstitial on SSO registrations simply by cancelling the form 2022-10-11 10:46:12 -04:00
Barış Soner Uşaklı
9d0b1d5092 refactor: remove unused code 2022-10-08 20:03:35 -04:00
Barış Soner Uşaklı
61d32bdebb fix: category ordering add test 2022-10-03 09:41:40 -04:00
Barış Soner Uşaklı
177d904812 fix: category ordering add test 2022-10-03 09:41:08 -04:00
Barış Soner Uşaklı
389a2df9bf fix: category ordering add test 2022-10-03 09:40:54 -04:00
Julian Lam
d45a34fdb8 test: fix tests so that when user.create is called, email is set prior to confirmation 2022-09-27 14:34:01 -04:00
Julian Lam
ee77ce0789 chore: remove deprecated socket.io user export methods [breaking] 2022-09-27 13:34:00 -04:00
Julian Lam
1d63fc469a chore: remove deprecated old routes for user data exports [breaking] 2022-09-27 11:23:52 -04:00
Barış Soner Uşaklı
6b4e00fd47 test: fix profile pic test 2022-09-21 13:01:00 -04:00
Barış Soner Uşaklı
bfb63061c7 test: fix theme test 2022-09-21 12:49:15 -04:00
Julian Lam
dcfcc5ea2c Merge remote-tracking branch 'origin/develop' into bootstrap5 2022-09-21 12:12:27 -04:00
Julian Lam
6391f77b01 Merge remote-tracking branch 'origin/master' into develop 2022-09-20 14:04:02 -04:00
Barış Soner Uşaklı
75dc78b738 perf: ltr/rtl change
fix modals
2022-09-17 21:32:31 -04:00
Barış Soner Uşaklı
b5dd89e1c0 feat: store topic title and tags in diffs (#10900)
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
2022-09-16 22:16:08 -04:00
Barış Soner Uşaklı
916759b802 test: build test fix 2022-09-15 10:10:03 -04:00
Barış Soner Uşaklı
c039a699bd sharp test fix 2022-09-13 12:36:13 -04:00
Barış Soner Uşaklı
401aaf1757 fix floats 2022-09-12 18:34:37 -04:00
Barış Soner Uşaklı
1c9c39a8c8 test: add back /admin/extend/plugins test 2022-09-04 19:42:12 -04:00
Barış Soner Uşaklı
b45e241390 lint: fix lint error 2022-09-04 10:36:57 -04:00
Barış Soner Uşaklı
1dc79d76a0 test: disable nbbpm test temporarily 2022-09-04 10:32:22 -04:00
Julian Lam
15b1561fd3 feat: introduce ACP defined option to rescind notif or do nothing on flag resolve/reject
/cc #10867
2022-08-26 16:05:45 -04:00
Julian Lam
b3b48fa62f Merge remote-tracking branch 'origin/master' into develop 2022-08-25 16:42:53 -04:00
Julian Lam
7c5a915dc9 test: have some build tests not pollute build folder 2022-08-23 11:23:49 -04:00
gasoved
b424ba4637 test: User.hidePrivateData 2022-08-22 13:47:33 -04:00
Julian Lam
c07d595662 Update to lru-cache@^7 (#10815)
* chore(deps): bump lru-cache from 6.0.0 to 7.13.1 in /install

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 6.0.0 to 7.13.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-lru-cache/compare/v6.0.0...v7.13.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(lru-cache): remove unneeded `length` params for cache creation, as `maxSize` was not used in those init calls, also renamed some methods to match new method names in lru-cache [breaking]

Added deprecation notices for old params

* fix: replace three direct calls to lru-cache with call to cacheCreate, moved cache creation call in uploads to run on first init as config is not populated at lib init

* test: move configs init above cache reset calls in databasemock

* move some more code above cache clear

* refactor: remove unused

* test: lru

* test: more debug

* test: on more test

* use await helpers.uploadFile

* fix: tests remove logs

* fix: acp cache page

* fix: add in one more guard again cache instantiation with `length` prop but no `maxSize` prop

* fix(deps): bump markdown

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2022-08-10 13:24:16 -04:00
Julian Lam
59f3ae201a Merge remote-tracking branch 'origin/master' into develop 2022-08-10 09:52:49 -04:00
Barış Soner Uşaklı
961be70725 fix test on redis 2022-08-09 18:26:46 -04:00
Julian Lam
65c59cc16a test: additional tests for password challenge on email update 2022-08-05 14:39:36 -04:00
Julian Lam
8e1a4bb5df test: add dummy emailer hook to suppress sendmail error logging 2022-08-05 14:39:36 -04:00
Julian Lam
68bcd7f48e test: fix one last failing test 2022-08-05 14:39:36 -04:00
Julian Lam
342cca35c1 chore: re-order interstitial tests so email and gdpr tests are in sub-blocks 2022-08-05 14:39:36 -04:00
Julian Lam
9ee1afbb0f Merge branch 'master' into develop 2022-08-04 16:04:09 -04:00
Julian Lam
06f089afda test: fix user email tests 2022-08-04 16:02:16 -04:00
Julian Lam
3b296c3aa4 Merge remote-tracking branch 'origin/master' into develop 2022-08-04 14:26:07 -04:00
Julian Lam
f93a0b83bb test: fix tests so that when user.create is called, email is set prior to confirmation 2022-08-04 14:24:30 -04:00
Julian Lam
1ca09b63ed fix: #10809, test runner to only run tests for plugins included in test_plugins 2022-08-04 14:20:36 -04:00
Opliko
23cb67a112 feat: Allow defining active plugins in config (#10767)
* Revert "Revert "feat: cross origin opener policy options (#10710)""

This reverts commit 46050ace1a.

* Revert "Revert "chore(i18n): fallback strings for new resources: nodebb.admin-settings-advanced""

This reverts commit 9f291c07d3.

* feat: closes #10719, don't trim children if category is marked section

* feat: fire hook to allow plugins to filter the pids returned in a user profile

/cc julianlam/nodebb-plugin-support-forum#14

* fix: use `user.hidePrivateData();` more consistently across user retrieval endpoints

* feat: Allow defining active plugins in config

resolves #10766

* fix: assign the db result to files properly

* test: add tests with plugins in config

* feat: better theme change handling

* feat: add visual indication that plugins can't be activated

* test: correct hooks

* test: fix test definitions

* test: remove instead of resetting nconf to avoid affecting other tests

* test: ... I forgot how nconf worked

* fix: remove negation

* docs: improve wording of error message

* feat: reduce code duplication

* style: remove a redundant space

* fix: remove unused imports

* fix: use nconf instead of requiring config.json

* fix: await...

* fix: second missed await

* fix: move back from getActiveIds to getActive

* fix: use paths again?

* fix: typo

* fix: move require into the function

* fix: forgot to change back to getActive

* test: getActive returns only id

* test: accedently commented out some stuff

* feat: added note to top of plugins page if \!canChangeState

Co-authored-by: Julian Lam <julian@nodebb.org>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2022-07-26 14:27:17 -04:00
Julian Lam
05c30677f5 test: fix i18n tests 2022-06-17 14:26:12 -04:00