Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-20 22:43:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove deprecated socket.io user export methods [breaking]

Browse Source
This commit is contained in:
Julian Lam
2022-09-27 11:57:10 -04:00
parent 1d63fc469a
commit ee77ce0789
2 changed files with 3 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/socket.io/user/profile.js
View File

@@ -48,32 +48,4 @@ module.exports = function (SocketUser) {
await user.blocks[isBlocked ? 'remove' : 'add'](data.blockeeUid, data.blockerUid);
return !isBlocked;
};
SocketUser.exportProfile = async function (socket, data) {
await doExport(socket, data, 'profile');
};
SocketUser.exportPosts = async function (socket, data) {
await doExport(socket, data, 'posts');
};
SocketUser.exportUploads = async function (socket, data) {
await doExport(socket, data, 'uploads');
};
async function doExport(socket, data, type) {
sockets.warnDeprecated(socket, 'POST /api/v3/users/:uid/exports/:type');
if (!socket.uid) {
throw new Error('[[error:invalid-uid]]');
}
if (!data || parseInt(data.uid, 10) <= 0) {
throw new Error('[[error:invalid-data]]');
}
await user.isAdminOrSelf(socket.uid, data.uid);
api.users.generateExport(socket, { type, ...data });
}
};

12
test/api.js
View File

@@ -24,6 +24,7 @@ const plugins = require('../src/plugins');
const flags = require('../src/flags');
const messaging = require('../src/messaging');
const utils = require('../src/utils');
const api = require('../src/api');
describe('API', async () => {
let readApi = false;
@@ -190,17 +191,10 @@ describe('API', async () => {
path: 'files/test.png',
});
const socketUser = require('../src/socket.io/user');
const socketAdmin = require('../src/socket.io/admin');
// export data for admin user
await socketUser.exportProfile({ uid: adminUid }, { uid: adminUid });
await wait(2000);
await socketUser.exportPosts({ uid: adminUid }, { uid: adminUid });
await wait(2000);
await socketUser.exportUploads({ uid: adminUid }, { uid: adminUid });
await wait(2000);
await Promise.all(['profile', 'posts', 'uploads'].map(async type => api.users.generateExport({ uid: adminUid }, { uid: adminUid, type })));
await socketAdmin.user.exportUsersCSV({ uid: adminUid }, {});
// wait for export child process to complete
// wait for export child processes to complete
await wait(5000);
// Attach a search hook so /api/search is enabled