Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-06 16:06:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle remote objects reporting a local context, #14188

Browse Source
This commit is contained in:
Julian Lam
2026-04-20 12:48:47 -04:00
parent a537e38493
commit ffab31bd62
2 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/activitypub/helpers.js
View File

@@ -197,6 +197,9 @@ Helpers.resolveLocalId = async (input) => {
case 'post':
return { type: 'post', id: value, ...activityData };
case 'topic':
return { type: 'topic', id: value, ...activityData };
case 'cid':
case 'category':
return { type: 'category', id: value, ...activityData };

37
src/activitypub/notes.js
View File

@@ -82,18 +82,33 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
const { tid } = context;
return { tid, count: 0 };
} else if (context.context) {
chain = Array.from(await activitypub.contexts.getItems(uid, context.context, { input }));
if (chain && chain.length) {
// Deduplicate by id (just in case, also a buggy NodeBB impl. sent dupes)
const ids = new Set();
chain = chain.filter((item) => {
const seen = ids.has(item.pid);
ids.add(item.pid);
return !seen;
});
const { type, id: tid } = await activitypub.helpers.resolveLocalId(context.context);
if (!type === 'topic') {
chain = Array.from(await activitypub.contexts.getItems(uid, context.context, { input }));
if (chain && chain.length) {
// Deduplicate by id (just in case, also a buggy NodeBB impl. sent dupes)
const ids = new Set();
chain = chain.filter((item) => {
const seen = ids.has(item.pid);
ids.add(item.pid);
return !seen;
});
// Context resolves, use in later topic creation
context = context.context;
// Context resolves, use in later topic creation
context = context.context;
}
} else {
// Local context, get local posts
const mainPid = await topics.getTopicField(tid, 'mainPid');
const pids = await db.getSortedSetMembers(`tid:${tid}:posts`);
pids.unshift(mainPid);
chain = await posts.getPostsData(pids);
// Add received object to chain if not present already
if (!pids.includes(input.id)) {
const mocked = await activitypub.mocks.post(input);
chain.push(mocked);
}
}
} else {
context = undefined;