Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-06-20 14:10:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

optimize getParents

Browse Source 
when loading the root categories listing all categories have a parentCid
of 0 so return early instead of calling the database with
['category:0','category:0','category:0''category:0' ...]
This commit is contained in:
barisusakli
2015-09-16 18:13:03 -04:00
parent f6b4080949
commit da09ce3e06
1 changed files with 25 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/categories.js
View File

@@ -293,21 +293,34 @@ var async = require('async'),
}
Categories.getParents = function(cids, callback) {
Categories.getMultipleCategoryFields(cids, ['parentCid'], function(err, data) {
if (err) {
return callback(err);
}
var categoriesData;
var parentCids;
async.waterfall([
function (next) {
Categories.getMultipleCategoryFields(cids, ['parentCid'], next);
},
function (_categoriesData, next) {
categoriesData = _categoriesData;
var parentCids = data.map(function(category) {
if (category && category.hasOwnProperty('parentCid') && category.parentCid) {
return category.parentCid;
} else {
return 0;
parentCids = categoriesData.filter(function(category) {
return category && category.hasOwnProperty('parentCid') && category.parentCid;
}).map(function(category) {
return parseInt(category.parentCid, 10);
});
if (!parentCids.length) {
return callback(null, cids.map(function() {return null;}));
}
});
Categories.getCategoriesData(parentCids, callback);
});
Categories.getCategoriesData(parentCids, next);
},
function (parentData, next) {
parentData = categoriesData.map(function(category) {
return parentData[parentCids.indexOf(parseInt(category.parentCid, 10))];
});
next(null, parentData);
}
], callback);
};
Categories.getChildren = function(cids, uid, callback) {