Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-18 21:42:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

add await to notify functions

Browse Source 
and wrap in try/catch
This commit is contained in:
Barış Soner Uşaklı
2025-02-11 10:16:40 -05:00
parent d1f78295ba
commit 893089709c
1 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/topics/create.js
View File

@@ -2,6 +2,7 @@
'use strict';
const _ = require('lodash');
const winston = require('winston');
const db = require('../database');
const utils = require('../utils');
@@ -154,12 +155,19 @@ module.exports = function (Topics) {
plugins.hooks.fire('action:topic.post', { topic: topicData, post: postData, data: data });
if (!topicData.scheduled) {
if (utils.isNumber(uid)) {
// New topic notifications only sent for local-to-local follows only
user.notifications.sendTopicNotificationToFollowers(uid, topicData, postData);
}
Topics.notifyTagFollowers(postData, uid);
categories.notifyCategoryFollowers(postData, uid);
setImmediate(async () => {
try {
if (utils.isNumber(uid)) {
// New topic notifications only sent for local-to-local follows only
await user.notifications.sendTopicNotificationToFollowers(uid, topicData, postData);
}
await Topics.notifyTagFollowers(postData, uid);
await categories.notifyCategoryFollowers(postData, uid);
} catch (err) {
winston.error(err.stack);
}
});
}
return {
@@ -211,13 +219,17 @@ module.exports = function (Topics) {
}
if (parseInt(uid, 10) || activitypub.helpers.isUri(uid) || meta.config.allowGuestReplyNotifications) {
const { displayname } = postData.user;
Topics.notifyFollowers(postData, uid, {
type: 'new-reply',
bodyShort: translator.compile('notifications:user-posted-to', displayname, postData.topic.title),
nid: `new_post:tid:${postData.topic.tid}:pid:${postData.pid}:uid:${uid}`,
mergeId: `notifications:user-posted-to|${postData.topic.tid}`,
setImmediate(async () => {
try {
await Topics.notifyFollowers(postData, uid, {
type: 'new-reply',
bodyShort: translator.compile('notifications:user-posted-to', postData.user.displayname, postData.topic.title),
nid: `new_post:tid:${postData.topic.tid}:pid:${postData.pid}:uid:${uid}`,
mergeId: `notifications:user-posted-to|${postData.topic.tid}`,
});
} catch (err) {
winston.error(err.stack);
}
});
}