Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-07-08 10:03:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: deprecate /plugins shorthand route, closes #10343

Browse Source
This commit is contained in:
Julian Lam
2022-02-25 10:57:34 -05:00
parent 57a64b7809
commit 7b1eba058f
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/routes/index.js
View File

@@ -4,6 +4,7 @@ const nconf = require('nconf');
const winston = require('winston');
const path = require('path');
const express = require('express');
const chalk = require('chalk');
const meta = require('../meta');
const controllers = require('../controllers');
@@ -172,7 +173,6 @@ function addCoreRoutes(app, router, middleware, mounts) {
{ route: '/assets', path: path.join(__dirname, '../../build/public') },
{ route: '/assets', path: path.join(__dirname, '../../build/webpack') }, // todo: messy; relocate in v3
{ route: '/assets', path: path.join(__dirname, '../../public') },
{ route: '/plugins', path: path.join(__dirname, '../../build/public/plugins') },
];
const staticOptions = {
maxAge: app.enabled('cache') ? 5184000000 : 0,
@@ -188,6 +188,10 @@ function addCoreRoutes(app, router, middleware, mounts) {
app.use(`${relativePath}/uploads`, (req, res) => {
res.redirect(`${relativePath}/assets/uploads${req.path}?${meta.config['cache-buster']}`);
});
app.use(`${relativePath}/plugins`, (req, res) => {
winston.warn(`${chalk.bold.red('[deprecation]')} The \`/plugins\` shorthand prefix is deprecated, prefix with \`/assets/plugins\` instead (path: ${req.path})`);
res.redirect(`${relativePath}/assets/plugins${req.path}${req._parsedUrl.search || ''}`);
});
// Skins
meta.css.supportedSkins.forEach((skin) => {