Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-07 06:37:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: on exit, dont write analytics data on all nodes

Browse Source 
if you are running 4 nodebbs each one was calling writeData which could trigger duplicate key errors
This commit is contained in:
Barış Soner Uşaklı
2026-03-27 16:45:20 -04:00
parent 4b503db497
commit 6c4e928482
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/analytics.js
View File

@@ -38,11 +38,7 @@ Analytics.init = async function () {
runOnAllNodes: true, runOnAllNodes: true,
onTick: async () => { onTick: async () => {
if (Analytics.pause) return; if (Analytics.pause) return;
publishLocalAnalytics(); await Analytics.writeLocalData();
if (runJobs) {
await sleep(2000);
await Analytics.writeData();
}
}, },
}); });
@@ -63,6 +59,14 @@ Analytics.init = async function () {
} }
}; };
Analytics.writeLocalData = async function () {
publishLocalAnalytics();
if (runJobs) {
await sleep(2000);
await Analytics.writeData();
}
};
function publishLocalAnalytics() { function publishLocalAnalytics() {
pubsub.publish('analytics:publish', { pubsub.publish('analytics:publish', {
local: local, local: local,

2
src/start.js
View File

@@ -149,7 +149,7 @@ async function shutdown(code) {
try { try {
await require('./webserver').destroy(); await require('./webserver').destroy();
winston.info('[app] Web server closed to connections.'); winston.info('[app] Web server closed to connections.');
await require('./analytics').writeData(); await require('./analytics').writeLocalData();
winston.info('[app] Live analytics saved.'); winston.info('[app] Live analytics saved.');
const db = require('./database'); const db = require('./database');
await db.delete('locks'); await db.delete('locks');