From 6c4e9284822e37b5f77100705a8441e09b1854a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?=
 <barisusakli@gmail.com>
Date: Fri, 27 Mar 2026 16:45:20 -0400
Subject: [PATCH] fix: on exit, dont write analytics data on all nodes

if you are running 4 nodebbs each one was calling writeData which could trigger duplicate key errors
---
 src/analytics.js | 14 +++++++++-----
 src/start.js     |  2 +-
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/analytics.js b/src/analytics.js
index e054e2e733..f64c651687 100644
--- a/src/analytics.js
+++ b/src/analytics.js
@@ -38,11 +38,7 @@ Analytics.init = async function () {
 		runOnAllNodes: true,
 		onTick: async () => {
 			if (Analytics.pause) return;
-			publishLocalAnalytics();
-			if (runJobs) {
-				await sleep(2000);
-				await Analytics.writeData();
-			}
+			await Analytics.writeLocalData();
 		},
 	});
 
@@ -63,6 +59,14 @@ Analytics.init = async function () {
 	}
 };
 
+Analytics.writeLocalData = async function () {
+	publishLocalAnalytics();
+	if (runJobs) {
+		await sleep(2000);
+		await Analytics.writeData();
+	}
+};
+
 function publishLocalAnalytics() {
 	pubsub.publish('analytics:publish', {
 		local: local,
diff --git a/src/start.js b/src/start.js
index 00a129e33f..89a1683703 100644
--- a/src/start.js
+++ b/src/start.js
@@ -149,7 +149,7 @@ async function shutdown(code) {
 	try {
 		await require('./webserver').destroy();
 		winston.info('[app] Web server closed to connections.');
-		await require('./analytics').writeData();
+		await require('./analytics').writeLocalData();
 		winston.info('[app] Live analytics saved.');
 		const db = require('./database');
 		await db.delete('locks');