Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-22 20:32:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

wrapImagesInLinks with <a download> attribute

Browse Source 
if the `src` of the `img` does not have an extension, most browsers will trigger a download with whatever filename is set, also without an extension, so when it's opened in any OS, it wont have a default application to open it with.

So, In this case, if the `alt` attribute has an extension (meaning if it looks like filename) - we use that with the html5 [`download` attr](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download)

The PR does not affect any src if they have an extension.
This commit is contained in:
Aziz Khoury
2017-03-22 12:19:31 +02:00
committed by GitHub
parent b6134b160e
commit 6682e048ea
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
public/src/client/topic/images.js
View File

@@ -97,19 +97,25 @@ define('forum/topic/images', [
Images.wrapImagesInLinks = function (posts) {
posts.find('[component="post/content"] img:not(.emoji)').each(function () {
var $this = $(this);
var src = $this.attr('src');
var src = $this.attr('src') || '';
var alt = $this.attr('alt') || '';
var suffixRegex = /-resized(\.[\w]+)?$/;
if (src === 'about:blank') {
return;
}
if (utils.isRelativeUrl(src) && suffixRegex.test(src)) {
src = src.replace(suffixRegex, '$1');
}
var srcExt = src.split('.').slice(1).pop();
var altFilename = alt.split('/').pop();
var altExt = altFilename.split('.').slice(1).pop();
if (!$this.parent().is('a')) {
$this.wrap('<a href="' + src + '" target="_blank">');
$this.wrap('<a href="' + src + '" '
+ (!srcExt && altExt ? ' download="' + altFilename + '" ' : '')
+ ' target="_blank" >');
}
});
};