Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-05-05 21:36:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

removed client-side chat message length check in favour of server-side check, firing new hook on messaging.checkContent for hooks to intercept

Browse Source
This commit is contained in:
Julian Lam
2018-08-29 14:31:39 -04:00
parent e79f0dad90
commit 5c04ec2d63
2 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/src/client/chats/messages.js
View File

@@ -8,10 +8,6 @@ define('forum/chats/messages', ['components', 'sounds', 'translator', 'benchpres
var msg = inputEl.val();
var mid = inputEl.attr('data-mid');
if (msg.length > ajaxify.data.maximumChatMessageLength) {
return app.alertError('[[error:chat-message-too-long,' + ajaxify.data.maximumChatMessageLength + ']]');
}
if (!msg.length) {
return;
}

19
src/messaging/create.js
View File

@@ -30,13 +30,20 @@ module.exports = function (Messaging) {
if (!content) {
return callback(new Error('[[error:invalid-chat-message]]'));
}
content = String(content);
var maximumChatMessageLength = (meta.config.maximumChatMessageLength || 1000);
if (content.length > maximumChatMessageLength) {
return callback(new Error('[[error:chat-message-too-long, ' + maximumChatMessageLength + ']]'));
}
callback();
plugins.fireHook('filter:messaging.checkContent', { content: content }, function (err, data) {
if (err) {
return callback(err);
}
content = String(data.content);
var maximumChatMessageLength = (meta.config.maximumChatMessageLength || 1000);
if (content.length > maximumChatMessageLength) {
return callback(new Error('[[error:chat-message-too-long, ' + maximumChatMessageLength + ']]'));
}
callback();
});
};
Messaging.addMessage = function (data, callback) {