Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-20 22:43:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: navigator not properly updating url

Browse Source 
remove threshold not used anymore
This commit is contained in:
Barış Soner Uşaklı
2022-09-29 15:13:05 -04:00
parent 5dc74abcf1
commit 375dad8961
1 changed files with 5 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
public/src/modules/navigator.js
View File

@@ -373,12 +373,7 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
}
};
navigator.update = function (threshold) {
/*
The "threshold" is defined as the distance from the top of the page to
a spot where a user is expecting to begin reading.
*/
threshold = typeof threshold === 'number' ? threshold : undefined;
navigator.update = function () {
let newIndex = index;
const els = $(navigator.selector);
if (els.length) {
@@ -415,21 +410,8 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
newIndex = count;
}
// If a threshold is undefined, try to determine one based on new index
if (threshold === undefined && ajaxify.data.template.topic) {
if (atTop) {
threshold = 0;
} else {
const anchorEl = components.get('post/anchor', index - 1);
if (anchorEl.length) {
const anchorRect = anchorEl.get(0).getBoundingClientRect();
threshold = anchorRect.top;
}
}
}
if (typeof navigator.callback === 'function') {
navigator.callback(newIndex, count, threshold);
navigator.callback(newIndex, count);
}
if (newIndex !== index) {
@@ -445,6 +427,9 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
navigator.setIndex = (newIndex) => {
index = newIndex + 1;
if (typeof navigator.callback === 'function') {
navigator.callback(index, count);
}
navigator.updateTextAndProgressBar();
setThumbToIndex(index);
};