Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-19 19:11:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: logic in checkRequired

Browse Source 
if req.body was undefined req.query wasn't checked
This commit is contained in:
Barış Soner Uşaklı
2026-03-03 11:33:52 -05:00
parent b268164686
commit 2428602f27
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/middleware/index.js
View File

@@ -308,14 +308,20 @@ middleware.validateAuth = helpers.try(async (req, res, next) => {
}); });
middleware.checkRequired = function (fields, req, res, next) { middleware.checkRequired = function (fields, req, res, next) {
const body = req.body || {};
const query = req.query || {};
// Used in API calls to ensure that necessary parameters/data values are present // Used in API calls to ensure that necessary parameters/data values are present
const missing = fields.filter( const missing = fields.filter(
field => req.body && !req.body.hasOwnProperty(field) && !req.query.hasOwnProperty(field) field => !body.hasOwnProperty(field) && !query.hasOwnProperty(field)
); );
if (!missing.length) { if (!missing.length) {
return next(); return next();
} }
controllers.helpers.formatApiResponse(400, res, new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`)); controllers.helpers.formatApiResponse(
400,
res,
new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`)
);
}; };