From 2428602f27ff22ead97fee0c1166b371f955ece5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Tue, 3 Mar 2026 11:33:52 -0500 Subject: [PATCH] fix: logic in checkRequired if req.body was undefined req.query wasn't checked --- src/middleware/index.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/middleware/index.js b/src/middleware/index.js index aa4c456c91..568e0c0aa6 100644 --- a/src/middleware/index.js +++ b/src/middleware/index.js @@ -308,14 +308,20 @@ middleware.validateAuth = helpers.try(async (req, res, next) => { }); middleware.checkRequired = function (fields, req, res, next) { + const body = req.body || {}; + const query = req.query || {}; // Used in API calls to ensure that necessary parameters/data values are present const missing = fields.filter( - field => req.body && !req.body.hasOwnProperty(field) && !req.query.hasOwnProperty(field) + field => !body.hasOwnProperty(field) && !query.hasOwnProperty(field) ); if (!missing.length) { return next(); } - controllers.helpers.formatApiResponse(400, res, new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`)); + controllers.helpers.formatApiResponse( + 400, + res, + new Error(`[[error:required-parameters-missing, ${missing.join(' ')}]]`) + ); };