fix: #11037, update eslint-nodebb-config

.eslintignore

@@ -18,12 +18,3 @@ logs/
 .eslintrc
 test/files
 *.min.js
-
-/public/src/app.js
-/public/src/client.js
-/public/src/admin/admin.js
-/public/src/modules/translator.common.js
-/public/src/modules/pictureCropper.js
-/public/src/modules/ace-editor.js
-/public/src/client/account/header.js
-/public/src/client/test.js

install/package.json

@@ -154,7 +154,7 @@
         "@commitlint/config-angular": "17.2.0",
         "coveralls": "3.1.1",
         "eslint": "8.27.0",
-        "eslint-config-nodebb": "0.1.1",
+        "eslint-config-nodebb": "0.2.1",
         "eslint-plugin-import": "2.26.0",
         "grunt": "1.5.3",
         "grunt-contrib-watch": "1.1.0",

public/src/admin/admin.js

@@ -2,9 +2,9 @@
 
 require('../app');
 
-// scripts-admin.js contains javascript files
+// scripts-admin.js is generated during build, it contains javascript files
 // from plugins that add files to "acpScripts" block in plugin.json
-// eslint-disable-next-line import/no-unresolved
+// eslint-disable-next-line
 require('../../scripts-admin');
 
 app.onDomReady();

public/src/app.js

@@ -10,6 +10,7 @@ window.utils = require('./utils');
 require('timeago');
 
 const Benchpress = require('benchpressjs');
+
 Benchpress.setGlobal('config', config);
 
 require('./sockets');
@@ -21,7 +22,7 @@ app = window.app || {};
 Object.defineProperty(app, 'isFocused', {
 	get() {
 		return document.visibilityState === 'visible';
-	}
+	},
 });
 app.currentRoom = null;
 app.widgets = {};
@@ -148,7 +149,7 @@ if (document.readyState === 'loading') {
 		}
 		const result = await Promise.all(modules.map(requireModule));
 		return single ? result.pop() : result;
-	}
+	};
 
 	app.enterRoom = function (room, callback) {
 		callback = callback || function () { };
@@ -260,7 +261,7 @@ if (document.readyState === 'loading') {
 			translator.translate('[[global:' + status + ']]', function (translated) {
 				el.removeClass('online offline dnd away')
 					.addClass(status)
-					.attr('data-new-title', translated)
+					.attr('data-new-title', translated);
 			});
 		});
 	};

public/src/client.js

@@ -2,9 +2,9 @@
 
 require('./app');
 
-// scripts-client.js contains javascript files
+// scripts-client.js is generated during build, it contains javascript files
 // from plugins that add files to "scripts" block in plugin.json
-// eslint-disable-next-line import/no-unresolved
+// eslint-disable-next-line
 require('../scripts-client');
 
 app.onDomReady();

public/src/client/account/header.js

@@ -11,7 +11,8 @@ define('forum/account/header', [
 	'api',
 	'bootbox',
 	'alerts',
-], function (coverPhoto, pictureCropper, components, translator, AccountsDelete, AccountsModerate, api, bootbox, alerts) {
+], function (coverPhoto, pictureCropper, components, translator,
+	AccountsDelete, AccountsModerate, api, bootbox, alerts) {
 	const AccountHeader = {};
 	let isAdminOrSelfOrGlobalMod;
 

public/src/modules/ace-editor.js

@@ -1,3 +1,5 @@
+/* eslint-disable import/first */
+
 export * from 'ace-builds';
 
 // only import the modes and theme we use