Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-02-26 08:31:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

filterpidsbycid tests

Browse Source
This commit is contained in:
Baris Usakli
2017-05-11 17:16:22 -04:00
parent 816809ce3c
commit 0f05ae4ac1
2 changed files with 54 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/posts/category.js
View File

@@ -54,31 +54,36 @@ module.exports = function (Posts) {
Posts.filterPidsByCid = function (pids, cid, callback) {
if (!cid) {
return callback(null, pids);
return setImmediate(callback, null, pids);
}
if (!Array.isArray(cid) || cid.length === 1) {
// Single cid
db.isSortedSetMembers('cid:' + parseInt(cid, 10) + ':pids', pids, function (err, isMembers) {
if (err) {
return callback(err);
}
return filterPidsBySingleCid(pids, cid, callback);
}
async.waterfall([
function (next) {
async.map(cid, function (cid, next) {
Posts.filterPidsByCid(pids, cid, next);
}, next);
},
function (pidsArr, next) {
next(null, _.union.apply(_, pidsArr));
},
], callback);
};
function filterPidsBySingleCid(pids, cid, callback) {
async.waterfall([
function (next) {
db.isSortedSetMembers('cid:' + parseInt(cid, 10) + ':pids', pids, next);
},
function (isMembers, next) {
pids = pids.filter(function (pid, index) {
return pid && isMembers[index];
});
callback(null, pids);
});
} else {
// Multiple cids
async.map(cid, function (cid, next) {
Posts.filterPidsByCid(pids, cid, next);
}, function (err, pidsArr) {
if (err) {
return callback(err);
}
callback(null, _.union.apply(_, pidsArr));
});
}
};
next(null, pids);
},
], callback);
}
};

28
test/posts.js
View File

@@ -714,6 +714,34 @@ describe('Post\'s', function () {
});
});
describe('filterPidsByCid', function () {
it('should return pids as is if cid is falsy', function (done) {
posts.filterPidsByCid([1, 2, 3], null, function (err, pids) {
assert.ifError(err);
assert.deepEqual([1, 2, 3], pids);
done();
});
});
it('should filter pids by single cid', function (done) {
posts.filterPidsByCid([postData.pid, 100, 101], cid, function (err, pids) {
assert.ifError(err);
assert.deepEqual([postData.pid], pids);
done();
});
});
it('should filter pids by multiple cids', function (done) {
posts.filterPidsByCid([postData.pid, 100, 101], [cid, 2, 3], function (err, pids) {
assert.ifError(err);
assert.deepEqual([postData.pid], pids);
done();
});
});
});
after(function (done) {
db.emptydb(done);
});