Nemcio/Gogs
1
0
Fork 0
mirror of https://github.com/gogs/gogs.git synced 2026-07-20 00:42:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

js: use safe DOM construction for milestone and assignee selection (#8178)

Browse Source 
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
ᴊᴏᴇ ᴄʜᴇɴ
2026-02-13 23:24:52 -05:00
committed by GitHub
parent 295bfba729
commit 9001a68cdd
2 changed files with 12 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -7,6 +7,7 @@ All notable changes to Gogs are documented in this file.
### Fixed
- _Security:_ Cross-repository LFS object overwrite via missing content hash verification. [#8166](https://github.com/gogs/gogs/pull/8166) - [GHSA-gmf8-978x-2fg2](https://github.com/gogs/gogs/security/advisories/GHSA-gmf8-978x-2fg2)
- _Security:_ DOM-based XSS via issue meta selection on the issue page. [#8178](https://github.com/gogs/gogs/pull/8178) - [GHSA-vgjm-2cpf-4g7c](https://github.com/gogs/gogs/security/advisories/GHSA-vgjm-2cpf-4g7c)
### Removed

32
public/js/gogs.js
View File

@@ -240,29 +240,19 @@ function initCommentForm() {
}
switch (input_id) {
case "#milestone_id":
$list
.find(".selected")
.html(
'<a class="item" href=' +
$(this).data("href") +
">" +
$(this).text() +
"</a>"
);
var $milestoneAnchor = $('<a class="item"></a>');
$milestoneAnchor.attr("href", $(this).data("href"));
$milestoneAnchor.text($(this).text());
$list.find(".selected").empty().append($milestoneAnchor);
break;
case "#assignee_id":
$list
.find(".selected")
.html(
'<a class="item" href=' +
$(this).data("href") +
">" +
'<img class="ui avatar image" src=' +
$(this).data("avatar") +
">" +
$(this).text() +
"</a>"
);
var $assigneeAnchor = $('<a class="item"></a>');
$assigneeAnchor.attr("href", $(this).data("href"));
$assigneeAnchor.append(
$('<img class="ui avatar image">').attr("src", $(this).data("avatar"))
);
$assigneeAnchor.append($("<span></span>").text($(this).text()));
$list.find(".selected").empty().append($assigneeAnchor);
}
$(".ui" + select_id + ".list .no-select").addClass("hide");
$(input_id).val($(this).data("id"));