mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-30 18:36:22 +01:00 
			
		
		
		
	Fix #35649 * Use upstream `git-lfs-transfer` * The Close should be called when error occurs (bug fix) * The connection pool should be shared (bug fix) * Add more tests to cover "LFS over SSH download"
		
			
				
	
	
		
			82 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2024 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"net/url"
 | |
| 	"os"
 | |
| 	"path/filepath"
 | |
| 	"slices"
 | |
| 	"strings"
 | |
| 	"sync"
 | |
| 	"testing"
 | |
| 
 | |
| 	auth_model "code.gitea.io/gitea/models/auth"
 | |
| 	"code.gitea.io/gitea/modules/git/gitcmd"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 	"code.gitea.io/gitea/routers/common"
 | |
| 	"code.gitea.io/gitea/services/context"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| 	"github.com/stretchr/testify/require"
 | |
| )
 | |
| 
 | |
| func TestGitLFSSSH(t *testing.T) {
 | |
| 	onGiteaRun(t, func(t *testing.T, u *url.URL) {
 | |
| 		localRepoForUpload := filepath.Join(t.TempDir(), "test-upload")
 | |
| 		localRepoForDownload := filepath.Join(t.TempDir(), "test-download")
 | |
| 		apiTestContext := NewAPITestContext(t, "user2", "repo1", auth_model.AccessTokenScopeWriteRepository, auth_model.AccessTokenScopeWriteUser)
 | |
| 
 | |
| 		var mu sync.Mutex
 | |
| 		var routerCalls []string
 | |
| 		web.RouteMock(common.RouterMockPointCommonLFS, func(ctx *context.Base) {
 | |
| 			mu.Lock()
 | |
| 			routerCalls = append(routerCalls, ctx.Req.Method+" "+ctx.Req.URL.Path)
 | |
| 			mu.Unlock()
 | |
| 		})
 | |
| 
 | |
| 		withKeyFile(t, "my-testing-key", func(keyFile string) {
 | |
| 			t.Run("CreateUserKey", doAPICreateUserKey(apiTestContext, "test-key", keyFile))
 | |
| 			cloneURL := createSSHUrl(apiTestContext.GitPath(), u)
 | |
| 			t.Run("CloneOrigin", doGitClone(localRepoForUpload, cloneURL))
 | |
| 
 | |
| 			cfg, err := setting.CfgProvider.PrepareSaving()
 | |
| 			require.NoError(t, err)
 | |
| 			cfg.Section("server").Key("LFS_ALLOW_PURE_SSH").SetValue("true")
 | |
| 			setting.LFS.AllowPureSSH = true
 | |
| 			require.NoError(t, cfg.Save())
 | |
| 
 | |
| 			_, _, cmdErr := gitcmd.NewCommand("config", "lfs.sshtransfer", "always").
 | |
| 				WithDir(localRepoForUpload).
 | |
| 				RunStdString(t.Context())
 | |
| 			assert.NoError(t, cmdErr)
 | |
| 			pushedFiles := lfsCommitAndPushTest(t, localRepoForUpload, 10)
 | |
| 
 | |
| 			t.Run("CloneLFS", doGitClone(localRepoForDownload, cloneURL))
 | |
| 			content, err := os.ReadFile(filepath.Join(localRepoForDownload, pushedFiles[0]))
 | |
| 			assert.NoError(t, err)
 | |
| 			assert.Len(t, content, 10)
 | |
| 		})
 | |
| 
 | |
| 		countBatch := slices.ContainsFunc(routerCalls, func(s string) bool {
 | |
| 			return strings.Contains(s, "POST /api/internal/repo/user2/repo1.git/info/lfs/objects/batch")
 | |
| 		})
 | |
| 		countUpload := slices.ContainsFunc(routerCalls, func(s string) bool {
 | |
| 			return strings.Contains(s, "PUT /api/internal/repo/user2/repo1.git/info/lfs/objects/")
 | |
| 		})
 | |
| 		countDownload := slices.ContainsFunc(routerCalls, func(s string) bool {
 | |
| 			return strings.Contains(s, "GET /api/internal/repo/user2/repo1.git/info/lfs/objects/")
 | |
| 		})
 | |
| 		nonAPIRequests := slices.ContainsFunc(routerCalls, func(s string) bool {
 | |
| 			fields := strings.Fields(s)
 | |
| 			return !strings.HasPrefix(fields[1], "/api/")
 | |
| 		})
 | |
| 		assert.NotZero(t, countBatch)
 | |
| 		assert.NotZero(t, countUpload)
 | |
| 		assert.NotZero(t, countDownload)
 | |
| 		assert.Zero(t, nonAPIRequests)
 | |
| 	})
 | |
| }
 |