Release 4.21.2

fix #1861

CHANGELOG.md

@@ -1,8 +1,20 @@
 # Changelog
 All changes to the project will be documented in this file.
 
-## 4.20.0 - 23 Dec 2017
+### 4.21.2 - 27 Jan 2019
+- Bugfix
 
+### 4.21.1 - 27 Jan 2019
+- Bugfix
+
+### 4.21.0 - 27 Jan 2018
+- Release page
+- OpenID Connect support
+- New database viewer
+- Submodule links to web page
+- Clarify close/reopen button
+
+## 4.20.0 - 23 Dec 2017
 - Squash and rebase merge strategy for pull requests
 - Quick pull request creation
 - Download patch from the diff view
@@ -13,17 +25,14 @@ All changes to the project will be documented in this file.
 - Display conflicting files if pull request can't be merged
 
 ## 4.19.3 - 7 Dec 2017
-
 - Fix file uploading bug
 - Fix reply comment form behavior in the diff view
 
 ## 4.19.2 - 3 Dec 2017
-
 - Fix routing bug in `CompositeScalatraFilter`
 - Resolve id attribute collision in the web hook editing form
 
 ## 4.19.1 - 2 Dec 2017
-
 - Update gitbucket-notifications-plugin because it had a version compatibility issue
 
 ## 4.19.0 - 2 Dec 2017

README.md

@@ -68,18 +68,20 @@ Support
 - If you can't find same question and report, send it to [gitter room](https://gitter.im/gitbucket/gitbucket) before raising an issue.
 - The highest priority of GitBucket is the ease of installation and API compatibility with GitHub, so your feature request might be rejected if they go against those principles.
 
-What's New in 4.20.x
+What's New in 4.21.x
 -------------
 
-### 4.20.0 - 23 Dec 2017
+### 4.21.2 - 27 Jan 2019
+- Bugfix
 
-- Squash and rebase merge strategy for pull requests
-- Quick pull request creation
-- Download patch from the diff view
-- Fork and create repository are proceeded asynchronously
-- Create new repository by copying existing git repository
-- Hide overflowed repository names in the sidebar
-- Support CreateEvent web hook
-- Display conflicting files if pull request can't be merged
+### 4.21.1 - 27 Jan 2019
+- Bugfix
+
+### 4.21.0 - 27 Jan 2018
+- Release page
+- OpenID Connect support
+- New database viewer
+- Submodule links to web page
+- Clarify close/reopen button
 
 See the [change log](CHANGELOG.md) for all of the updates.

build.sbt

@@ -1,9 +1,9 @@
-import com.typesafe.sbt.license.{LicenseInfo, DepModuleInfo}
+import com.typesafe.sbt.license.{DepModuleInfo, LicenseInfo}
 import com.typesafe.sbt.pgp.PgpKeys._
 
 val Organization = "io.github.gitbucket"
 val Name = "gitbucket"
-val GitBucketVersion = "4.20.0"
+val GitBucketVersion = "4.21.2"
 val ScalatraVersion = "2.6.1"
 val JettyVersion = "9.4.7.v20170914"
 
@@ -26,43 +26,45 @@ resolvers ++= Seq(
   "amateras-snapshot" at "http://amateras.sourceforge.jp/mvn-snapshot/"
 )
 libraryDependencies ++= Seq(
-  "org.eclipse.jgit"                %  "org.eclipse.jgit.http.server" % "4.9.1.201712030800-r",
-  "org.eclipse.jgit"                %  "org.eclipse.jgit.archive"     % "4.9.1.201712030800-r",
+  "org.eclipse.jgit"                %  "org.eclipse.jgit.http.server" % "4.9.2.201712150930-r",
+  "org.eclipse.jgit"                %  "org.eclipse.jgit.archive"     % "4.9.2.201712150930-r",
   "org.scalatra"                    %% "scalatra"                     % ScalatraVersion,
   "org.scalatra"                    %% "scalatra-json"                % ScalatraVersion,
   "org.scalatra"                    %% "scalatra-forms"               % ScalatraVersion,
-  "org.json4s"                      %% "json4s-jackson"               % "3.5.1",
-  "commons-io"                      %  "commons-io"                   % "2.5",
+  "org.json4s"                      %% "json4s-jackson"               % "3.5.3",
+  "commons-io"                      %  "commons-io"                   % "2.6",
   "io.github.gitbucket"             %  "solidbase"                    % "1.0.2",
   "io.github.gitbucket"             %  "markedj"                      % "1.0.15",
-  "org.apache.commons"              %  "commons-compress"             % "1.13",
-  "org.apache.commons"              %  "commons-email"                % "1.4",
-  "org.apache.httpcomponents"       %  "httpclient"                   % "4.5.3",
-  "org.apache.sshd"                 %  "apache-sshd"                  % "1.4.0" exclude("org.slf4j","slf4j-jdk14"),
-  "org.apache.tika"                 %  "tika-core"                    % "1.14",
+  "org.apache.commons"              %  "commons-compress"             % "1.15",
+  "org.apache.commons"              %  "commons-email"                % "1.5",
+  "org.apache.httpcomponents"       %  "httpclient"                   % "4.5.4",
+  "org.apache.sshd"                 %  "apache-sshd"                  % "1.6.0" exclude("org.slf4j","slf4j-jdk14"),
+  "org.apache.tika"                 %  "tika-core"                    % "1.17",
   "com.github.takezoe"              %% "blocking-slick-32"            % "0.0.10",
   "com.novell.ldap"                 %  "jldap"                        % "2009-10-07",
-  "com.h2database"                  %  "h2"                           % "1.4.195",
-  "org.mariadb.jdbc"                %  "mariadb-java-client"          % "2.2.0",
-  "org.postgresql"                  %  "postgresql"                   % "42.0.0",
+  "com.h2database"                  %  "h2"                           % "1.4.196",
+  "org.mariadb.jdbc"                %  "mariadb-java-client"          % "2.2.1",
+  "org.postgresql"                  %  "postgresql"                   % "42.1.4",
   "ch.qos.logback"                  %  "logback-classic"              % "1.2.3",
-  "com.zaxxer"                      %  "HikariCP"                     % "2.6.1",
-  "com.typesafe"                    %  "config"                       % "1.3.1",
-  "com.typesafe.akka"               %% "akka-actor"                   % "2.5.0",
+  "com.zaxxer"                      %  "HikariCP"                     % "2.7.4",
+  "com.typesafe"                    %  "config"                       % "1.3.2",
+  "com.typesafe.akka"               %% "akka-actor"                   % "2.5.8",
   "fr.brouillard.oss.security.xhub" %  "xhub4j-core"                  % "1.0.0",
   "com.github.bkromhout"            %  "java-diff-utils"              % "2.1.1",
-  "org.cache2k"                     %  "cache2k-all"                  % "1.0.0.CR1",
-  "com.enragedginger"               %% "akka-quartz-scheduler"        % "1.6.0-akka-2.4.x" exclude("c3p0","c3p0"),
+  "org.cache2k"                     %  "cache2k-all"                  % "1.0.1.Final",
+  "com.enragedginger"               %% "akka-quartz-scheduler"        % "1.6.1-akka-2.5.x" exclude("c3p0","c3p0"),
   "net.coobird"                     %  "thumbnailator"                % "0.4.8",
   "com.github.zafarkhaja"           %  "java-semver"                  % "0.9.0",
+  "com.nimbusds"                    %  "oauth2-oidc-sdk"              % "5.45",
   "org.eclipse.jetty"               %  "jetty-webapp"                 % JettyVersion     % "provided",
   "javax.servlet"                   %  "javax.servlet-api"            % "3.1.0"          % "provided",
   "junit"                           %  "junit"                        % "4.12"           % "test",
   "org.scalatra"                    %% "scalatra-scalatest"           % ScalatraVersion  % "test",
-  "org.mockito"                     %  "mockito-core"                 % "2.7.22"         % "test",
-  "com.wix"                         %  "wix-embedded-mysql"           % "2.1.4"          % "test",
-  "ru.yandex.qatools.embed"         %  "postgresql-embedded"          % "2.0"            % "test",
-  "net.i2p.crypto"                  % "eddsa"                         % "0.1.0"
+  "org.mockito"                     %  "mockito-core"                 % "2.13.0"         % "test",
+  "com.wix"                         %  "wix-embedded-mysql"           % "3.0.0"          % "test",
+  "ru.yandex.qatools.embed"         %  "postgresql-embedded"          % "2.6"            % "test",
+  "net.i2p.crypto"                  % "eddsa"                         % "0.2.0",
+  "is.tagomor.woothee"              % "woothee-java"                  % "1.7.0"
 )
 
 // Compiler settings
@@ -96,7 +98,13 @@ assemblyMergeStrategy in assembly := {
 //jrebel.webLinks += (target in webappPrepare).value
 //jrebel.enabled := System.getenv().get("JREBEL") != null
 javaOptions in Jetty ++= Option(System.getenv().get("JREBEL")).toSeq.flatMap { path =>
- Seq("-noverify", "-XX:+UseConcMarkSweepGC", "-XX:+CMSClassUnloadingEnabled", s"-javaagent:${path}")
+  if (path.endsWith(".jar")) {
+    // Legacy JRebel agent
+    Seq("-noverify", "-XX:+UseConcMarkSweepGC", "-XX:+CMSClassUnloadingEnabled", s"-javaagent:${path}")
+  } else {
+    // New JRebel agent
+    Seq(s"-agentpath:${path}")
+  }
 }
 
 // Exclude a war file from published artifacts
@@ -121,8 +129,8 @@ libraryDependencies ++= Seq(
 
 val executableKey = TaskKey[File]("executable")
 executableKey := {
-  import java.util.jar.{ Manifest => JarManifest }
-  import java.util.jar.Attributes.{ Name => AttrName }
+  import java.util.jar.Attributes.{Name => AttrName}
+  import java.util.jar.{Manifest => JarManifest}
 
   val workDir   = Keys.target.value / "executable"
   val warName   = Keys.name.value + ".war"

contrib/linux/redhat/selinux/gitbucket.te

@@ -0,0 +1,21 @@
+module gitbucket 1.0;
+
+require {
+	type smtp_port_t;
+	type tomcat_t;
+	type tomcat_var_lib_t;
+	type unreserved_port_t;
+
+	class file { execute };
+	class tcp_socket { name_bind };
+	class tcp_socket { name_connect };
+}
+
+# allow tomcat to send emails
+allow tomcat_t smtp_port_t:tcp_socket { name_connect };
+
+# allow file executes, required during repo creation
+allow tomcat_t tomcat_var_lib_t:file { execute };
+
+# allow tomcat to serve repositories via SSH
+allow tomcat_t unreserved_port_t:tcp_socket { name_bind };

contrib/linux/redhat/selinux/readme.md

@@ -0,0 +1,32 @@
+# Red Hat Enterprise Linux / CentOS SELinux policy module for GitBucket
+
+One way to run GitBucket on Enterprise Linux is under Tomcat. Since EL 7.4, Tomcat is no longer unconfined.
+Thus since 7.4, Enterprise Linux blocks certain operations that are required for GitBucket to work properly:
+
+* Tomcat is not allowed to connect to SMTP ports, which is required to send email notifications.
+* Tomcat is not allowed to execute files, which is required for creating repositories.
+* Tomcat is not allowed to act as a server on unreserved ports, which is required for serving repositories via SSH.
+
+To mitigate this, you can use the SELinux policy module provided as `gitbucket.te`. You can deploy the module with the
+attached script, e.g.:
+
+~~~
+./sedeploy.sh gitbucket
+~~~
+
+You most likely also need to fix file contexts on your system. Assuming a new, default Tomcat installation on 7.4, you
+can do so by issuing the following commands:
+
+~~~
+GITBUCKET_HOME='/usr/share/tomcat/.gitbucket'
+mkdir -p ${GITBUCKET_HOME}
+chown tomcat.tomcat ${GITBUCKET_HOME}
+semanage fcontext -a -t tomcat_var_lib_t "${GITBUCKET_HOME}(/.*)?"
+restorecon -rv ${GITBUCKET_HOME}
+
+JAVA_CONF='/usr/share/tomcat/.java'
+mkdir -p ${JAVA_CONF}
+chown tomcat.tomcat ${JAVA_CONF}
+semanage fcontext -a -t tomcat_cache_t "${JAVA_CONF}(/.*)?"
+restorecon -rv ${JAVA_CONF}
+~~~

contrib/linux/redhat/selinux/sedeploy.sh

@@ -0,0 +1,14 @@
+#!/bin/sh
+
+set -e
+
+MODULE=${1}
+
+# this will create a .mod file
+checkmodule -M -m -o ${MODULE}.mod ${MODULE}.te
+
+# this will create a compiled semodule
+semodule_package -m ${MODULE}.mod -o ${MODULE}.pp
+
+# this will install the module
+semodule -i ${MODULE}.pp

doc/jrebel.md

@@ -28,17 +28,16 @@ You don't need to integrate with your IDE, since we're using sbt to do the servl
 Fortunately, the gitbucket project is already set up to use JRebel.
 You only need to tell jvm where to find the jrebel jar.
 
-To do so, edit your shell resource file (usually `~/.bash_profile` on Mac, and `~/.bashrc` on Linux), and add the following line:
+To do so, edit your shell resource file (usually `~/.bash_profile` on Mac, and `~/.bashrc` on Linux) and set the environment variable `JREBEL`.
+For example, if you unzipped your JRebel download in your home directory, you would use:
 
 ```bash
-export JREBEL=/path/to/jrebel/legacy/jrebel.jar
+export JREBEL=~/jrebel/legacy/jrebel.jar      # legacy agent
+export JREBEL=~/jrebel/lib/libjrebel64.dylib  # new agent
 ```
 
-For example, if you unzipped your JRebel download in your home directory, you whould use:
-
-```bash
-export JREBEL=~/jrebel/legacy/jrebel.jar
-```
+You can choose the legacy JRebel agent or the new one.
+See [the document](https://zeroturnaround.com/software/jrebel/jrebel7-agent-upgrade-cli/) for details.
 
 Now reload your shell:
 

plugins.json

@@ -31,9 +31,9 @@
     "description": "Provides Gist feature on GitBucket.",
     "versions": [
       {
-        "version": "4.11.0",
-        "range": ">=4.19.0",
-        "url": "https://github.com/gitbucket/gitbucket-gist-plugin/releases/download/4.11.0/gitbucket-gist-plugin-assembly-4.11.0.jar"
+        "version": "4.12.0",
+        "range": ">=4.21.0",
+        "url": "https://github.com/gitbucket/gitbucket-gist-plugin/releases/download/4.12.0/gitbucket-gist-plugin-assembly-4.12.0.jar"
       }
     ],
     "default": false

project/build.properties

@@ -1 +1 @@
-sbt.version=1.0.4
+sbt.version=1.1.0

project/plugins.sbt

@@ -1,10 +1,10 @@
 scalacOptions ++= Seq("-unchecked", "-deprecation", "-feature")
 
-addSbtPlugin("com.typesafe.sbt"     % "sbt-twirl"         % "1.3.12")
+addSbtPlugin("com.typesafe.sbt"     % "sbt-twirl"         % "1.3.13")
 addSbtPlugin("com.eed3si9n"         % "sbt-assembly"      % "0.14.5")
 //addSbtPlugin("com.earldouglas"      % "xsbt-web-plugin"   % "4.0.0")
 //addSbtPlugin("fi.gekkio.sbtplugins" % "sbt-jrebel-plugin" % "0.10.0")
 addSbtPlugin("org.scalatra.sbt"     % "sbt-scalatra"      % "1.0.1")
 addSbtPlugin("com.jsuereth"         % "sbt-pgp"           % "1.1.0")
-addSbtPlugin("io.get-coursier"      % "sbt-coursier"      % "1.0.0-RC13")
+addSbtCoursier
 addSbtPlugin("com.typesafe.sbt"     % "sbt-license-report" % "1.2.0")

project/project/plugins.sbt

@@ -1 +1 @@
-addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0-RC11")
+addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0")

src/main/resources/update/gitbucket-core_4.21.xml

@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<changeSet>
+  <createTable tableName="RELEASE">
+    <column name="USER_NAME" type="varchar(100)" nullable="false"/>
+    <column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
+    <column name="TAG" type="varchar(100)" nullable="false"/>
+    <column name="NAME" type="varchar(100)" nullable="false"/>
+    <column name="AUTHOR" type="varchar(100)" nullable="false"/>
+    <column name="CONTENT" type="text" nullable="true"/>
+    <column name="REGISTERED_DATE" type="datetime" nullable="false"/>
+    <column name="UPDATED_DATE" type="datetime" nullable="false"/>
+  </createTable>
+
+  <addPrimaryKey constraintName="IDX_RELEASE_PK" tableName="RELEASE" columnNames="USER_NAME, REPOSITORY_NAME, TAG"/>
+  <addForeignKeyConstraint constraintName="IDX_RELEASE_FK0" baseTableName="RELEASE" baseColumnNames="USER_NAME, REPOSITORY_NAME" referencedTableName="REPOSITORY" referencedColumnNames="USER_NAME, REPOSITORY_NAME"/>
+
+  <createTable tableName="RELEASE_ASSET">
+    <column name="USER_NAME" type="varchar(100)" nullable="false"/>
+    <column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
+    <column name="TAG" type="varchar(100)" nullable="false"/>
+    <column name="RELEASE_ASSET_ID" type="int" nullable="false" autoIncrement="true" unique="true"/>
+    <column name="FILE_NAME" type="varchar(260)" nullable="false"/>
+    <column name="LABEL" type="varchar(100)" nullable="true"/>
+    <column name="SIZE" type="bigint" nullable="false"/>
+    <column name="UPLOADER" type="varchar(100)" nullable="false"/>
+    <column name="REGISTERED_DATE" type="datetime" nullable="false"/>
+    <column name="UPDATED_DATE" type="datetime" nullable="false"/>
+  </createTable>
+  <addPrimaryKey constraintName="IDX_RELEASE_ASSET_PK" tableName="RELEASE_ASSET" columnNames="USER_NAME, REPOSITORY_NAME, TAG, FILE_NAME"/>
+  <addForeignKeyConstraint constraintName="IDX_RELEASE_ASSET_FK1" baseTableName="RELEASE_ASSET" baseColumnNames="USER_NAME, REPOSITORY_NAME, TAG" referencedTableName="RELEASE" referencedColumnNames="USER_NAME, REPOSITORY_NAME, TAG"/>
+
+  <createTable tableName="ACCOUNT_FEDERATION">
+    <column name="ISSUER" type="varchar(100)" nullable="false"/>
+    <column name="SUBJECT" type="varchar(100)" nullable="false"/>
+    <column name="USER_NAME" type="varchar(100)" nullable="false"/>
+  </createTable>
+  <addPrimaryKey constraintName="IDX_ACCOUNT_FEDERATION_PK" tableName="ACCOUNT_FEDERATION" columnNames="ISSUER, SUBJECT"/>
+  <addForeignKeyConstraint constraintName="IDX_ACCOUNT_FEDERATION_FK0" baseTableName="ACCOUNT_FEDERATION" baseColumnNames="USER_NAME" referencedTableName="ACCOUNT" referencedColumnNames="USER_NAME"/>
+</changeSet>

src/main/scala/ScalatraBootstrap.scala

@@ -2,7 +2,7 @@
 import java.util.EnumSet
 import javax.servlet._
 
-import gitbucket.core.controller._
+import gitbucket.core.controller.{ReleaseController, _}
 import gitbucket.core.plugin.PluginRegistry
 import gitbucket.core.service.SystemSettingsService
 import gitbucket.core.servlet._
@@ -47,6 +47,7 @@ class ScalatraBootstrap extends LifeCycle with SystemSettingsService {
     filter.mount(new MilestonesController, "/*")
     filter.mount(new IssuesController, "/*")
     filter.mount(new PullRequestsController, "/*")
+    filter.mount(new ReleaseController, "/*")
     filter.mount(new RepositorySettingsController, "/*")
 
     context.addFilter("compositeScalatraFilter", filter)

src/main/scala/gitbucket/core/GitBucketCoreModule.scala

@@ -48,5 +48,10 @@ object GitBucketCoreModule extends Module("gitbucket-core",
   new Version("4.19.1"),
   new Version("4.19.2"),
   new Version("4.19.3"),
-  new Version("4.20.0")
+  new Version("4.20.0"),
+  new Version("4.21.0",
+    new LiquibaseMigration("update/gitbucket-core_4.21.xml")
+  ),
+  new Version("4.21.1"),
+  new Version("4.21.2")
 )

src/main/scala/gitbucket/core/api/ApiPullRequest.scala

@@ -8,6 +8,7 @@ import java.util.Date
  */
 case class ApiPullRequest(
   number: Int,
+  state: String,
   updated_at: Date,
   created_at: Date,
   head: ApiPullRequest.Commit,
@@ -44,6 +45,7 @@ object ApiPullRequest{
   ): ApiPullRequest =
     ApiPullRequest(
       number     = issue.issueId,
+      state      = if (issue.closed) "closed" else "open",
       updated_at = issue.updatedDate,
       created_at = issue.registeredDate,
       head       = Commit(

src/main/scala/gitbucket/core/controller/ApiController.scala

@@ -203,13 +203,24 @@ trait ApiControllerBase extends ControllerBase {
   /*
    * https://developer.github.com/v3/git/refs/#get-a-reference
    */
-  get("/api/v3/repos/:owner/:repo/git/*") (referrersOnly { repository =>
+  get("/api/v3/repos/:owner/:repo/git/refs/*") (referrersOnly { repository =>
     val revstr = multiParams("splat").head
     using(Git.open(getRepositoryDir(params("owner"), params("repo")))) { git =>
-      //JsonFormat( (revstr, git.getRepository().resolve(revstr)) )
-      // getRef is deprecated by jgit-4.2. use exactRef() or findRef()
-      val sha = git.getRepository().exactRef(revstr).getObjectId().name()
-      JsonFormat(ApiRef(revstr, ApiObject(sha)))
+      val ref = git.getRepository().findRef(revstr)
+
+      if(ref != null){
+        val sha = ref.getObjectId().name()
+        JsonFormat(ApiRef(revstr, ApiObject(sha)))
+
+      } else {
+        val refs = git.getRepository().getAllRefs().asScala
+          .collect { case (str, ref) if str.startsWith("refs/" + revstr) => ref }
+
+        JsonFormat(refs.map { ref =>
+          val sha = ref.getObjectId().name()
+          ApiRef(revstr, ApiObject(sha))
+        })
+      }
     }
   })
 

src/main/scala/gitbucket/core/controller/ControllerBase.scala

@@ -4,7 +4,7 @@ import java.io.FileInputStream
 
 import gitbucket.core.api.ApiError
 import gitbucket.core.model.Account
-import gitbucket.core.service.{AccountService, SystemSettingsService,RepositoryService}
+import gitbucket.core.service.{AccountService, RepositoryService, SystemSettingsService}
 import gitbucket.core.util.SyntaxSugars._
 import gitbucket.core.util.Directory._
 import gitbucket.core.util.Implicits._
@@ -17,9 +17,10 @@ import org.scalatra.forms._
 import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
 import javax.servlet.{FilterChain, ServletRequest, ServletResponse}
 
+import is.tagomor.woothee.Classifier
+
 import scala.util.Try
 import net.coobird.thumbnailator.Thumbnails
-
 import org.eclipse.jgit.api.Git
 import org.eclipse.jgit.lib.ObjectId
 import org.eclipse.jgit.revwalk.RevCommit
@@ -43,25 +44,11 @@ abstract class ControllerBase extends ScalatraFilter
   }
 
   override def doFilter(request: ServletRequest, response: ServletResponse, chain: FilterChain): Unit = try {
-    val httpRequest  = request.asInstanceOf[HttpServletRequest]
-    val httpResponse = response.asInstanceOf[HttpServletResponse]
-    val context      = request.getServletContext.getContextPath
-    val path         = httpRequest.getRequestURI.substring(context.length)
+    val httpRequest = request.asInstanceOf[HttpServletRequest]
+    val context     = request.getServletContext.getContextPath
+    val path        = httpRequest.getRequestURI.substring(context.length)
 
-    if(path.startsWith("/console/")){
-      val account = httpRequest.getSession.getAttribute(Keys.Session.LoginAccount).asInstanceOf[Account]
-      val baseUrl = this.baseUrl(httpRequest)
-      if(account == null){
-        // Redirect to login form
-        httpResponse.sendRedirect(baseUrl + "/signin?redirect=" + StringUtil.urlEncode(path))
-      } else if(account.isAdmin){
-        // H2 Console (administrators only)
-        chain.doFilter(request, response)
-      } else {
-        // Redirect to dashboard
-        httpResponse.sendRedirect(baseUrl + "/")
-      }
-    } else if(path.startsWith("/git/") || path.startsWith("/git-lfs/")){
+    if(path.startsWith("/git/") || path.startsWith("/git-lfs/")){
       // Git repository
       chain.doFilter(request, response)
     } else {
@@ -127,12 +114,24 @@ abstract class ControllerBase extends ScalatraFilter
       org.scalatra.NotFound(gitbucket.core.html.error("Not Found"))
     }
 
+  private def isBrowser(userAgent: String): Boolean = {
+    if(userAgent == null || userAgent.isEmpty){
+      false
+    } else {
+      val data = Classifier.parse(userAgent)
+      val category = data.get("category")
+      category == "pc" || category == "smartphone" || category == "mobilephone"
+    }
+  }
+
   protected def Unauthorized()(implicit context: Context) =
     if(request.hasAttribute(Keys.Request.Ajax)){
       org.scalatra.Unauthorized()
     } else if(request.hasAttribute(Keys.Request.APIv3)){
       contentType = formats("json")
       org.scalatra.Unauthorized(ApiError("Requires authentication"))
+    } else if(!isBrowser(request.getHeader("USER-AGENT"))){
+      org.scalatra.Unauthorized()
     } else {
       if(context.loginAccount.isDefined){
         org.scalatra.Unauthorized(redirect("/"))

src/main/scala/gitbucket/core/controller/FileUploadController.scala

@@ -1,7 +1,7 @@
 package gitbucket.core.controller
 
 import gitbucket.core.model.Account
-import gitbucket.core.service.{AccountService, RepositoryService}
+import gitbucket.core.service.{AccountService, RepositoryService, ReleaseService}
 import gitbucket.core.servlet.Database
 import gitbucket.core.util._
 import gitbucket.core.util.SyntaxSugars._
@@ -19,14 +19,13 @@ import org.apache.commons.io.{FileUtils, IOUtils}
  *
  * This servlet saves uploaded file.
  */
-class FileUploadController extends ScalatraServlet with FileUploadSupport with RepositoryService with AccountService {
+class FileUploadController extends ScalatraServlet
+  with FileUploadSupport
+  with RepositoryService
+  with AccountService
+  with ReleaseService{
 
-  val maxFileSize = if (System.getProperty("gitbucket.maxFileSize") != null)
-    System.getProperty("gitbucket.maxFileSize").toLong
-  else
-    3 * 1024 * 1024
-
-  configureMultipartHandling(MultipartConfig(maxFileSize = Some(maxFileSize)))
+  configureMultipartHandling(MultipartConfig(maxFileSize = Some(FileUtil.MaxFileSize)))
 
   post("/image"){
     execute({ (file, fileId) =>
@@ -89,6 +88,20 @@ class FileUploadController extends ScalatraServlet with FileUploadSupport with R
     } getOrElse BadRequest()
   }
 
+  post("/release/:owner/:repository/:tag"){
+    session.get(Keys.Session.LoginAccount).collect { case _: Account =>
+      val owner = params("owner")
+      val repository = params("repository")
+      val tag = params("tag")
+      execute({ (file, fileId) =>
+        FileUtils.writeByteArrayToFile(
+          new java.io.File(getReleaseFilesDir(owner, repository), tag + "/" + fileId),
+          file.get
+        )
+      }, _ => true)
+    }.getOrElse(BadRequest())
+  }
+
   post("/import") {
     import JDBCUtil._
     session.get(Keys.Session.LoginAccount).collect { case loginAccount: Account if loginAccount.isAdmin =>

src/main/scala/gitbucket/core/controller/IndexController.scala

@@ -1,23 +1,39 @@
 package gitbucket.core.controller
 
+import java.net.URI
+
+import com.nimbusds.oauth2.sdk.id.State
+import com.nimbusds.openid.connect.sdk.Nonce
 import gitbucket.core.helper.xml
 import gitbucket.core.model.Account
 import gitbucket.core.service._
 import gitbucket.core.util.Implicits._
 import gitbucket.core.util.SyntaxSugars._
 import gitbucket.core.util.{Keys, LDAPUtil, ReferrerAuthenticator, UsersAuthenticator}
-import org.scalatra.forms._
 import org.scalatra.Ok
+import org.scalatra.forms._
 
 
 class IndexController extends IndexControllerBase
-  with RepositoryService with ActivityService with AccountService with RepositorySearchService with IssuesService
-  with UsersAuthenticator with ReferrerAuthenticator
+  with RepositoryService
+  with ActivityService
+  with AccountService
+  with RepositorySearchService
+  with IssuesService
+  with UsersAuthenticator
+  with ReferrerAuthenticator
+  with AccountFederationService
+  with OpenIDConnectService
 
 
 trait IndexControllerBase extends ControllerBase {
-  self: RepositoryService with ActivityService with AccountService with RepositorySearchService
-    with UsersAuthenticator with ReferrerAuthenticator =>
+  self: RepositoryService
+    with ActivityService
+    with AccountService
+    with RepositorySearchService
+    with UsersAuthenticator
+    with ReferrerAuthenticator
+    with OpenIDConnectService =>
 
   case class SignInForm(userName: String, password: String, hash: Option[String])
 
@@ -35,6 +51,7 @@ trait IndexControllerBase extends ControllerBase {
 //
 //  case class SearchForm(query: String, owner: String, repository: String)
 
+  case class OidcContext(state: State, nonce: Nonce, redirectBackURI: String)
 
   get("/"){
     context.loginAccount.map { account =>
@@ -55,13 +72,59 @@ trait IndexControllerBase extends ControllerBase {
 
   post("/signin", signinForm){ form =>
     authenticate(context.settings, form.userName, form.password) match {
-      case Some(account) => signin(account, form.hash)
-      case None          => {
+      case Some(account) =>
+        flash.get(Keys.Flash.Redirect) match {
+          case Some(redirectUrl: String) => signin(account, redirectUrl + form.hash.getOrElse(""))
+          case _ => signin(account)
+        }
+      case None =>
         flash += "userName" -> form.userName
         flash += "password" -> form.password
         flash += "error" -> "Sorry, your Username and/or Password is incorrect. Please try again."
         redirect("/signin")
+    }
+  }
+
+  /**
+    * Initiate an OpenID Connect authentication request.
+    */
+  post("/signin/oidc") {
+    context.settings.oidc.map { oidc =>
+      val redirectURI = new URI(s"$baseUrl/signin/oidc")
+      val authenticationRequest = createOIDCAuthenticationRequest(oidc.issuer, oidc.clientID, redirectURI)
+      val redirectBackURI = flash.get(Keys.Flash.Redirect) match {
+        case Some(redirectBackURI: String) => redirectBackURI + params.getOrElse("hash", "")
+        case _ => "/"
       }
+      session.setAttribute(Keys.Session.OidcContext, OidcContext(authenticationRequest.getState, authenticationRequest.getNonce, redirectBackURI))
+      redirect(authenticationRequest.toURI.toString)
+    } getOrElse {
+      NotFound()
+    }
+  }
+
+  /**
+    * Handle an OpenID Connect authentication response.
+    */
+  get("/signin/oidc") {
+    context.settings.oidc.map { oidc =>
+      val redirectURI = new URI(s"$baseUrl/signin/oidc")
+      session.get(Keys.Session.OidcContext) match {
+        case Some(context: OidcContext) =>
+          authenticate(params, redirectURI, context.state, context.nonce, oidc) map { account =>
+            signin(account, context.redirectBackURI)
+          } orElse {
+            flash += "error" -> "Sorry, authentication failed. Please try again."
+            session.invalidate()
+            redirect("/signin")
+          }
+        case _ =>
+          flash += "error" -> "Sorry, something wrong. Please try again."
+          session.invalidate()
+          redirect("/signin")
+      }
+    } getOrElse {
+      NotFound()
     }
   }
 
@@ -85,9 +148,9 @@ trait IndexControllerBase extends ControllerBase {
   }
 
   /**
-   * Set account information into HttpSession and redirect.
-   */
-  private def signin(account: Account, hash: Option[String]) = {
+    * Set account information into HttpSession and redirect.
+    */
+  private def signin(account: Account, redirectUrl: String = "/") = {
     session.setAttribute(Keys.Session.LoginAccount, account)
     updateLastLoginDate(account.userName)
 
@@ -95,14 +158,10 @@ trait IndexControllerBase extends ControllerBase {
       redirect("/" + account.userName + "/_edit")
     }
 
-    flash.get(Keys.Flash.Redirect).asInstanceOf[Option[String]].map { redirectUrl =>
-      if(redirectUrl.stripSuffix("/") == request.getContextPath){
-        redirect("/")
-      } else {
-        redirect(redirectUrl + hash.getOrElse(""))
-      }
-    }.getOrElse {
+    if (redirectUrl.stripSuffix("/") == request.getContextPath) {
       redirect("/")
+    } else {
+      redirect(redirectUrl)
     }
   }
 

src/main/scala/gitbucket/core/controller/ReleasesController.scala

@@ -0,0 +1,151 @@
+package gitbucket.core.controller
+
+import java.io.File
+
+import gitbucket.core.service.{AccountService, ActivityService, ReleaseService, RepositoryService}
+import gitbucket.core.util.{FileUtil, ReadableUsersAuthenticator, ReferrerAuthenticator, WritableUsersAuthenticator}
+import gitbucket.core.util.Directory._
+import gitbucket.core.util.Implicits._
+import org.scalatra.forms._
+import gitbucket.core.releases.html
+import org.apache.commons.io.FileUtils
+import scala.collection.JavaConverters._
+
+class ReleaseController extends ReleaseControllerBase
+  with RepositoryService
+  with AccountService
+  with ReleaseService
+  with ActivityService
+  with ReadableUsersAuthenticator
+  with ReferrerAuthenticator
+  with WritableUsersAuthenticator
+
+trait ReleaseControllerBase extends ControllerBase {
+  self: RepositoryService
+    with AccountService
+    with ReleaseService
+    with ReadableUsersAuthenticator
+    with ReferrerAuthenticator
+    with WritableUsersAuthenticator
+    with ActivityService =>
+
+  case class ReleaseForm(
+    name: String,
+    content: Option[String]
+  )
+
+  val releaseForm = mapping(
+    "name"    -> trim(text(required)),
+    "content" -> trim(optional(text()))
+  )(ReleaseForm.apply)
+
+  get("/:owner/:repository/releases")(referrersOnly {repository =>
+    val releases = getReleases(repository.owner, repository.name)
+    val assets = getReleaseAssetsMap(repository.owner, repository.name)
+
+    html.list(
+      repository,
+      repository.tags.reverse.map { tag =>
+        (tag, releases.find(_.tag == tag.name).map { release => (release, assets(release)) })
+      },
+      hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
+  })
+
+  get("/:owner/:repository/releases/:tag")(referrersOnly { repository =>
+    val tag = params("tag")
+    getRelease(repository.owner, repository.name, tag).map { release =>
+      html.release(release, getReleaseAssets(repository.owner, repository.name, tag), hasDeveloperRole(repository.owner, repository.name, context.loginAccount), repository)
+    }.getOrElse(NotFound())
+  })
+
+  get("/:owner/:repository/releases/:tag/assets/:fileId")(referrersOnly {repository =>
+    val tag = params("tag")
+    val fileId = params("fileId")
+    (for {
+      _     <- repository.tags.find(_.name == tag)
+      _     <- getRelease(repository.owner, repository.name, tag)
+      asset <- getReleaseAsset(repository.owner, repository.name, tag, fileId)
+    } yield {
+      response.setHeader("Content-Disposition", s"attachment; filename=${asset.label}")
+      RawData(
+        FileUtil.getMimeType(asset.label),
+        new File(getReleaseFilesDir(repository.owner, repository.name), tag + "/" + fileId)
+      )
+    }).getOrElse(NotFound())
+  })
+
+  get("/:owner/:repository/releases/:tag/create")(writableUsersOnly {repository =>
+    html.form(repository, params("tag"), None)
+  })
+
+  post("/:owner/:repository/releases/:tag/create", releaseForm)(writableUsersOnly { (form, repository) =>
+    val tag = params("tag")
+    val loginAccount = context.loginAccount.get
+
+    // Insert into RELEASE
+    createRelease(repository.owner, repository.name, form.name, form.content, tag, loginAccount)
+
+    // Insert into RELEASE_ASSET
+    request.getParameterNames.asScala.filter(_.startsWith("file:")).foreach { paramName =>
+      val Array(_, fileId) = paramName.split(":")
+      val fileName = params(paramName)
+      val size = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), tag + "/" + fileId).length
+
+      createReleaseAsset(repository.owner, repository.name, tag, fileId, fileName, size, loginAccount)
+    }
+
+    recordReleaseActivity(repository.owner, repository.name, loginAccount.userName, form.name)
+
+    redirect(s"/${repository.owner}/${repository.name}/releases/${tag}")
+  })
+
+  get("/:owner/:repository/releases/:tag/edit")(writableUsersOnly {repository =>
+    val tag = params("tag")
+
+    getRelease(repository.owner, repository.name, tag).map { release =>
+      html.form(repository, release.tag, Some(release, getReleaseAssets(repository.owner, repository.name, tag)))
+    }.getOrElse(NotFound())
+  })
+
+  post("/:owner/:repository/releases/:tag/edit", releaseForm)(writableUsersOnly { (form, repository) =>
+    val tag = params("tag")
+    val loginAccount = context.loginAccount.get
+
+    getRelease(repository.owner, repository.name, tag).map { release =>
+      // Update RELEASE
+      updateRelease(repository.owner, repository.name, tag, form.name, form.content)
+
+      // Delete and Insert RELEASE_ASSET
+      val assets = getReleaseAssets(repository.owner, repository.name, tag)
+      deleteReleaseAssets(repository.owner, repository.name, tag)
+
+      val fileIds = request.getParameterNames.asScala.filter(_.startsWith("file:")).map { paramName =>
+        val Array(_, fileId) = paramName.split(":")
+        val fileName = params(paramName)
+        val size = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), release.tag + "/" + fileId).length
+
+        createReleaseAsset(repository.owner, repository.name, tag, fileId, fileName, size, loginAccount)
+        fileId
+      }
+
+      assets.foreach { asset =>
+        if(!fileIds.contains(asset.fileName)){
+          val file = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), release.tag + "/" + asset.fileName)
+          FileUtils.forceDelete(file)
+        }
+      }
+
+      redirect(s"/${release.userName}/${release.repositoryName}/releases/${tag}")
+    }.getOrElse(NotFound())
+  })
+
+  post("/:owner/:repository/releases/:tag/delete")(writableUsersOnly { repository =>
+    val tag = params("tag")
+    getRelease(repository.owner, repository.name, tag).foreach { release =>
+      FileUtils.deleteDirectory(new File(getReleaseFilesDir(repository.owner, repository.name), release.tag))
+    }
+    deleteRelease(repository.owner, repository.name, tag)
+    redirect(s"/${repository.owner}/${repository.name}/releases")
+  })
+
+}

src/main/scala/gitbucket/core/controller/RepositorySettingsController.scala

@@ -142,6 +142,9 @@ trait RepositorySettingsControllerBase extends ControllerBase {
           FileUtils.moveDirectory(dir, getRepositoryFilesDir(repository.owner, form.repositoryName))
         }
       }
+      // Delete parent directory
+      FileUtil.deleteDirectoryIfEmpty(getRepositoryFilesDir(repository.owner, repository.name))
+
       // Call hooks
       PluginRegistry().getRepositoryHooks.foreach(_.renamed(repository.owner, repository.name, form.repositoryName))
     }

src/main/scala/gitbucket/core/controller/RepositoryViewerController.scala

@@ -168,9 +168,10 @@ trait RepositoryViewerControllerBase extends ControllerBase {
     val owner = params("owner")
     val repository = params("repository")
     contentType = formats("json")
+    val creating = RepositoryCreationService.isCreating(owner, repository)
     Serialization.write(Map(
-      "creating" -> RepositoryCreationService.isCreating(owner, repository),
-      "error" -> RepositoryCreationService.getCreationError(owner, repository)
+      "creating" -> creating,
+      "error" -> (if(creating) None else RepositoryCreationService.getCreationError(owner, repository))
     ))
   }
 
@@ -400,13 +401,7 @@ trait RepositoryViewerControllerBase extends ControllerBase {
   })
 
   private def isLfsFile(git: Git, objectId: ObjectId): Boolean = {
-    JGitUtil.getObjectLoaderFromId(git, objectId){ loader =>
-      if(loader.isLarge){
-        false
-      } else {
-        new String(loader.getCachedBytes, "UTF-8").startsWith("version https://git-lfs.github.com/spec/v1")
-      }
-    }.getOrElse(false)
+    JGitUtil.getObjectLoaderFromId(git, objectId)(JGitUtil.isLfsPointer).getOrElse(false)
   }
 
   get("/:owner/:repository/blame/*"){
@@ -633,8 +628,8 @@ trait RepositoryViewerControllerBase extends ControllerBase {
   /**
    * Displays tags.
    */
-  get("/:owner/:repository/tags")(referrersOnly {
-    html.tags(_)
+  get("/:owner/:repository/tags")(referrersOnly { repository =>
+    redirect(s"${repository.owner}/${repository.name}/releases")
   })
 
   /**
@@ -847,7 +842,7 @@ trait RepositoryViewerControllerBase extends ControllerBase {
           defining(JGitUtil.getRevCommitFromId(git, objectId)) { revCommit =>
             val lastModifiedCommit = if(path == ".") revCommit else JGitUtil.getLastModifiedCommit(git, revCommit, path)
             // get files
-            val files = JGitUtil.getFileList(git, revision, path)
+            val files = JGitUtil.getFileList(git, revision, path, context.settings.baseUrl)
             val parentPath = if (path == ".") Nil else path.split("/").toList
             // process README.md or README.markdown
             val readme = files.find { file =>

src/main/scala/gitbucket/core/controller/SystemSettingsController.scala

@@ -2,27 +2,33 @@ package gitbucket.core.controller
 
 import java.io.FileInputStream
 
-import gitbucket.core.admin.html
-import gitbucket.core.service.{AccountService, RepositoryService, SystemSettingsService}
-import gitbucket.core.util.{AdminAuthenticator, Mailer}
-import gitbucket.core.ssh.SshServer
-import gitbucket.core.plugin.{PluginInfoBase, PluginRegistry, PluginRepository}
-import SystemSettingsService._
-import gitbucket.core.util.Implicits._
-import gitbucket.core.util.SyntaxSugars._
-import gitbucket.core.util.Directory._
-import gitbucket.core.util.StringUtil._
-import org.scalatra.forms._
-import org.apache.commons.io.{FileUtils, IOUtils}
-import org.scalatra.i18n.Messages
 import com.github.zafarkhaja.semver.{Version => Semver}
 import gitbucket.core.GitBucketCoreModule
-import scala.collection.JavaConverters._
+import gitbucket.core.admin.html
+import gitbucket.core.plugin.{PluginInfoBase, PluginRegistry, PluginRepository}
+import gitbucket.core.service.SystemSettingsService._
+import gitbucket.core.service.{AccountService, RepositoryService}
+import gitbucket.core.ssh.SshServer
+import gitbucket.core.util.Directory._
+import gitbucket.core.util.Implicits._
+import gitbucket.core.util.StringUtil._
+import gitbucket.core.util.SyntaxSugars._
+import gitbucket.core.util.{AdminAuthenticator, Mailer}
+import org.apache.commons.io.IOUtils
+import org.json4s.jackson.Serialization
+import org.scalatra._
+import org.scalatra.forms._
+import org.scalatra.i18n.Messages
 
+import scala.collection.JavaConverters._
+import scala.collection.mutable.ListBuffer
 
 class SystemSettingsController extends SystemSettingsControllerBase
   with AccountService with RepositoryService with AdminAuthenticator
 
+case class Table(name: String, columns: Seq[Column])
+case class Column(name: String, primaryKey: Boolean)
+
 trait SystemSettingsControllerBase extends AccountManagementControllerBase {
   self: AccountService with RepositoryService with AdminAuthenticator =>
 
@@ -64,6 +70,13 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
         "ssl"                      -> trim(label("Enable SSL", optional(boolean()))),
         "keystore"                 -> trim(label("Keystore", optional(text())))
     )(Ldap.apply)),
+    "oidcAuthentication"       -> trim(label("OIDC", boolean())),
+    "oidc"                     -> optionalIfNotChecked("oidcAuthentication", mapping(
+        "issuer"                   -> trim(label("Issuer", text(required))),
+        "clientID"                 -> trim(label("Client ID", text(required))),
+        "clientSecret"             -> trim(label("Client secret", text(required))),
+        "jwsAlgorithm"             -> trim(label("Signature algorithm", optional(text())))
+    )(OIDC.apply)),
     "skinName" -> trim(label("AdminLTE skin name", text(required)))
   )(SystemSettings.apply).verifying { settings =>
     Vector(
@@ -152,6 +165,71 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
   )(EditGroupForm.apply)
 
 
+  get("/admin/dbviewer")(adminOnly {
+    val conn = request2Session(request).conn
+    val meta = conn.getMetaData
+    val tables = ListBuffer[Table]()
+    using(meta.getTables(null, "%", "%", Array("TABLE", "VIEW"))){ rs =>
+      while(rs.next()){
+        val tableName = rs.getString("TABLE_NAME")
+
+        val pkColumns = ListBuffer[String]()
+        using(meta.getPrimaryKeys(null, null, tableName)){ rs =>
+          while(rs.next()){
+            pkColumns += rs.getString("COLUMN_NAME").toUpperCase
+          }
+        }
+
+        val columns = ListBuffer[Column]()
+        using(meta.getColumns(null, "%", tableName, "%")){ rs =>
+          while(rs.next()){
+            val columnName = rs.getString("COLUMN_NAME").toUpperCase
+            columns += Column(columnName, pkColumns.contains(columnName))
+          }
+        }
+
+        tables += Table(tableName.toUpperCase, columns)
+      }
+    }
+    html.dbviewer(tables)
+  })
+
+  post("/admin/dbviewer/_query")(adminOnly {
+    contentType = formats("json")
+    params.get("query").collectFirst { case query if query.trim.nonEmpty =>
+      val trimmedQuery = query.trim
+      if(trimmedQuery.nonEmpty){
+        try {
+          val conn = request2Session(request).conn
+          using(conn.prepareStatement(query)){ stmt =>
+            if(trimmedQuery.toUpperCase.startsWith("SELECT")){
+              using(stmt.executeQuery()){ rs =>
+                val meta = rs.getMetaData
+                val columns = for(i <- 1 to meta.getColumnCount) yield {
+                  meta.getColumnName(i)
+                }
+                val result = ListBuffer[Map[String, String]]()
+                while(rs.next()){
+                  val row = columns.map { columnName =>
+                    columnName -> Option(rs.getObject(columnName)).map(_.toString).getOrElse("<NULL>")
+                  }.toMap
+                  result += row
+                }
+                Ok(Serialization.write(Map("type" -> "query", "columns" -> columns, "rows" -> result)))
+              }
+            } else {
+              val rows = stmt.executeUpdate()
+              Ok(Serialization.write(Map("type" -> "update", "rows" -> rows)))
+            }
+          }
+        } catch {
+          case e: Exception =>
+            Ok(Serialization.write(Map("type" -> "error", "message" -> e.toString)))
+        }
+      }
+    } getOrElse Ok(Serialization.write(Map("type" -> "error", "message" -> "query is empty")))
+  })
+
   get("/admin/system")(adminOnly {
     html.system(flash.get("info"))
   })
@@ -260,12 +338,13 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
 
   get("/admin/users")(adminOnly {
     val includeRemoved = params.get("includeRemoved").map(_.toBoolean).getOrElse(false)
-    val users          = getAllUsers(includeRemoved)
+    val includeGroups = params.get("includeGroups").map(_.toBoolean).getOrElse(false)
+    val users          = getAllUsers(includeRemoved, includeGroups)
     val members        = users.collect { case account if(account.isGroupAccount) =>
       account.userName -> getGroupMembers(account.userName).map(_.userName)
     }.toMap
 
-    html.userlist(users, members, includeRemoved)
+    html.userlist(users, members, includeRemoved, includeGroups)
   })
 
   get("/admin/users/_newuser")(adminOnly {

src/main/scala/gitbucket/core/controller/WikiController.scala

@@ -219,10 +219,13 @@ trait WikiControllerBase extends ControllerBase {
 
   get("/:owner/:repository/wiki/_blob/*")(referrersOnly { repository =>
     val path = multiParams("splat").head
+    using(Git.open(getWikiRepositoryDir(repository.owner, repository.name))){ git =>
+      val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve("master"))
 
-    getFileContent(repository.owner, repository.name, path).map { bytes =>
-      RawData(FileUtil.getContentType(path, bytes), bytes)
-    } getOrElse NotFound()
+      getPathObjectId(git, path, revCommit).map { objectId =>
+        responseRawFile(git, objectId, path, repository)
+      } getOrElse NotFound()
+    }
   })
 
   private def unique: Constraint = new Constraint(){

src/main/scala/gitbucket/core/model/AccountFederation.scala

@@ -0,0 +1,19 @@
+package gitbucket.core.model
+
+trait AccountFederationComponent { self: Profile =>
+  import profile.api._
+
+  lazy val AccountFederations = TableQuery[AccountFederations]
+
+  class AccountFederations(tag: Tag) extends Table[AccountFederation](tag, "ACCOUNT_FEDERATION") {
+    val issuer = column[String]("ISSUER")
+    val subject = column[String]("SUBJECT")
+    val userName = column[String]("USER_NAME")
+    def * = (issuer, subject, userName) <> (AccountFederation.tupled, AccountFederation.unapply)
+
+    def byPrimaryKey(issuer: String, subject: String): Rep[Boolean] =
+      (this.issuer === issuer.bind) && (this.subject === subject.bind)
+  }
+}
+
+case class AccountFederation(issuer: String, subject: String, userName: String)

src/main/scala/gitbucket/core/model/Profile.scala

@@ -1,7 +1,7 @@
 package gitbucket.core.model
 
-import gitbucket.core.util.DatabaseConfig
 import com.github.takezoe.slick.blocking.BlockingJdbcProfile
+import gitbucket.core.util.DatabaseConfig
 
 trait Profile {
   val profile: BlockingJdbcProfile
@@ -61,7 +61,10 @@ trait CoreProfile extends ProfileProvider with Profile
   with RepositoryWebHookEventComponent
   with AccountWebHookComponent
   with AccountWebHookEventComponent
+  with AccountFederationComponent
   with ProtectedBranchComponent
   with DeployKeyComponent
+  with ReleaseComponent
+  with ReleaseAssetComponent
 
 object Profile extends CoreProfile

src/main/scala/gitbucket/core/model/Release.scala

@@ -0,0 +1,34 @@
+package gitbucket.core.model
+
+trait ReleaseComponent extends TemplateComponent {
+  self: Profile =>
+
+  import profile.api._
+  import self._
+
+  lazy val Releases = TableQuery[Releases]
+
+  class Releases(tag_ : Tag) extends Table[Release](tag_, "RELEASE") with BasicTemplate {
+    val name = column[String]("NAME")
+    val tag = column[String]("TAG")
+    val author = column[String]("AUTHOR")
+    val content = column[Option[String]]("CONTENT")
+    val registeredDate = column[java.util.Date]("REGISTERED_DATE")
+    val updatedDate = column[java.util.Date]("UPDATED_DATE")
+
+    def * = (userName, repositoryName, name, tag, author, content, registeredDate, updatedDate) <> (Release.tupled, Release.unapply)
+    def byPrimaryKey(owner: String, repository: String, tag: String) = byTag(owner, repository, tag)
+    def byTag(owner: String, repository: String, tag: String) = byRepository(owner, repository) && (this.tag === tag.bind)
+  }
+}
+
+case class Release(
+  userName: String,
+  repositoryName: String,
+  name: String,
+  tag: String,
+  author: String,
+  content: Option[String],
+  registeredDate: java.util.Date,
+  updatedDate: java.util.Date
+)

src/main/scala/gitbucket/core/model/ReleasesAsset.scala

@@ -0,0 +1,40 @@
+package gitbucket.core.model
+
+import java.util.Date
+
+trait ReleaseAssetComponent extends TemplateComponent {
+  self: Profile =>
+
+  import profile.api._
+  import self._
+
+  lazy val ReleaseAssets = TableQuery[ReleaseAssets]
+
+  class ReleaseAssets(tag_ : Tag) extends Table[ReleaseAsset](tag_, "RELEASE_ASSET") with BasicTemplate {
+    val tag = column[String]("TAG")
+    val releaseAssetId = column[Int]("RELEASE_ASSET_ID", O AutoInc)
+    val fileName = column[String]("FILE_NAME")
+    val label = column[String]("LABEL")
+    val size = column[Long]("SIZE")
+    val uploader = column[String]("UPLOADER")
+    val registeredDate = column[Date]("REGISTERED_DATE")
+    val updatedDate = column[Date]("UPDATED_DATE")
+
+    def * = (userName, repositoryName, tag, releaseAssetId, fileName, label, size, uploader, registeredDate, updatedDate) <> (ReleaseAsset.tupled, ReleaseAsset.unapply)
+    def byPrimaryKey(owner: String, repository: String, tag: String, fileName: String) = byTag(owner, repository, tag) && (this.fileName === fileName.bind)
+    def byTag(owner: String, repository: String, tag: String) = byRepository(owner, repository) && (this.tag === tag.bind)
+  }
+}
+
+case class ReleaseAsset(
+  userName: String,
+  repositoryName: String,
+  tag: String,
+  releaseAssetId: Int = 0,
+  fileName: String,
+  label: String,
+  size: Long,
+  uploader: String,
+  registeredDate: Date,
+  updatedDate: Date
+)

src/main/scala/gitbucket/core/service/AccountFederationService.scala

@@ -0,0 +1,77 @@
+package gitbucket.core.service
+
+import gitbucket.core.model.Profile.profile.blockingApi._
+import gitbucket.core.model.Profile.{AccountFederations, Accounts}
+import gitbucket.core.model.{Account, AccountFederation}
+import gitbucket.core.util.SyntaxSugars.~
+import org.slf4j.LoggerFactory
+
+trait AccountFederationService {
+  self: AccountService =>
+
+  private val logger = LoggerFactory.getLogger(classOf[AccountFederationService])
+
+  /**
+    * Get or create a user account federated with OIDC or SAML IdP.
+    *
+    * @param issuer            Issuer
+    * @param subject           Subject
+    * @param mailAddress       Mail address
+    * @param preferredUserName Username (if this is none, username will be generated from the mail address)
+    * @param fullName          Fullname (defaults to username)
+    * @return Account
+    */
+  def getOrCreateFederatedUser(issuer: String,
+                               subject: String,
+                               mailAddress: String,
+                               preferredUserName: Option[String],
+                               fullName: Option[String])(implicit s: Session): Option[Account] =
+    getAccountByFederation(issuer, subject) match {
+      case Some(account) if !account.isRemoved =>
+        Some(account)
+      case Some(account) =>
+        logger.info(s"Federated user found but disabled: userName=${account.userName}, isRemoved=${account.isRemoved}")
+        None
+      case None =>
+        findAvailableUserName(preferredUserName, mailAddress) flatMap { userName =>
+          createAccount(userName, "", fullName.getOrElse(userName), mailAddress, isAdmin = false, None, None)
+          createAccountFederation(issuer, subject, userName)
+          getAccountByUserName(userName)
+        }
+    }
+
+  private def extractSafeStringForUserName(s: String) = """^[a-zA-Z0-9][a-zA-Z0-9\-_.]*""".r.findPrefixOf(s)
+
+  /**
+    * Find an available username from the preferred username or mail address.
+    *
+    * @param mailAddress       Mail address
+    * @param preferredUserName Username
+    * @return Available username
+    */
+  def findAvailableUserName(preferredUserName: Option[String], mailAddress: String)(implicit s: Session): Option[String] = {
+    preferredUserName.flatMap(n => extractSafeStringForUserName(n)).orElse(extractSafeStringForUserName(mailAddress)) match {
+      case Some(safeUserName) =>
+        getAccountByUserName(safeUserName, includeRemoved = true) match {
+          case None => Some(safeUserName)
+          case Some(_) =>
+            logger.info(s"User ($safeUserName) already exists. preferredUserName=$preferredUserName, mailAddress=$mailAddress")
+            None
+        }
+      case None =>
+        logger.info(s"Could not extract username from preferredUserName=$preferredUserName, mailAddress=$mailAddress")
+        None
+    }
+  }
+
+  def getAccountByFederation(issuer: String, subject: String)(implicit s: Session): Option[Account] =
+    AccountFederations.filter(_.byPrimaryKey(issuer, subject))
+      .join(Accounts).on { case af ~ ac => af.userName === ac.userName }
+      .map { case _ ~ ac => ac }
+      .firstOption
+
+  def createAccountFederation(issuer: String, subject: String, userName: String)(implicit s: Session): Unit =
+    AccountFederations insert AccountFederation(issuer, subject, userName)
+}
+
+object AccountFederationService extends AccountFederationService with AccountService

src/main/scala/gitbucket/core/service/AccountService.scala

@@ -96,12 +96,14 @@ trait AccountService {
   def getAccountByMailAddress(mailAddress: String, includeRemoved: Boolean = false)(implicit s: Session): Option[Account] =
     Accounts filter(t => (t.mailAddress.toLowerCase === mailAddress.toLowerCase.bind) && (t.removed === false.bind, !includeRemoved)) firstOption
 
-  def getAllUsers(includeRemoved: Boolean = true)(implicit s: Session): List[Account] =
-    if(includeRemoved){
-      Accounts sortBy(_.userName) list
-    } else {
-      Accounts filter (_.removed === false.bind) sortBy(_.userName) list
-    }
+  def getAllUsers(includeRemoved: Boolean = true, includeGroups: Boolean = true)(implicit s: Session): List[Account] =
+  {
+    Accounts filter { t =>
+      (1.bind === 1.bind) &&
+        (t.groupAccount === false.bind, !includeGroups) &&
+        (t.removed === false.bind, !includeRemoved)
+    } sortBy(_.userName) list
+  }
 
   def isLastAdministrator(account: Account)(implicit s: Session): Boolean = {
     if(account.isAdmin){

src/main/scala/gitbucket/core/service/ActivityService.scala

@@ -190,6 +190,13 @@ trait ActivityService {
       Some(message),
       currentDate)
 
+  def recordReleaseActivity(userName: String, repositoryName: String, activityUserName: String, name: String)(implicit s: Session): Unit =
+    Activities insert Activity(userName, repositoryName, activityUserName,
+      "release",
+      s"[user:${activityUserName}] released ${name} at [repo:${userName}/${repositoryName}]",
+      None,
+      currentDate)
+
   private def cut(value: String, length: Int): String =
     if(value.length > length) value.substring(0, length) + "..." else value
 }

src/main/scala/gitbucket/core/service/IssuesService.scala

@@ -471,7 +471,14 @@ trait IssuesService {
 
   def getAssignableUserNames(owner: String, repository: String)(implicit s: Session): List[String] = {
     (getCollaboratorUserNames(owner, repository, Seq(Role.ADMIN, Role.DEVELOPER)) :::
-      (if (getAccountByUserName(owner).get.isGroupAccount) getGroupMembers(owner).map(_.userName) else List(owner))).distinct.sorted
+      (getAccountByUserName(owner) match {
+        case Some(x) if x.isGroupAccount =>
+          getGroupMembers(owner).map(_.userName)
+        case Some(_) =>
+          List(owner)
+        case None =>
+          Nil
+      })).distinct.sorted
   }
 
 }

src/main/scala/gitbucket/core/service/MergeService.scala

@@ -4,7 +4,7 @@ import gitbucket.core.model.Account
 import gitbucket.core.util.Directory._
 import gitbucket.core.util.SyntaxSugars._
 import org.eclipse.jgit.merge.{MergeStrategy, Merger, RecursiveMerger}
-import org.eclipse.jgit.api.{Git, MergeResult}
+import org.eclipse.jgit.api.Git
 import org.eclipse.jgit.transport.RefSpec
 import org.eclipse.jgit.errors.NoMergeBaseException
 import org.eclipse.jgit.lib.{CommitBuilder, ObjectId, PersonIdent, Repository}
@@ -211,7 +211,7 @@ object MergeService{
     }
 
     // update branch from cache
-    def merge(message:String, committer:PersonIdent) = {
+    def merge(message: String, committer: PersonIdent) = {
       if(checkConflict().isDefined){
         throw new RuntimeException("This pull request can't merge automatically.")
       }
@@ -229,12 +229,13 @@ object MergeService{
         throw new RuntimeException("This pull request can't merge automatically.")
       }
 
-      def _cloneCommit(commit: RevCommit, parents: Array[ObjectId]): CommitBuilder = {
+      def _cloneCommit(commit: RevCommit, parentId: ObjectId, baseId: ObjectId): CommitBuilder = {
+        val merger = MergeStrategy.RECURSIVE.newMerger(repository, true)
+        merger.merge(commit.toObjectId, baseId)
+
         val newCommit = new CommitBuilder()
-        newCommit.setTreeId(commit.getTree.getId)
-        parents.foreach { parentId =>
-          newCommit.addParentId(parentId)
-        }
+        newCommit.setTreeId(merger.getResultTreeId)
+        newCommit.addParentId(parentId)
         newCommit.setAuthor(commit.getAuthorIdent)
         newCommit.setCommitter(committer)
         newCommit.setMessage(commit.getFullMessage)
@@ -246,7 +247,7 @@ object MergeService{
 
       using(repository.newObjectInserter){ inserter =>
         commits.foreach { commit =>
-          val nextCommit = _cloneCommit(commit, Array(previousId))
+          val nextCommit = _cloneCommit(commit, previousId, mergeBaseTipCommit.getId)
           previousId = inserter.insert(nextCommit)
         }
         inserter.flush()

src/main/scala/gitbucket/core/service/OpenIDConnectService.scala

@@ -0,0 +1,191 @@
+package gitbucket.core.service
+
+import java.net.URI
+
+import com.nimbusds.jose.JWSAlgorithm.Family
+import com.nimbusds.jose.proc.BadJOSEException
+import com.nimbusds.jose.util.DefaultResourceRetriever
+import com.nimbusds.jose.{JOSEException, JWSAlgorithm}
+import com.nimbusds.oauth2.sdk._
+import com.nimbusds.oauth2.sdk.auth.ClientSecretBasic
+import com.nimbusds.oauth2.sdk.id.{ClientID, Issuer, State}
+import com.nimbusds.openid.connect.sdk.claims.IDTokenClaimsSet
+import com.nimbusds.openid.connect.sdk.op.OIDCProviderMetadata
+import com.nimbusds.openid.connect.sdk.validators.IDTokenValidator
+import com.nimbusds.openid.connect.sdk.{AuthenticationErrorResponse, _}
+import gitbucket.core.model.Account
+import gitbucket.core.model.Profile.profile.blockingApi._
+import org.slf4j.LoggerFactory
+
+import scala.collection.JavaConverters.{asScalaSet, mapAsJavaMap}
+
+/**
+  * Service class for the OpenID Connect authentication.
+  */
+trait OpenIDConnectService {
+  self: AccountFederationService =>
+
+  private val logger = LoggerFactory.getLogger(classOf[OpenIDConnectService])
+
+  private val JWK_REQUEST_TIMEOUT = 5000
+
+  private val OIDC_SCOPE = new Scope(
+    OIDCScopeValue.OPENID,
+    OIDCScopeValue.EMAIL,
+    OIDCScopeValue.PROFILE)
+
+  /**
+    * Obtain the OIDC metadata from discovery and create an authentication request.
+    *
+    * @param issuer      Issuer, used to construct the discovery endpoint URL, e.g. https://accounts.google.com
+    * @param clientID    Client ID (given by the issuer)
+    * @param redirectURI Redirect URI
+    * @return Authentication request
+    */
+  def createOIDCAuthenticationRequest(issuer: Issuer,
+                                      clientID: ClientID,
+                                      redirectURI: URI): AuthenticationRequest = {
+    val metadata = OIDCProviderMetadata.resolve(issuer)
+    new AuthenticationRequest(
+      metadata.getAuthorizationEndpointURI,
+      new ResponseType(ResponseType.Value.CODE),
+      OIDC_SCOPE,
+      clientID,
+      redirectURI,
+      new State(),
+      new Nonce())
+  }
+
+  /**
+    * Proceed the OpenID Connect authentication.
+    *
+    * @param params      Query parameters of the authentication response
+    * @param redirectURI Redirect URI
+    * @param state       State saved in the session
+    * @param nonce       Nonce saved in the session
+    * @param oidc        OIDC settings
+    * @return ID token
+    */
+  def authenticate(params: Map[String, String],
+                   redirectURI: URI,
+                   state: State,
+                   nonce: Nonce,
+                   oidc: SystemSettingsService.OIDC)(implicit s: Session): Option[Account] =
+    validateOIDCAuthenticationResponse(params, state, redirectURI) flatMap { authenticationResponse =>
+      obtainOIDCToken(authenticationResponse.getAuthorizationCode, nonce, redirectURI, oidc) flatMap { claims =>
+        Seq("email", "preferred_username", "name").map(k => Option(claims.getStringClaim(k))) match {
+          case Seq(Some(email), preferredUsername, name) =>
+            getOrCreateFederatedUser(claims.getIssuer.getValue, claims.getSubject.getValue, email, preferredUsername, name)
+          case _ =>
+            logger.info(s"OIDC ID token must have an email claim: claims=${claims.toJSONObject}")
+            None
+        }
+      }
+    }
+
+  /**
+    * Validate the authentication response.
+    *
+    * @param params      Query parameters of the authentication response
+    * @param state       State saved in the session
+    * @param redirectURI Redirect URI
+    * @return Authentication response
+    */
+  def validateOIDCAuthenticationResponse(params: Map[String, String], state: State, redirectURI: URI): Option[AuthenticationSuccessResponse] =
+    try {
+      AuthenticationResponseParser.parse(redirectURI, mapAsJavaMap(params)) match {
+        case response: AuthenticationSuccessResponse =>
+          if (response.getState == state) {
+            Some(response)
+          } else {
+            logger.info(s"OIDC authentication state did not match: response(${response.getState}) != session($state)")
+            None
+          }
+        case response: AuthenticationErrorResponse =>
+          logger.info(s"OIDC authentication response has error: ${response.getErrorObject}")
+          None
+      }
+    } catch {
+      case e: ParseException =>
+        logger.info(s"OIDC authentication response has error: $e")
+        None
+    }
+
+  /**
+    * Obtain the ID token from the OpenID Provider.
+    *
+    * @param authorizationCode Authorization code in the query string
+    * @param nonce             Nonce
+    * @param redirectURI       Redirect URI
+    * @param oidc              OIDC settings
+    * @return Token response
+    */
+  def obtainOIDCToken(authorizationCode: AuthorizationCode,
+                      nonce: Nonce,
+                      redirectURI: URI,
+                      oidc: SystemSettingsService.OIDC): Option[IDTokenClaimsSet] = {
+    val metadata = OIDCProviderMetadata.resolve(oidc.issuer)
+    val tokenRequest = new TokenRequest(metadata.getTokenEndpointURI,
+      new ClientSecretBasic(oidc.clientID, oidc.clientSecret),
+      new AuthorizationCodeGrant(authorizationCode, redirectURI),
+      OIDC_SCOPE)
+    val httpResponse = tokenRequest.toHTTPRequest.send()
+    try {
+      OIDCTokenResponseParser.parse(httpResponse) match {
+        case response: OIDCTokenResponse =>
+          validateOIDCTokenResponse(response, metadata, nonce, oidc)
+        case response: TokenErrorResponse =>
+          logger.info(s"OIDC token response has error: ${response.getErrorObject.toJSONObject}")
+          None
+      }
+    } catch {
+      case e: ParseException =>
+        logger.info(s"OIDC token response has error: $e")
+        None
+    }
+  }
+
+  /**
+    * Validate the token response.
+    *
+    * @param response Token response
+    * @param metadata OpenID Provider metadata
+    * @param nonce    Nonce
+    * @return Claims
+    */
+  def validateOIDCTokenResponse(response: OIDCTokenResponse,
+                                metadata: OIDCProviderMetadata,
+                                nonce: Nonce,
+                                oidc: SystemSettingsService.OIDC): Option[IDTokenClaimsSet] =
+    Option(response.getOIDCTokens.getIDToken) match {
+      case Some(jwt) =>
+        val validator = oidc.jwsAlgorithm map { jwsAlgorithm =>
+          new IDTokenValidator(metadata.getIssuer, oidc.clientID, jwsAlgorithm, metadata.getJWKSetURI.toURL,
+            new DefaultResourceRetriever(JWK_REQUEST_TIMEOUT, JWK_REQUEST_TIMEOUT))
+        } getOrElse {
+          new IDTokenValidator(metadata.getIssuer, oidc.clientID)
+        }
+        try {
+          Some(validator.validate(jwt, nonce))
+        } catch {
+          case e@(_: BadJOSEException | _: JOSEException) =>
+            logger.info(s"OIDC ID token has error: $e")
+            None
+        }
+      case None =>
+        logger.info(s"OIDC token response does not have a valid ID token: ${response.toJSONObject}")
+        None
+    }
+}
+
+object OpenIDConnectService {
+  /**
+    * All signature algorithms.
+    */
+  val JWS_ALGORITHMS: Map[String, Set[JWSAlgorithm]] = Seq(
+    "HMAC" -> Family.HMAC_SHA,
+    "RSA" -> Family.RSA,
+    "ECDSA" -> Family.EC,
+    "EdDSA" -> Family.ED
+  ).toMap.map { case (name, family) => (name, asScalaSet(family).toSet) }
+}

src/main/scala/gitbucket/core/service/ReleaseService.scala

@@ -0,0 +1,87 @@
+package gitbucket.core.service
+
+import gitbucket.core.controller.Context
+import gitbucket.core.model.{Account, Release, ReleaseAsset}
+import gitbucket.core.model.Profile.profile.blockingApi._
+import gitbucket.core.model.Profile._
+import gitbucket.core.model.Profile.dateColumnType
+
+trait ReleaseService {
+  self: AccountService with RepositoryService =>
+
+  def createReleaseAsset(owner: String, repository: String, tag: String, fileName: String, label: String, size: Long, loginAccount: Account)(implicit s: Session): Unit = {
+    ReleaseAssets insert ReleaseAsset(
+      userName       = owner,
+      repositoryName = repository,
+      tag            = tag,
+      fileName       = fileName,
+      label          = label,
+      size           = size,
+      uploader       = loginAccount.userName,
+      registeredDate = currentDate,
+      updatedDate    = currentDate
+    )
+  }
+
+  def getReleaseAssets(owner: String, repository: String, tag: String)(implicit s: Session): Seq[ReleaseAsset] = {
+    ReleaseAssets.filter(x => x.byTag(owner, repository, tag)).list
+  }
+
+  def getReleaseAssetsMap(owner: String, repository: String)(implicit s: Session): Map[Release, Seq[ReleaseAsset]] = {
+    val releases = getReleases(owner, repository)
+    releases.map(rel => (rel -> getReleaseAssets(owner, repository, rel.tag))).toMap
+  }
+
+  def getReleaseAsset(owner: String, repository: String, tag: String, fileId: String)(implicit s: Session): Option[ReleaseAsset] = {
+    ReleaseAssets.filter(x => x.byPrimaryKey(owner, repository, tag, fileId)) firstOption
+  }
+
+  def deleteReleaseAssets(owner: String, repository: String, tag: String)(implicit s: Session): Unit = {
+    ReleaseAssets.filter(x => x.byTag(owner, repository, tag)) delete
+  }
+
+  def createRelease(owner: String, repository: String, name: String, content: Option[String], tag: String,
+                    loginAccount: Account)(implicit context: Context, s: Session): Int = {
+    Releases insert Release(
+      userName       = owner,
+      repositoryName = repository,
+      name           = name,
+      tag            = tag,
+      author         = loginAccount.userName,
+      content        = content,
+      registeredDate = currentDate,
+      updatedDate    = currentDate
+    )
+  }
+
+  def getReleases(owner: String, repository: String)(implicit s: Session): Seq[Release] = {
+    Releases.filter(x => x.byRepository(owner, repository)).list
+  }
+
+  def getRelease(owner: String, repository: String, tag: String)(implicit s: Session): Option[Release] = {
+    //Releases filter (_.byPrimaryKey(owner, repository, releaseId)) firstOption
+    Releases filter (_.byTag(owner, repository, tag)) firstOption
+  }
+
+//  def getReleaseByTag(owner: String, repository: String, tag: String)(implicit s: Session): Option[Release] = {
+//    Releases filter (_.byTag(owner, repository, tag)) firstOption
+//  }
+//
+//  def getRelease(owner: String, repository: String, releaseId: String)(implicit s: Session): Option[Release] = {
+//    if (isInteger(releaseId))
+//      getRelease(owner, repository, releaseId.toInt)
+//    else None
+//  }
+
+  def updateRelease(owner: String, repository: String, tag: String, title: String, content: Option[String])(implicit s: Session): Int = {
+    Releases
+      .filter (_.byPrimaryKey(owner, repository, tag))
+      .map { t => (t.name, t.content, t.updatedDate) }
+      .update (title, content, currentDate)
+  }
+
+  def deleteRelease(owner: String, repository: String, tag: String)(implicit s: Session): Unit = {
+    deleteReleaseAssets(owner, repository, tag)
+    Releases filter (_.byPrimaryKey(owner, repository, tag)) delete
+  }
+}

src/main/scala/gitbucket/core/service/RepositoryService.scala

@@ -3,7 +3,7 @@ package gitbucket.core.service
 import gitbucket.core.controller.Context
 import gitbucket.core.util._
 import gitbucket.core.util.SyntaxSugars._
-import gitbucket.core.model.{Account, Collaborator, Repository, RepositoryOptions, Role}
+import gitbucket.core.model.{Account, Collaborator, Repository, RepositoryOptions, Role, Release}
 import gitbucket.core.model.Profile._
 import gitbucket.core.model.Profile.profile.blockingApi._
 import gitbucket.core.model.Profile.dateColumnType
@@ -75,6 +75,8 @@ trait RepositoryService { self: AccountService =>
         val protectedBranches       = ProtectedBranches      .filter(_.byRepository(oldUserName, oldRepositoryName)).list
         val protectedBranchContexts = ProtectedBranchContexts.filter(_.byRepository(oldUserName, oldRepositoryName)).list
         val deployKeys              = DeployKeys             .filter(_.byRepository(oldUserName, oldRepositoryName)).list
+        val releases                = Releases               .filter(_.byRepository(oldUserName, oldRepositoryName)).list
+        val releaseAssets           = ReleaseAssets          .filter(_.byRepository(oldUserName, oldRepositoryName)).list
 
         Repositories.filter { t =>
           (t.originUserName === oldUserName.bind) && (t.originRepositoryName === oldRepositoryName.bind)
@@ -120,6 +122,8 @@ trait RepositoryService { self: AccountService =>
         ProtectedBranches      .insertAll(protectedBranches.map(_.copy(userName = newUserName, repositoryName = newRepositoryName)) :_*)
         ProtectedBranchContexts.insertAll(protectedBranchContexts.map(_.copy(userName = newUserName, repositoryName = newRepositoryName)) :_*)
         DeployKeys             .insertAll(deployKeys    .map(_.copy(userName = newUserName, repositoryName = newRepositoryName)) :_*)
+        Releases               .insertAll(releases      .map(_.copy(userName = newUserName, repositoryName = newRepositoryName)) :_*)
+        ReleaseAssets          .insertAll(releaseAssets .map(_.copy(userName = newUserName, repositoryName = newRepositoryName)) :_*)
 
         // Update source repository of pull requests
         PullRequests.filter { t =>
@@ -173,6 +177,8 @@ trait RepositoryService { self: AccountService =>
     RepositoryWebHooks      .filter(_.byRepository(userName, repositoryName)).delete
     RepositoryWebHookEvents .filter(_.byRepository(userName, repositoryName)).delete
     DeployKeys              .filter(_.byRepository(userName, repositoryName)).delete
+    ReleaseAssets .filter(_.byRepository(userName, repositoryName)).delete
+    Releases      .filter(_.byRepository(userName, repositoryName)).delete
     Repositories            .filter(_.byRepository(userName, repositoryName)).delete
 
     // Update ORIGIN_USER_NAME and ORIGIN_REPOSITORY_NAME
@@ -514,7 +520,7 @@ object RepositoryService {
       this(repo.owner, repo.name, model, issueCount, pullCount, forkedCount, repo.branchList, repo.tags, managers)
 
     /**
-     * Creates instance without issue count and pull request count.
+     * Creates instance without issue and  pull request count.
      */
     def this(repo: JGitUtil.RepositoryInfo, model: Repository, 	forkedCount: Int, managers: Seq[String]) =
       this(repo.owner, repo.name, model, 0, 0, forkedCount, repo.branchList, repo.tags, managers)
@@ -539,5 +545,4 @@ object RepositoryService {
       context.settings.sshAddress.map { x => s"ssh://${x.genericUser}@${x.host}:${x.port}/${owner}/${name}.git" }
     } else None
   def openRepoUrl(openUrl: String)(implicit context: Context): String = s"github-${context.platform}://openRepo/${openUrl}"
-
 }

src/main/scala/gitbucket/core/service/SystemSettingsService.scala

@@ -1,11 +1,14 @@
 package gitbucket.core.service
 
-import gitbucket.core.util.Implicits._
+import javax.servlet.http.HttpServletRequest
+
+import com.nimbusds.jose.JWSAlgorithm
+import com.nimbusds.oauth2.sdk.auth.Secret
+import com.nimbusds.oauth2.sdk.id.{ClientID, Issuer}
+import gitbucket.core.service.SystemSettingsService._
 import gitbucket.core.util.ConfigUtil._
 import gitbucket.core.util.Directory._
 import gitbucket.core.util.SyntaxSugars._
-import SystemSettingsService._
-import javax.servlet.http.HttpServletRequest
 
 trait SystemSettingsService {
 
@@ -54,6 +57,15 @@ trait SystemSettingsService {
           ldap.keystore.foreach(x => props.setProperty(LdapKeystore, x))
         }
       }
+      props.setProperty(OidcAuthentication, settings.oidcAuthentication.toString)
+      if (settings.oidcAuthentication) {
+        settings.oidc.map { oidc =>
+          props.setProperty(OidcIssuer, oidc.issuer.getValue)
+          props.setProperty(OidcClientId, oidc.clientID.getValue)
+          props.setProperty(OidcClientSecret, oidc.clientSecret.getValue)
+          oidc.jwsAlgorithm.map { x => props.setProperty(OidcJwsAlgorithm, x.getName) }
+        }
+      }
       props.setProperty(SkinName, settings.skinName.toString)
       using(new java.io.FileOutputStream(GitBucketConf)){ out =>
         props.store(out, null)
@@ -113,6 +125,17 @@ trait SystemSettingsService {
         } else {
           None
         },
+        getValue(props, OidcAuthentication, false),
+        if (getValue(props, OidcAuthentication, false)) {
+          Some(OIDC(
+            getValue(props, OidcIssuer, ""),
+            getValue(props, OidcClientId, ""),
+            getValue(props, OidcClientSecret, ""),
+            getOptionValue(props, OidcJwsAlgorithm, None)
+          ))
+        } else {
+          None
+        },
         getValue(props, SkinName, "skin-blue")
       )
     }
@@ -139,6 +162,8 @@ object SystemSettingsService {
     smtp: Option[Smtp],
     ldapAuthentication: Boolean,
     ldap: Option[Ldap],
+    oidcAuthentication: Boolean,
+    oidc: Option[OIDC],
     skinName: String){
 
     def baseUrl(request: HttpServletRequest): String = baseUrl.fold {
@@ -166,6 +191,16 @@ object SystemSettingsService {
     ssl: Option[Boolean],
     keystore: Option[String])
 
+  case class OIDC(
+    issuer: Issuer,
+    clientID: ClientID,
+    clientSecret: Secret,
+    jwsAlgorithm: Option[JWSAlgorithm])
+  object OIDC {
+    def apply(issuer: String, clientID: String, clientSecret: String, jwsAlgorithm: Option[String]): OIDC =
+      new OIDC(new Issuer(issuer), new ClientID(clientID), new Secret(clientSecret), jwsAlgorithm.map(JWSAlgorithm.parse))
+  }
+
   case class Smtp(
     host: String,
     port: Option[Int],
@@ -221,6 +256,11 @@ object SystemSettingsService {
   private val LdapTls = "ldap.tls"
   private val LdapSsl = "ldap.ssl"
   private val LdapKeystore = "ldap.keystore"
+  private val OidcAuthentication = "oidc_authentication"
+  private val OidcIssuer = "oidc.issuer"
+  private val OidcClientId = "oidc.client_id"
+  private val OidcClientSecret = "oidc.client_secret"
+  private val OidcJwsAlgorithm = "oidc.jws_algorithm"
   private val SkinName = "skinName"
 
   private def getValue[A: ClassTag](props: java.util.Properties, key: String, default: A): A = {

src/main/scala/gitbucket/core/service/WikiService.scala

@@ -75,22 +75,6 @@ trait WikiService {
     }
   }
 
-  /**
-   * Returns the content of the specified file.
-   */
-  def getFileContent(owner: String, repository: String, path: String): Option[Array[Byte]] =
-    using(Git.open(Directory.getWikiRepositoryDir(owner, repository))){ git =>
-      if(!JGitUtil.isEmpty(git)){
-        val index = path.lastIndexOf('/')
-        val parentPath = if(index < 0) "."  else path.substring(0, index)
-        val fileName   = if(index < 0) path else path.substring(index + 1)
-
-        JGitUtil.getFileList(git, "master", parentPath).find(_.name == fileName).map { file =>
-          git.getRepository.open(file.id).getBytes
-        }
-      } else None
-    }
-
   /**
    * Returns the list of wiki page names.
    */

src/main/scala/gitbucket/core/servlet/CompositeScalatraFilter.scala

@@ -37,7 +37,7 @@ class CompositeScalatraFilter extends Filter {
     }
 
     if(!checkPath.startsWith("/upload/") && !checkPath.startsWith("/git/") && !checkPath.startsWith("/git-lfs/") &&
-       !checkPath.startsWith("/plugin-assets/") && !checkPath.startsWith("/console/")){
+       !checkPath.startsWith("/plugin-assets/")){
       filters
         .filter { case (_, path) =>
           val start = path.replaceFirst("/\\*$", "/")

src/main/scala/gitbucket/core/servlet/TransactionFilter.scala

@@ -23,7 +23,7 @@ class TransactionFilter extends Filter {
 
   def doFilter(req: ServletRequest, res: ServletResponse, chain: FilterChain): Unit = {
     val servletPath = req.asInstanceOf[HttpServletRequest].getServletPath()
-    if(servletPath.startsWith("/assets/")  || servletPath == "/console" || servletPath == "/git" || servletPath == "/git-lfs"){
+    if(servletPath.startsWith("/assets/")  || servletPath == "/git" || servletPath == "/git-lfs"){
       // assets and git-lfs don't need transaction
       chain.doFilter(req, res)
     } else {

src/main/scala/gitbucket/core/util/Directory.scala

@@ -54,6 +54,12 @@ object Directory {
   def getAttachedDir(owner: String, repository: String): File =
     new File(getRepositoryFilesDir(owner, repository), "comments")
 
+  /**
+    * Directory for released files
+    */
+  def getReleaseFilesDir(owner: String, repository: String): File =
+    new File(getRepositoryFilesDir(owner, repository), "releases")
+
   /**
    * Directory for files which are attached to issue.
    */

src/main/scala/gitbucket/core/util/FileUtil.scala

@@ -76,4 +76,9 @@ object FileUtil {
     file
   }
 
+  lazy val MaxFileSize = if (System.getProperty("gitbucket.maxFileSize") != null)
+    System.getProperty("gitbucket.maxFileSize").toLong
+  else
+    3 * 1024 * 1024
+
 }

src/main/scala/gitbucket/core/util/JGitUtil.scala

@@ -22,7 +22,7 @@ import java.util.Date
 import java.util.concurrent.TimeUnit
 import java.util.function.Consumer
 
-import org.cache2k.{Cache2kBuilder, CacheEntry}
+import org.cache2k.Cache2kBuilder
 import org.eclipse.jgit.api.errors.{InvalidRefNameException, JGitInternalException, NoHeadException, RefAlreadyExistsException}
 import org.eclipse.jgit.diff.{DiffEntry, DiffFormatter, RawTextComparator}
 import org.eclipse.jgit.dircache.DirCacheEntry
@@ -151,9 +151,10 @@ object JGitUtil {
    *
    * @param name the module name
    * @param path the path in the repository
-   * @param url the repository url of this module
+   * @param repositoryUrl the repository url of this module
+   * @param viewerUrl the repository viewer url of this module
    */
-  case class SubmoduleInfo(name: String, path: String, url: String)
+  case class SubmoduleInfo(name: String, path: String, repositoryUrl: String, viewerUrl: String)
 
   case class BranchMergeInfo(ahead: Int, behind: Int, isMerged: Boolean)
 
@@ -189,11 +190,9 @@ object JGitUtil {
     val dir = git.getRepository.getDirectory
     val keyPrefix = dir.getAbsolutePath + "@"
 
-    cache.forEach(new Consumer[CacheEntry[String, Int]] {
-      override def accept(entry: CacheEntry[String, Int]): Unit = {
-        if(entry.getKey.startsWith(keyPrefix)){
-          cache.remove(entry.getKey)
-        }
+    cache.keys.forEach(key => {
+      if (key.startsWith(keyPrefix)) {
+        cache.remove(key)
       }
     })
   }
@@ -254,9 +253,10 @@ object JGitUtil {
    * @param git the Git object
    * @param revision the branch name or commit id
    * @param path the directory path (optional)
+   * @param baseUrl the base url of GitBucket instance. This parameter is used to generate links of submodules (optional)
    * @return HTML of the file list
    */
-  def getFileList(git: Git, revision: String, path: String = "."): List[FileInfo] = {
+  def getFileList(git: Git, revision: String, path: String = ".", baseUrl: Option[String] = None): List[FileInfo] = {
     using(new RevWalk(git.getRepository)){ revWalk =>
       val objectId = git.getRepository.resolve(revision)
       if(objectId == null) return Nil
@@ -342,7 +342,7 @@ object JGitUtil {
       useTreeWalk(revCommit){ treeWalk =>
         while (treeWalk.next()) {
           val linkUrl = if (treeWalk.getFileMode(0) == FileMode.GITLINK) {
-            getSubmodules(git, revCommit.getTree).find(_.path == treeWalk.getPathString).map(_.url)
+            getSubmodules(git, revCommit.getTree, baseUrl).find(_.path == treeWalk.getPathString).map(_.viewerUrl)
           } else None
           fileList +:= (treeWalk.getObjectId(0), treeWalk.getFileMode(0), treeWalk.getNameString, treeWalk.getPathString, linkUrl)
         }
@@ -732,7 +732,7 @@ object JGitUtil {
   /**
    * Read submodule information from .gitmodules
    */
-  def getSubmodules(git: Git, tree: RevTree): List[SubmoduleInfo] = {
+  def getSubmodules(git: Git, tree: RevTree, baseUrl: Option[String]): List[SubmoduleInfo] = {
     val repository = git.getRepository
     getContentFromPath(git, tree, ".gitmodules", true).map { bytes =>
       (try {
@@ -740,7 +740,7 @@ object JGitUtil {
         config.getSubsections("submodule").asScala.map { module =>
           val path = config.getString("submodule", module, "path")
           val url  = config.getString("submodule", module, "url")
-          SubmoduleInfo(module, path, url)
+          SubmoduleInfo(module, path, url, StringUtil.getRepositoryViewerUrl(url, baseUrl))
         }
       } catch {
         case e: ConfigInvalidException => {
@@ -804,17 +804,22 @@ object JGitUtil {
     }
   }
 
+  def isLfsPointer(loader: ObjectLoader): Boolean = {
+    !loader.isLarge && new String(loader.getBytes(), "UTF-8").startsWith("version https://git-lfs.github.com/spec/v1")
+  }
+
   def getContentInfo(git: Git, path: String, objectId: ObjectId): ContentInfo = {
     // Viewer
     using(git.getRepository.getObjectDatabase){ db =>
       val loader = db.open(objectId)
+      val isLfs  = isLfsPointer(loader)
       val large  = FileUtil.isLarge(loader.getSize)
       val viewer = if(FileUtil.isImage(path)) "image" else if(large) "large" else "other"
       val bytes  = if(viewer == "other") JGitUtil.getContentFromId(git, objectId, false) else None
       val size = Some(getContentSize(loader))
 
       if(viewer == "other"){
-        if(bytes.isDefined && FileUtil.isText(bytes.get)){
+        if(!isLfs && bytes.isDefined && FileUtil.isText(bytes.get)){
           // text
           ContentInfo("text", size, Some(StringUtil.convertFromByteArray(bytes.get)), Some(StringUtil.detectEncoding(bytes.get)))
         } else {

src/main/scala/gitbucket/core/util/Keys.scala

@@ -25,6 +25,11 @@ object Keys {
      */
     val DashboardPulls = "dashboard/pulls"
 
+    /**
+      * Session key for the OpenID Connect authentication.
+      */
+    val OidcContext = "oidcContext"
+
     /**
      * Generate session key for the issue search condition.
      */

src/main/scala/gitbucket/core/util/StringUtil.scala

@@ -123,17 +123,22 @@ object StringUtil {
     "(?i)(?<!\\w)(?:fix(?:e[sd])?|resolve[sd]?|close[sd]?)\\s+#(\\d+)(?!\\w)".r
       .findAllIn(message).matchData.map(_.group(1)).toSeq.distinct
 
+  private val GitBucketUrlPattern = "^(https?://.+)/git/(.+?)/(.+?)\\.git$".r
+  private val GitHubUrlPattern    = "^https://(.+@)?github\\.com/(.+?)/(.+?)\\.git$".r
+  private val BitBucketUrlPattern = "^https?://(.+@)?bitbucket\\.org/(.+?)/(.+?)\\.git$".r
+  private val GitLabUrlPattern    = "^https?://(.+@)?gitlab\\.com/(.+?)/(.+?)\\.git$".r
+
+  def getRepositoryViewerUrl(gitRepositoryUrl: String, baseUrl: Option[String]): String = {
+    def removeUserName(baseUrl: String): String = baseUrl.replaceFirst("(https?://).+@", "$1")
+
+    gitRepositoryUrl match {
+      case GitBucketUrlPattern(base, user, repository) if baseUrl.map(removeUserName(base).startsWith).getOrElse(false)
+                                                    => s"${removeUserName(base)}/$user/$repository"
+      case GitHubUrlPattern   (_, user, repository) => s"https://github.com/$user/$repository"
+      case BitBucketUrlPattern(_, user, repository) => s"https://bitbucket.org/$user/$repository"
+      case GitLabUrlPattern   (_, user, repository) => s"https://gitlab.com/$user/$repository"
+      case _ => gitRepositoryUrl
+    }
+  }
 
-//  /**
-//   * Encode search string for LIKE condition.
-//   * This method has been copied from Slick's SqlUtilsComponent.
-//   */
-//  def likeEncode(s: String) = {
-//    val b = new StringBuilder
-//    for(c <- s) c match {
-//      case '%' | '_' | '^' => b append '^' append c
-//      case _ => b append c
-//    }
-//    b.toString
-//  }
 }

src/main/twirl/gitbucket/core/account/main.scala.html

@@ -13,14 +13,14 @@
       </div>
       <div style="padding-left: 10px; padding-right: 10px;">
         @account.description.map{ description =>
-          <p style="color: white;">@description</p>
+          <p style="color: #999">@description</p>
         }
         @if(account.url.isDefined){
           <p style="white-space: nowrap; overflow: hidden; text-overflow: ellipsis;">
             <i class="octicon octicon-home"></i> <a href="@account.url">@account.url</a>
           </p>
         }
-        <p style="color: white;">
+        <p style="color: #999">
           <i class="octicon octicon-clock"></i> Joined on @helpers.date(account.registeredDate)
         </p>
       </div>

src/main/twirl/gitbucket/core/admin/dbviewer.scala.html

@@ -0,0 +1,95 @@
+@(tables: Seq[gitbucket.core.controller.Table])(implicit context: gitbucket.core.controller.Context)
+@import gitbucket.core.view.helpers
+@gitbucket.core.html.main("Database viewer") {
+  @gitbucket.core.admin.html.menu("dbviewer") {
+    <div class="container">
+      <div class="col-md-3">
+        <div id="table-tree">
+          <ul>
+          @tables.map { table =>
+            <li data-jstree='{"icon":"@context.path/assets/common/images/table.gif"}'><a href="javascript:void(0);" class="table-link">@table.name</a>
+              <ul>
+              @table.columns.map { column =>
+                <li data-jstree='{"icon":"@context.path/assets/common/images/column.gif"}'>@column.name
+                  @if(column.primaryKey){ (PK) }
+                </li>
+              }
+              </ul>
+            </li>
+          }
+          </ul>
+        </div>
+      </div>
+      <div class="col-md-9">
+        <div id="editor" style="width: 100%; height: 300px;"></div>
+        <div class="block">
+          <input type="button" value="Run query" id="run-query" class="btn btn-success">
+          <input type="button" value="Clear" id="clear-query" class="btn btn-default">
+        </div>
+        <div id="result"></div>
+      </div>
+    </div>
+  }
+}
+<script src="@helpers.assets("/vendors/ace/ace.js")" type="text/javascript" charset="utf-8"></script>
+<script src="@helpers.assets("/vendors/vakata-jstree-3.3.4/jstree.min.js")" type="text/javascript" charset="utf-8"></script>
+<link rel="stylesheet" href="@helpers.assets("/vendors/vakata-jstree-3.3.4/themes/default/style.min.css")" />
+<script>
+$(function(){
+  $('#editor').text($('#initial').val());
+  var editor = ace.edit("editor");
+  editor.setTheme("ace/theme/monokai");
+  editor.getSession().setMode("ace/mode/sql");
+
+  $('#table-tree').jstree();
+
+  $('.table-link').click(function(e){
+    if(editor.getValue().trim() == ''){
+      editor.getSession().insert(editor.getCursorPosition(), 'SELECT * FROM ' + $(e.target).text());
+    } else {
+      editor.getSession().insert(editor.getCursorPosition(), $(e.target).text());
+    }
+    editor.focus();
+  });
+
+  $('#clear-query').click(function(){
+    editor.setValue('');
+  });
+
+  $('#run-query').click(function(){
+    var selectedText = editor.getSession().doc.getTextRange(editor.selection.getRange()).trim();
+
+    $.post('@context.path/admin/dbviewer/_query', { query: selectedText == '' ? editor.getValue() : selectedText },
+      function(data){
+        if(data.type == "query"){
+          var table = $('<table class="table table-bordered table-hover table-scroll">');
+
+          var header = $('<tr>');
+          $.each(data.columns, function(i, column){
+            header.append($('<th>').text(column));
+          });
+          table.append($('<thead>').append(header));
+
+          var body = $('<tbody>');
+          $.each(data.rows, function(i, rs){
+            var row = $('<tr>');
+            $.each(data.columns, function(i, column){
+              row.append($('<td>').text(rs[column]));
+            });
+            body.append(row);
+          });
+
+          table.append(body);
+          $('#result').empty().append(table);
+
+        } else if(data.type == "update"){
+          $('#result').empty().append($('<span>').text('Updated ' + data.rows + ' rows.'));
+
+        } else if(data.type == "error"){
+          $('#result').empty().append($('<span class="error">').text(data.message));
+        }
+      }
+    );
+  });
+});
+</script>

src/main/twirl/gitbucket/core/admin/menu.scala.html

@@ -25,10 +25,10 @@
           <span>Data export / import</span>
         </a>
       </li>
-      <li class="menu-item-hover">
-        <a href="@context.path/console/login.jsp" target="_blank">
+      <li class="menu-item-hover @if(active=="dbviewer"){active}">
+        <a href="@context.path/admin/dbviewer">
           <i class="menu-icon octicon octicon-database"></i>
-          <span>H2 console</span>
+          <span>Database viewer</span>
         </a>
       </li>
       @gitbucket.core.plugin.PluginRegistry().getSystemSettingMenus.map { menu =>

src/main/twirl/gitbucket/core/admin/system.scala.html

@@ -1,6 +1,6 @@
 @(info: Option[Any])(implicit context: gitbucket.core.controller.Context)
+@import gitbucket.core.service.OpenIDConnectService
 @import gitbucket.core.util.DatabaseConfig
-@import gitbucket.core.view.helpers
 @gitbucket.core.html.main("System settings"){
   @gitbucket.core.admin.html.menu("system"){
     @gitbucket.core.helper.html.information(info)
@@ -287,6 +287,56 @@
               </div>
             </div>
           </div>
+          <fieldset>
+            <label class="checkbox">
+              <input type="checkbox" id="oidcAuthentication" name="oidcAuthentication"@if(context.settings.oidc){ checked} />
+              OpenID Connect
+            </label>
+          </fieldset>
+          <div class="oidc">
+            <div class="form-group">
+              <label class="control-label col-md-2" for="oidcIssuer">Issuer</label>
+              <div class="col-md-10">
+                <input type="text" id="oidcIssuer" name="oidc.issuer" class="form-control" value="@context.settings.oidc.map(_.issuer.getValue)"/>
+                <span id="error-oidc_issuer" class="error"></span>
+              </div>
+            </div>
+            <div class="form-group">
+              <label class="control-label col-md-2" for="oidcClientID">Client ID</label>
+              <div class="col-md-10">
+                <input type="text" id="oidcClientID" name="oidc.clientID" class="form-control" value="@context.settings.oidc.map(_.clientID.getValue)"/>
+                <span id="error-oidc_clientID" class="error"></span>
+              </div>
+            </div>
+            <div class="form-group">
+              <label class="control-label col-md-2" for="oidcClientID">Client secret</label>
+              <div class="col-md-10">
+                <input type="password" id="oidcClientSecret" name="oidc.clientSecret" class="form-control" value="@context.settings.oidc.map(_.clientSecret.getValue)"/>
+                <span id="error-oidc_clientSecret" class="error"></span>
+              </div>
+            </div>
+            <div class="form-group">
+              <label class="control-label col-md-2" for="oidcJwsAlgorithm">Expected signature</label>
+              <div class="col-md-10">
+                <select id="oidcJwsAlgorithm" name="oidc.jwsAlgorithm" class="form-control">
+                  <option value="" @if(context.settings.oidc.flatMap(_.jwsAlgorithm) == None){selected}>
+                    No signature
+                  </option>
+                  @OpenIDConnectService.JWS_ALGORITHMS.map { case (family, algorithms) =>
+                    <optgroup label="@family">
+                      @algorithms.map { algorithm =>
+                        <option value="@algorithm.getName" @if(context.settings.oidc.flatMap(_.jwsAlgorithm) == Some(algorithm)){selected}>
+                          @algorithm.getName
+                        </option>
+                      }
+                    </optgroup>
+                  }
+                </select>
+                <span class="muted">Choose the expected signature algorithm of the token response. Most IdP provides RS256 or HS256.</span>
+                <span id="error-oidc_jwsAlgorithm" class="error"></span>
+              </div>
+            </div>
+          </div>
           <!--====================================================================-->
           <!-- Notification email -->
           <!--====================================================================-->
@@ -456,5 +506,9 @@ $(function(){
   $('#ldapAuthentication').change(function(){
     $('.ldap input').prop('disabled', !$(this).prop('checked'));
   }).change();
+
+  $('#oidcAuthentication').change(function(){
+    $('.oidc input, .oidc select').prop('disabled', !$(this).prop('checked'));
+  }).change();
 });
 </script>

src/main/twirl/gitbucket/core/admin/userlist.scala.html

@@ -1,4 +1,4 @@
-@(users: List[gitbucket.core.model.Account], members: Map[String, List[String]], includeRemoved: Boolean)(implicit context: gitbucket.core.controller.Context)
+@(users: List[gitbucket.core.model.Account], members: Map[String, List[String]], includeRemoved: Boolean, includeGroups: Boolean)(implicit context: gitbucket.core.controller.Context)
 @import gitbucket.core.view.helpers
 @gitbucket.core.html.main("Manage Users"){
   @gitbucket.core.admin.html.menu("users"){
@@ -10,6 +10,10 @@
       <input type="checkbox" id="includeRemoved" name="includeRemoved" @if(includeRemoved){checked}/>
       Include removed users
     </label>
+    <label for="includeGroups">
+      <input type="checkbox" id="includeGroups" name="includeGroups" @if(includeGroups){checked}/>
+      Include group accounts
+    </label>
     <table class="table table-bordered table-hover">
       @users.map { account =>
         <tr>
@@ -63,8 +67,9 @@
 }
 <script>
 $(function(){
-  $('#includeRemoved').click(function(){
-    location.href = '@context.path/admin/users?includeRemoved=' + this.checked;
+  $('#includeRemoved,#includeGroups').click(function(){
+    location.href = '@context.path/admin/users?includeRemoved=' + $('#includeRemoved').prop('checked')
+      + '&includeGroups=' + $('#includeGroups').prop('checked');
   });
 });
 </script>

src/main/twirl/gitbucket/core/helper/activities.scala.html

@@ -14,6 +14,7 @@
         case "reopen_issue"      => detailActivity(activity, "issue-reopened")
         case "open_pullreq"      => detailActivity(activity, "git-pull-request")
         case "merge_pullreq"     => detailActivity(activity, "git-merge")
+        case "release"           => detailActivity(activity, "package")
         case "create_repository" => simpleActivity(activity, "repo")
         case "create_branch"     => simpleActivity(activity, "git-branch")
         case "delete_branch"     => simpleActivity(activity, "circle-slash")

src/main/twirl/gitbucket/core/helper/attached.scala.html

@@ -65,7 +65,7 @@ $(function(){
 }
 @dropzone(clickable: Boolean, textareaId: Option[String]) = {
   url: '@context.path/upload/file/@repository.owner/@repository.name',
-  maxFilesize: 10,
+  maxFilesize: @{FileUtil.MaxFileSize / 1024 / 1024},
   clickable: @clickable,
   previewTemplate: "<div class=\"dz-preview\">\n  <div class=\"dz-progress\"><span class=\"dz-upload\" data-dz-uploadprogress>Uploading your files...</span></div>\n  <div class=\"dz-error-message\"><span data-dz-errormessage></span></div>\n</div>",
   success: function(file, id) {

src/main/twirl/gitbucket/core/issues/commentform.scala.html

@@ -22,12 +22,23 @@
           elastic            = true,
           tabIndex           = 1
         )
-        <div class="text-right">
-          <input type="hidden" name="issueId" value="@issue.issueId"/>
-          @if((reopenable || !issue.closed) && (isManageable || issue.openedUserName == context.loginAccount.get.userName)){
-            <input type="submit" class="btn btn-default" tabindex="3" formaction="@helpers.url(repository)/issue_comments/state" value="@{if(issue.closed) "Reopen" else "Close"}" id="action"/>
-          }
-          <input type="submit" class="btn btn-success" tabindex="2" formaction="@helpers.url(repository)/issue_comments/new" value="Comment"/>
+          <div class="text-right">
+            <input type="hidden" name="issueId" value="@issue.issueId"/>
+            @if((reopenable || !issue.closed) && (isManageable || issue.openedUserName == context.loginAccount.get.userName)){
+              <input type="hidden" id="action" name="action" value="comment"/>
+              <div class="btn-group dropup">
+                <input type="submit" class="btn btn-success" tabindex="2" formaction="@helpers.url(repository)/issue_comments/new" value="Comment" id="submit-button"/>
+                <button type="button" class="btn btn-success dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+                  <span class="caret"></span>
+                </button>
+              <ul class="dropdown-menu dropdown-menu-right">
+                <li><a id="menu-comment">Comment</a></li>
+                <li><a id="menu-x-and-comment">@{if(issue.closed) "Reopen" else "Close"} and comment</a></li>
+              </ul>
+              </div>
+            } else {
+              <input type="submit" class="btn btn-success" tabindex="2" formaction="@helpers.url(repository)/issue_comments/new" value="Comment"/>
+            }
         </div>
       </div>
     </div>
@@ -35,8 +46,13 @@
 }
 <script>
 $(function(){
-  $('#action').click(function(){
-    $('<input type="hidden">').attr('name', 'action').val($(this).val().toLowerCase()).appendTo('form');
+  $('#menu-comment').click(function(){
+    $('#submit-button').attr('value', 'Comment').attr('formaction', '@helpers.url(repository)/issue_comments/new');
+    $('#action').val('comment');
+  });
+  $('#menu-x-and-comment').click(function(){
+    $('#submit-button').attr('value', '@{if(issue.closed) "Reopen" else "Close"} and comment').attr('formaction', '@helpers.url(repository)/issue_comments/state');
+    $('#action').val('@{if(issue.closed) "reopen" else "close"}');
   });
 });
 </script>

src/main/twirl/gitbucket/core/main.scala.html

@@ -121,9 +121,11 @@
     </div>
     <script>
       $(function(){
+        @*
         $('#search').submit(function(){
           return $.trim($(this).find('input[name=query]').val()) != '';
         });
+        *@
         @if(body.toString.contains("main-sidebar")){
           $(".sidebar-toggle").on('click', function(e){
             $.post('@context.path/sidebar-collapse', { collapse: !$('body').hasClass('sidebar-collapse') });

src/main/twirl/gitbucket/core/menu.scala.html

@@ -33,8 +33,8 @@
       @menuitem("", "files", "Files", "code")
       @if(repository.branchList.nonEmpty) {
         @menuitem("/branches", "branches", "Branches", "git-branch", repository.branchList.length)
-        @menuitem("/tags", "tags", "Tags", "tag", repository.tags.length)
       }
+      @menuitem("/releases", "releases", "Releases", "tag", repository.tags.length)
       @if(repository.repository.options.issuesOption != "DISABLE") {
         @menuitem("/issues", "issues", "Issues", "issue-opened", repository.issueCount)
         @menuitem("/pulls", "pulls", "Pull requests", "git-pull-request", repository.pullCount)

src/main/twirl/gitbucket/core/releases/form.scala.html

@@ -0,0 +1,78 @@
+@(repository: gitbucket.core.service.RepositoryService.RepositoryInfo,
+  tag: String,
+  release: Option[(gitbucket.core.model.Release, Seq[gitbucket.core.model.ReleaseAsset])])(implicit context: gitbucket.core.controller.Context)
+@import gitbucket.core.view.helpers
+@gitbucket.core.html.main(s"New Release - ${repository.owner}/${repository.name}", Some(repository)){
+  @gitbucket.core.html.menu("releases", repository){
+    <form action="@helpers.url(repository)/releases/@helpers.encodeRefName(tag)/@if(release.isEmpty){create}else{edit}" method="POST" validate="true" class="form-group">
+      <div class="row-fluid">
+        <div class="co`l-md-12">
+          @if(release.isEmpty){
+            <h3>New release for @tag</h3>
+          } else {
+            <h3>Update release for @tag</h3>
+          }
+          <span id="error-name" class="error"></span>
+          <input type="text" id="release-name" name="name" class="form-control" value="@release.map { case (release, _) => @release.name }.getOrElse(tag)" placeholder="Title" style="margin-bottom: 6px;" autofocus/>
+          @gitbucket.core.helper.html.preview(
+            repository         = repository,
+            content            = release.flatMap { case (release, _) => release.content }.getOrElse(""),
+            enableWikiLink     = false,
+            enableRefsLink     = true,
+            enableLineBreaks   = true,
+            enableTaskList     = true,
+            hasWritePermission = true,
+            completionContext  = "releases",
+            style              = "height: 200px; max-height: 500px;",
+            elastic            = true,
+            placeholder        = "Describe this release"
+          )
+          <ul id="assets-list" class="collaborator">
+            @release.map { case (release, assets) =>
+              @assets.map { asset =>
+                <li>
+                  <a href="@context.baseUrl/@repository.owner/@repository.name/_release/@helpers.encodeRefName(tag)/@asset.fileName"><i class="octicon octicon-file"></i>@asset.label</a>
+                  <a href="#" class="remove pull-right" style="padding-top: 0px;">(remove)</a>
+                  <input type="hidden" name="file:@asset.fileName" value="@asset.label"/>
+                </li>
+              }
+            }
+          </ul>
+          <div style="border: 1px dashed #ccc; color: gray; background-color: #eee; padding: 4px;">
+            <div id="drop" class="clickable">Attach release files by dragging &amp; dropping, or selecting them.</div>
+          </div>
+          <div class="align-right" style="margin-top: 12px;">
+            @if(release.isEmpty){
+              <input type="submit" class="btn btn-success" value="Submit new release"/>
+            } else {
+              <input type="submit" class="btn btn-success" value="Update release"/>
+            }
+          </div>
+        </div>
+      </div>
+    </form>
+  }
+}
+<script>
+$(function(){
+  $(document).on('click', '.remove', function(){
+    $(this).parent().remove();
+  });
+
+  $("#drop").dropzone({
+    maxFilesize: @{gitbucket.core.util.FileUtil.MaxFileSize / 1024 / 1024},
+    url: '@context.path/upload/release/@repository.owner/@repository.name/@helpers.encodeRefName(tag)',
+    previewTemplate: "<div class=\"dz-preview\">\n  <div class=\"dz-progress\"><span class=\"dz-upload\" data-dz-uploadprogress>Uploading your files...</span></div>\n  <div class=\"dz-error-message\"><span data-dz-errormessage></span></div>\n</div>",
+    success: function(file, id) {
+      var attach =
+        '<li><a href="@context.baseUrl/@repository.owner/@repository.name/_release/@helpers.encodeRefName(tag)/' + id + '">' +
+        '<i class="octicon octicon-file"></i>' + escapeHtml(file.name) + '</a>' +
+        '<a href="#" class="remove pull-right" style="padding-top: 0px;">(remove)</a>' +
+        '<input type="hidden" name="file:' + id + '" value="' + escapeHtml(file.name) + '"/>'
+        '</li>';
+      $('#assets-list').append(attach);
+      $(file.previewElement).prevAll('div.dz-preview').addBack().remove();
+    }
+  });
+});
+</script>

src/main/twirl/gitbucket/core/releases/list.scala.html

@@ -0,0 +1,64 @@
+@(repository: gitbucket.core.service.RepositoryService.RepositoryInfo,
+  releases: Seq[(gitbucket.core.util.JGitUtil.TagInfo, Option[(gitbucket.core.model.Release, Seq[gitbucket.core.model.ReleaseAsset])])],
+  hasWritePermission: Boolean)(implicit context: gitbucket.core.controller.Context)
+@import gitbucket.core.view.helpers
+@gitbucket.core.html.main("Releases" + s" - ${repository.owner}/${repository.name}", Some(repository)){
+  @gitbucket.core.html.menu("releases", repository){
+    <table class="table table-bordered table-releases">
+      <thead>
+        <tr><th>@releases.length releases</th></tr>
+      </thead>
+      <tbody>
+      @releases.map { case (tag, release) =>
+        <tr>
+          <td>
+            <div class="col-md-2 text-right">
+              <a href="@helpers.url(repository)/tree/@helpers.encodeRefName(tag.name)" class="strong"><i class="octicon octicon-tag"></i>@tag.name</a><br>
+              <a href="@helpers.url(repository)/commit/@tag.id" class="monospace muted"><i class="octicon octicon-git-commit"></i>@tag.id.substring(0, 7)</a><br>
+              <span class="muted">@gitbucket.core.helper.html.datetimeago(tag.time)</span>
+            </div>
+            <div class="col-md-10" style="border-left: 1px solid #eee">
+              <div class="release-note markdown-body">
+                @release.map { case (release, assets) =>
+                  <h3><a href="@helpers.url(repository)/releases/@release.tag">@release.name</a></h3>
+                  <p class="muted">
+                    @helpers.avatar(release.author, 20) @helpers.user(release.author, styleClass="username") released this @gitbucket.core.helper.html.datetimeago(release.registeredDate)
+                  </p>
+                  @helpers.markdown(
+                    markdown           = release.content getOrElse "No description provided.",
+                    repository         = repository,
+                    enableWikiLink     = false,
+                    enableRefsLink     = true,
+                    enableLineBreaks   = true,
+                    enableTaskList     = true,
+                    hasWritePermission = hasWritePermission
+                  )
+                }.getOrElse {
+                  @if(hasWritePermission){
+                    <div class="pull-right">
+                      <a class="btn btn-success" href="@helpers.url(repository)/releases/@{helpers.encodeRefName(tag.name)}/create" id="edit">Create release</a>
+                    </div>
+                  }
+                }
+                <h4>Downloads</h4>
+                <ul style="list-style: none; padding-left: 8px;">
+                  @release.map { case (release, assets) =>
+                    @assets.map { asset =>
+                      <li>
+                        <i class="octicon octicon-file"></i><a href="@helpers.url(repository)/releases/@release.tag/assets/@asset.fileName">@asset.label</a>
+                        <span class="label label-default">@helpers.readableSize(Some(asset.size))</span>
+                      </li>
+                    }
+                  }
+                  <li><a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(tag.name)}.zip"><i class="octicon octicon-file-zip"></i>Source code (zip)</a></li>
+                  <li><a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(tag.name)}.tar.gz"><i class="octicon octicon-file-zip"></i>Source code (tar.gz)</a></li>
+                </ul>
+              </div>
+            </div>
+          </td>
+        </tr>
+      }
+      </tbody>
+    </table>
+  }
+}

src/main/twirl/gitbucket/core/releases/release.scala.html

@@ -0,0 +1,65 @@
+@(release: gitbucket.core.model.Release,
+  assets: Seq[gitbucket.core.model.ReleaseAsset],
+  hasWritePermission: Boolean,
+  repository: gitbucket.core.service.RepositoryService.RepositoryInfo)(implicit context: gitbucket.core.controller.Context)
+@import gitbucket.core.view.helpers
+@gitbucket.core.html.main(s"Release ${release.name} - ${repository.owner}/${repository.name}", Some(repository)){
+  @gitbucket.core.html.menu("releases", repository){
+    <div class="row">
+      <div class="col-md-2 text-right">
+        @defining(repository.tags.find(_.name == release.tag)){ tag =>
+          @tag.map { tag =>
+            <a href="@helpers.url(repository)/tree/@helpers.encodeRefName(tag.name)" class="strong"><i class="octicon octicon-tag"></i>@tag.name</a><br>
+            <a href="@helpers.url(repository)/commit/@tag.id" class="monospace muted"><i class="octicon octicon-git-commit"></i>@tag.id.substring(0, 7)</a><br>
+            <span class="muted">@gitbucket.core.helper.html.datetimeago(tag.time)</span>
+          }
+        }
+      </div>
+      <div class="col-md-10" style="border-left: 1px solid #eee">
+        <div class="markdown-body">
+          <h3>
+            @release.name
+            @if(hasWritePermission){
+              <div class="pull-right">
+                <form method="POST" action="@helpers.url(repository)/releases/@release.tag/delete" id="delete-form">
+                  <a class="btn btn-default" href="@helpers.url(repository)/releases/@release.tag/edit" id="edit">Edit</a>
+                  <input type="submit" class="btn btn-danger" value="Delete">
+                </form>
+              </div>
+            }
+          </h3>
+          <p class="muted">
+           @helpers.avatar(release.author, 20) @helpers.user(release.author, styleClass="username") released this @gitbucket.core.helper.html.datetimeago(release.registeredDate)
+          </p>
+          @helpers.markdown(
+            markdown           = release.content getOrElse "No description provided.",
+            repository         = repository,
+            enableWikiLink     = false,
+            enableRefsLink     = true,
+            enableLineBreaks   = true,
+            enableTaskList     = true,
+            hasWritePermission = hasWritePermission
+          )
+          <h4>Downloads</h4>
+          <ul style="list-style: none; padding-left: 8px;" id="attachedFiles">
+            @assets.map{ asset =>
+              <li>
+                <i class="octicon octicon-file"></i><a href="@helpers.url(repository)/releases/@release.tag/assets/@asset.fileName">@asset.label</a>
+                <span class="label label-default">@helpers.readableSize(Some(asset.size))</span>
+              </li>
+            }
+            <li><a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(release.tag)}.zip"><i class="octicon octicon-file-zip"></i>Source code (zip)</a></li>
+            <li><a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(release.tag)}.tar.gz"><i class="octicon octicon-file-zip"></i>Source code (tar.gz)</a></li>
+          </ul>
+        </div>
+      </div>
+    </div>
+  }
+}
+<script>
+$(function(){
+  $('#delete-form').submit(function(){
+    return confirm('Are you sure you want to delete this release?');
+  });
+});
+</script>

src/main/twirl/gitbucket/core/repo/blob.scala.html

@@ -214,6 +214,9 @@ $(window).on('load', function(){
     });
     return false;
   };
+  $(document).on('expanded.pushMenu collapsed.pushMenu', function(e){
+    setTimeout(updateBlame, 300);
+  });
   updateBlame();
 });
 

src/main/twirl/gitbucket/core/repo/creating.scala.html

@@ -22,7 +22,6 @@
 
   function checkCreating() {
     $.get('@context.path/@owner/@repository/creating', function (data) {
-      console.log(data);
       if (data.creating == true) {
         setTimeout(checkCreating, 2000);
       } else {
@@ -31,9 +30,7 @@
           $('#error').show();
           $('#progress').hide();
         } else {
-          setTimeout(function(){
-            location.href = '@context.path/@owner/@repository';
-          }, 2000);
+          setTimeout(function(){ location.href = '@context.path/@owner/@repository'; });
         }
       }
     });

src/main/twirl/gitbucket/core/repo/tags.scala.html

@@ -1,29 +0,0 @@
-@(repository: gitbucket.core.service.RepositoryService.RepositoryInfo)(implicit context: gitbucket.core.controller.Context)
-@import gitbucket.core.view.helpers
-@gitbucket.core.html.main(s"${repository.owner}/${repository.name}", Some(repository)) {
-  @gitbucket.core.html.menu("tags", repository){
-    <table class="table table-bordered">
-      <thead>
-        <tr>
-          <th width="40%">Tag</th>
-          <th width="20%">Date</th>
-          <th width="20%">Commit</th>
-          <th width="20%">Download</th>
-        </tr>
-      </thead>
-      <tbody>
-        @repository.tags.reverseMap { tag =>
-          <tr>
-            <td><a href="@helpers.url(repository)/tree/@helpers.encodeRefName(tag.name)">@tag.name</a></td>
-            <td>@gitbucket.core.helper.html.datetimeago(tag.time, false)</td>
-            <td class="monospace"><a href="@helpers.url(repository)/commit/@tag.id">@tag.id.substring(0, 10)</a></td>
-            <td>
-                <a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(tag.name)}.zip">ZIP</a>
-                <a href="@helpers.url(repository)/archive/@{helpers.encodeRefName(tag.name)}.tar.gz">TAR.GZ</a>
-            </td>
-          </tr>
-        }
-      </tbody>
-    </table>
-  }
-}

src/main/twirl/gitbucket/core/signinform.scala.html

@@ -4,6 +4,15 @@
 <div class="panel panel-default">
   <div class="panel-heading strong">Sign in</div>
   <ul class="list-group list-group-flush">
+    @if(context.settings.oidcAuthentication){
+      <li class="list-group-item">
+        <form action="@context.path/signin/oidc" method="POST">
+          <input type="hidden" name="hash"/>
+          <input type="submit" class="btn btn-success" value="Sign in with OpenID Connect"
+          onClick="this.form.hash.value = window.location.hash;"/>
+        </form>
+      </li>
+    }
     <li class="list-group-item">
       <form action="@context.path/signin" method="POST" validate="true">
         <div class="form-group">

src/main/webapp/WEB-INF/web.xml

@@ -40,7 +40,7 @@
     <servlet-name>GitRepositoryServlet</servlet-name>
     <servlet-class>gitbucket.core.servlet.GitRepositoryServlet</servlet-class>
   </servlet>
-  
+
   <servlet-mapping>
     <servlet-name>GitRepositoryServlet</servlet-name>
     <url-pattern>/git/*</url-pattern>
@@ -70,30 +70,6 @@
     <url-pattern>/plugin-assets/*</url-pattern>
   </servlet-mapping>
 
-  <!-- ===================================================================== -->
-  <!-- H2 console configuration -->
-  <!-- ===================================================================== -->
-  <servlet>
-    <servlet-name>H2Console</servlet-name>
-    <servlet-class>org.h2.server.web.WebServlet</servlet-class>
-    <init-param>
-        <param-name>webAllowOthers</param-name>
-        <param-value></param-value>
-    </init-param>
-      <!--
-      <init-param>
-          <param-name>trace</param-name>
-          <param-value></param-value>
-      </init-param>
-      -->
-    <load-on-startup>1</load-on-startup>
-  </servlet>
-  
-  <servlet-mapping>
-    <servlet-name>H2Console</servlet-name>
-    <url-pattern>/console/*</url-pattern>
-  </servlet-mapping>
-
   <!-- ===================================================================== -->
   <!-- Session timeout -->
   <!-- ===================================================================== -->

src/main/webapp/assets/common/css/gitbucket.css

@@ -124,6 +124,12 @@ div.content-wrapper {
   background-color: white;
 }
 
+.table-scroll {
+  display: block;
+  position: relative;
+  overflow: scroll;
+}
+
 /* ======================================================================== */
 /* Global Header */
 /* ======================================================================== */

src/main/webapp/assets/common/js/gitbucket.js

@@ -351,12 +351,12 @@ function scrollIntoView(target){
   }
 }
 
-///**
-// * escape html
-// */
-//function escapeHtml(text){
-//  return text.replace(/&/g,'&amp;').replace(/</g,'&lt;').replace(/"/g,'&quot;').replace(/>/g,'&gt;');
-//}
+/**
+* escape html
+*/
+function escapeHtml(text){
+ return text.replace(/&/g,'&amp;').replace(/</g,'&lt;').replace(/"/g,'&quot;').replace(/>/g,'&gt;');
+}
 
 /**
  * calculate string ranking for path.

src/test/scala/gitbucket/core/api/JsonFormatSpec.scala

@@ -265,6 +265,7 @@ class JsonFormatSpec extends FunSuite {
 
   val apiPullRequest = ApiPullRequest(
     number        = 1347,
+    state         = "open",
     updated_at    = date1,
     created_at    = date1,
     head          = ApiPullRequest.Commit(
@@ -287,6 +288,7 @@ class JsonFormatSpec extends FunSuite {
 
   val apiPullRequestJson = s"""{
     "number": 1347,
+    "state" : "open",
     "updated_at": "2011-04-14T16:00:49Z",
     "created_at": "2011-04-14T16:00:49Z",
   //  "closed_at": "2011-04-14T16:00:49Z",

src/test/scala/gitbucket/core/service/AccountFederationServiceSpec.scala

@@ -0,0 +1,94 @@
+package gitbucket.core.service
+
+import org.scalatest.FunSpec
+
+class AccountFederationServiceSpec extends FunSpec with ServiceSpecBase {
+
+  describe("getOrCreateFederatedUser") {
+    it("should create a federated account if it does not exist") {
+      withTestDB { implicit session =>
+        val actual = AccountFederationService.getOrCreateFederatedUser("someIssuer", "someSubject", "dummy@example.com", Some("foo"), Some("Foo"))
+        assert(actual.get.userName == "foo")
+        assert(actual.get.password == "")
+        assert(actual.get.fullName == "Foo")
+        assert(actual.get.mailAddress == "dummy@example.com")
+        assert(!actual.get.isAdmin)
+        assert(!actual.get.isGroupAccount)
+        assert(!actual.get.isRemoved)
+      }
+    }
+    it("should return the federated account") {
+      withTestDB { implicit session =>
+        generateNewAccount("someUser")
+        AccountFederationService.createAccountFederation("someIssuer", "someSubject", "someUser")
+
+        val actual = AccountFederationService.getOrCreateFederatedUser("someIssuer", "someSubject", "dummy@example.com", Some("dummy"), Some("dummy"))
+        assert(actual.get.userName == "someUser")
+      }
+    }
+    it("should return None if the federated account is disabled") {
+      withTestDB { implicit session =>
+        val user = generateNewAccount("someUser")
+        AccountFederationService.createAccountFederation("someIssuer", "someSubject", "someUser")
+        AccountService.updateAccount(user.copy(isRemoved = true))
+
+        val actual = AccountFederationService.getOrCreateFederatedUser("someIssuer", "someSubject", "dummy@example.com", Some("dummy"), Some("dummy"))
+        assert(actual.isEmpty)
+      }
+    }
+  }
+
+  describe("getAccountByFederation") {
+    it("should return the federated account") {
+      withTestDB { implicit session =>
+        generateNewAccount("someUser")
+        AccountFederationService.createAccountFederation("someIssuer", "someSubject", "someUser")
+
+        val actual = AccountFederationService.getAccountByFederation("someIssuer", "someSubject")
+        assert(actual.get.userName == "someUser")
+      }
+    }
+    it("should return the federated account regardless of disabled") {
+      withTestDB { implicit session =>
+        val user = generateNewAccount("someUser")
+        AccountFederationService.createAccountFederation("someIssuer", "someSubject", "someUser")
+        AccountService.updateAccount(user.copy(isRemoved = true))
+
+        val actual = AccountFederationService.getAccountByFederation("someIssuer", "someSubject")
+        assert(actual.get.userName == "someUser")
+      }
+    }
+    it("should return None if the issuer and the subject did not match") {
+      withTestDB { implicit session =>
+        val actual = AccountFederationService.getAccountByFederation("someIssuer", "anotherSubject")
+        assert(actual.isEmpty)
+      }
+    }
+  }
+
+  describe("findAvailableUserName") {
+    it("should return the preferredUserName if it is available") {
+      withTestDB { implicit session =>
+        assert(AccountFederationService.findAvailableUserName(Some("foo"), "dummy@example.com").contains("foo"))
+      }
+    }
+    it("should return guessed username if only email is given") {
+      withTestDB { implicit session =>
+        assert(AccountFederationService.findAvailableUserName(None, "bar@example.com").contains("bar"))
+      }
+    }
+    it("should return None if the preferredUserName is already taken") {
+      withTestDB { implicit session =>
+        generateNewAccount("foo")
+        assert(AccountFederationService.findAvailableUserName(Some("foo"), "dummy@example.com").isEmpty)
+      }
+    }
+    it("should return None if guessed username is already taken") {
+      withTestDB { implicit session =>
+        generateNewAccount("bar")
+        assert(AccountFederationService.findAvailableUserName(None, "bar@example.com").isEmpty)
+      }
+    }
+  }
+
+}

src/test/scala/gitbucket/core/util/StringUtilSpec.scala

@@ -63,4 +63,24 @@ class StringUtilSpec extends FunSpec {
       assert(StringUtil.extractCloseId("(refs #123)").toSeq == Nil)
     }
   }
+
+  describe("getRepositoryViewerUrl") {
+    val baseUrl = Some("http://localhost:8080")
+    it("should convert GitBucket repository url"){
+      assert(StringUtil.getRepositoryViewerUrl("http://localhost:8080/git/root/gitbucket.git", baseUrl) == "http://localhost:8080/root/gitbucket")
+      assert(StringUtil.getRepositoryViewerUrl("http://root@localhost:8080/git/root/gitbucket.git", baseUrl) == "http://localhost:8080/root/gitbucket")
+    }
+    it("should convert GitHub repository url"){
+      assert(StringUtil.getRepositoryViewerUrl("https://github.com/root/gitbucket.git", baseUrl) == "https://github.com/root/gitbucket")
+      assert(StringUtil.getRepositoryViewerUrl("https://root@github.com/root/gitbucket.git", baseUrl) == "https://github.com/root/gitbucket")
+    }
+    it("should convert BitBucket repository url"){
+      assert(StringUtil.getRepositoryViewerUrl("https://bitbucket.org/root/gitbucket.git", baseUrl) == "https://bitbucket.org/root/gitbucket")
+      assert(StringUtil.getRepositoryViewerUrl("https://root@bitbucket.org/root/gitbucket.git", baseUrl) == "https://bitbucket.org/root/gitbucket")
+    }
+    it("should convert GitLab repository url"){
+      assert(StringUtil.getRepositoryViewerUrl("https://gitlab.com/root/gitbucket.git", baseUrl) == "https://gitlab.com/root/gitbucket")
+      assert(StringUtil.getRepositoryViewerUrl("https://root@gitlab.com/root/gitbucket.git", baseUrl) == "https://gitlab.com/root/gitbucket")
+    }
+  }
 }

src/test/scala/gitbucket/core/view/AvatarImageProviderSpec.scala

@@ -2,17 +2,16 @@ package gitbucket.core.view
 
 import java.text.SimpleDateFormat
 import java.util.Date
-
-import gitbucket.core.model.Account
-import gitbucket.core.service.{RequestCache, SystemSettingsService}
-import gitbucket.core.controller.Context
-import SystemSettingsService.SystemSettings
 import javax.servlet.http.{HttpServletRequest, HttpSession}
 
-import play.twirl.api.Html
+import gitbucket.core.controller.Context
+import gitbucket.core.model.Account
+import gitbucket.core.service.RequestCache
+import gitbucket.core.service.SystemSettingsService.SystemSettings
+import org.mockito.Mockito._
 import org.scalatest.FunSpec
 import org.scalatest.mockito.MockitoSugar
-import org.mockito.Mockito._
+import play.twirl.api.Html
 
 
 class AvatarImageProviderSpec extends FunSpec with MockitoSugar {
@@ -119,6 +118,8 @@ class AvatarImageProviderSpec extends FunSpec with MockitoSugar {
       smtp                     = None,
       ldapAuthentication       = false,
       ldap                     = None,
+      oidcAuthentication       = false,
+      oidc                     = None,
       skinName                 = "skin-blue"
     )