Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2026-02-10 16:47:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #697 from banjun/fix-basicauth-for-public-repo

Browse Source 
let non-anonymous user read access to public repos with basic auth
This commit is contained in:
Naoki Takezoe
2015-04-16 02:13:33 +09:00
parent 2ea31d6869 93e7b604cd
commit f027ac34d4
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/scala/gitbucket/core/servlet/BasicAuthenticationFilter.scala
View File

@@ -43,12 +43,16 @@ class BasicAuthenticationFilter extends Filter with RepositoryService with Accou
case auth => decodeAuthHeader(auth).split(":", 2) match {
case Array(username, password) => {
authenticate(settings, username, password) match {
case Some(account) if (isUpdating || repository.repository.isPrivate) => {
if(hasWritePermission(repository.owner, repository.name, Some(account))){
request.setAttribute(Keys.Request.UserName, account.userName)
chain.doFilter(req, wrappedResponse)
case Some(account) => {
if (isUpdating || repository.repository.isPrivate) {
if(hasWritePermission(repository.owner, repository.name, Some(account))){
request.setAttribute(Keys.Request.UserName, account.userName)
chain.doFilter(req, wrappedResponse)
} else {
requireAuth(response)
}
} else {
requireAuth(response)
chain.doFilter(req, wrappedResponse)
}
}
case _ => requireAuth(response)