(Fixes #2400) Fix edit group button's display condition (#2401)

This commit is contained in:
Naoki Takezoe
2019-11-16 21:00:22 +09:00
committed by GitHub
parent f35ecce3c7
commit 94f9d42fc4

View File

@@ -255,12 +255,7 @@ trait AccountControllerBase extends AccountManagementControllerBase {
account,
members,
extraMailAddresses,
context.loginAccount.exists(
x =>
members.exists { member =>
member.userName == x.userName && member.isManager
}
)
isGroupManager(context.loginAccount, members)
)
}
@@ -272,12 +267,7 @@ trait AccountControllerBase extends AccountManagementControllerBase {
if (account.isGroupAccount) Nil else getGroupsByUserName(userName),
getVisibleRepositories(context.loginAccount, Some(userName)),
extraMailAddresses,
context.loginAccount.exists(
x =>
members.exists { member =>
member.userName == x.userName && member.isManager
}
)
isGroupManager(context.loginAccount, members)
)
}
}
@@ -822,4 +812,13 @@ trait AccountControllerBase extends AccountManagementControllerBase {
}
}
}
private def isGroupManager(account: Option[Account], members: Seq[GroupMember]): Boolean = {
account.exists { account =>
account.isAdmin || members.exists { member =>
member.userName == account.userName && member.isManager
}
}
}
}