Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2026-05-07 03:26:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Milestone title should be unique #2256 (#2327)

Browse Source
This commit is contained in:
Joobi S B
2019-06-22 12:13:11 +05:30
committed by Naoki Takezoe
parent 169e2f16fb
commit 0eef0f9aa5
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/main/scala/gitbucket/core/controller/MilestonesController.scala
View File

@@ -1,10 +1,12 @@
package gitbucket.core.controller
import gitbucket.core.issues.milestones.html
import gitbucket.core.service.{RepositoryService, MilestonesService, AccountService}
import gitbucket.core.util.{ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.service.{AccountService, MilestonesService, RepositoryService}
import gitbucket.core.util.Implicits._
import gitbucket.core.util.{ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.util.SyntaxSugars._
import org.scalatra.forms._
import org.scalatra.i18n.Messages
class MilestonesController
extends MilestonesControllerBase
@@ -20,7 +22,7 @@ trait MilestonesControllerBase extends ControllerBase {
case class MilestoneForm(title: String, description: Option[String], dueDate: Option[java.util.Date])
val milestoneForm = mapping(
"title" -> trim(label("Title", text(required, maxlength(100)))),
"title" -> trim(label("Title", text(required, maxlength(100), uniqueMilestone))),
"description" -> trim(label("Description", optional(text()))),
"dueDate" -> trim(label("Due Date", optional(date())))
)(MilestoneForm.apply)
@@ -86,4 +88,20 @@ trait MilestonesControllerBase extends ControllerBase {
} getOrElse NotFound()
})
private def uniqueMilestone: Constraint = new Constraint() {
override def validate(
name: String,
value: String,
params: Map[String, Seq[String]],
messages: Messages
): Option[String] = {
for {
owner <- params.optionValue("owner")
repository <- params.optionValue("repository")
_ <- getMilestones(owner, repository).find(_.title.equalsIgnoreCase(value))
} yield {
"Milestone already exists."
}
}
}
}