Nemcio/CyberPanel
1
0
Fork 0
mirror of https://github.com/usmannasir/cyberpanel.git synced 2026-06-13 01:10:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): Improve removeFromSettings and removeFromURLs precision

Browse Source 
- Use more precise string matching to avoid partial matches
- removeFromSettings: Match plugin name in quotes within INSTALLED_APPS context
- removeFromURLs: Match plugin name in path() and include() patterns
- Prevents false positives (e.g., 'pluginName2' matching 'pluginName')

This ensures uninstall only removes the exact plugin, not similar names.
This commit is contained in:
master3395
2026-01-26 03:27:49 +01:00
parent 0c140ed69d
commit c9c4d521f8
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pluginInstaller/pluginInstaller.py
View File

@@ -389,7 +389,9 @@ class pluginInstaller:
writeToFile = open("/usr/local/CyberCP/CyberCP/settings.py", 'w', encoding='utf-8')
for items in data:
if items.find(pluginName) > -1:
# More precise matching: look for plugin name in quotes (e.g., 'pluginName' or "pluginName")
# This prevents partial matches (e.g., 'pluginName2' matching 'pluginName')
if (f"'{pluginName}'" in items or f'"{pluginName}"' in items) and 'INSTALLED_APPS' in ''.join(data[max(0, data.index(items)-5):data.index(items)+5]):
continue
else:
writeToFile.writelines(items)
@@ -401,7 +403,11 @@ class pluginInstaller:
writeToFile = open("/usr/local/CyberCP/CyberCP/urls.py", 'w', encoding='utf-8')
for items in data:
if items.find(pluginName) > -1:
# More precise matching: look for plugin name in path() or include() calls
# Match patterns like: path('plugins/pluginName/', include('pluginName.urls'))
# This prevents partial matches
if (f"plugins/{pluginName}/" in items or f"'{pluginName}.urls'" in items or f'"{pluginName}.urls"' in items or
f"include('{pluginName}.urls')" in items or f'include("{pluginName}.urls")' in items):
continue
else:
writeToFile.writelines(items)