Commit Graph

303 Commits

Author SHA1 Message Date
Mikael Korpela
f44c9bce71 fix(eslint): Inconsistent spacing before function parentheses (#1844)
Defines `space-before-function-paren` eslint rule and changes files accordingly.
2017-08-14 23:50:33 +03:00
Michael Leanos
eb9cdd784c feat(config): Mongo Seed 2.0 (#1808)
feat(config): Mongo Seed 2.0

Adds a more configurable and easily extended MongoDB Seed feature.

Adds additional options at the collection, and collection item level to
allow more control over how each environment config handles the seeding
feature.

Enforces seed order based on the order of the  environment's seeding configuration object.

Removes the previous SeedDB config file.

Adds chalk to messages logged to the console for readability.

Refactors the Mongo Seed configuration tests.

Adds Gulp tasks to perform Mongo Seed operations for default, prod, and
test environment configurations. Also, adds accommodating npm scripts.
2017-08-13 16:29:47 -07:00
Mikael Korpela
be88a2ca1f fix(users): don't fail on missing old image on image upload (#1839)
Fixes scenarios where previously when old image file would be missing, uploading new image file over it would fail because unlinking previous file fails.
2017-08-13 21:52:38 +03:00
Pierre Brisorgueil
c69644db65 feat(core): Enhancement page title directive (#1686)
* fix(users): test for usernameOrEmail

* Add comment to remind  change for mongo replicaset connection

* clean comment ..

* Generic pageTitle concept

* Revert "Generic pageTitle concept"

This reverts commit ff00ec950f085ca3b6d1abb564eab1965ab0a56e.

* align on meanjs state

* fix atom beautify newline

* align to mean indent

* pageTitle directive

automatic pageTitle directive

fix loads add ..

clean lodash dependencies

clean code

clean code & indent

clean lodash

* pageTitle directive

automatic pageTitle directive

fix loads add ..

clean lodash dependencies

clean code

clean code & indent

clean lodash
2017-08-09 22:47:01 -07:00
Mikael Korpela
f65d4b90ca feat(user): Add email support to forgot password (#1834)
Adds support for recovering users account using email and username.

Previously only username worked.
2017-08-07 16:38:48 +03:00
Dale Lotts
6021c145f9 refactor(menus): Refactor to the Menus client service to use functional loops/filters (#1575)
The for loops, expecially the nested for loops, over array elements with variable names contianing

'index' made the code incomprehensible.
2017-07-29 15:35:43 -07:00
Michael Leanos
dc880eb5a7 feat(config): Mongoose 4.11 upgrade (#1818)
Upgrades Mongoose to 4.11.1

Updates Mongoose connection implementation to accommodate deprecated
features & connection options.

Also, updates the Gulp Mocha tasks to reflect changes to the Mongoose
implementation.

Fixes tests to get the database from the existing Mongoose singleton.

Derives from changes in https://github.com/meanjs/mean/pull/1816

Closes https://github.com/meanjs/mean/issues/1814
2017-07-27 13:19:22 -07:00
Michael Leanos
0cbdbdafb7 fix(users): Domain config setting (#1803)
Fixes an incorrect reference to the application's Domain configuration
setting.
2017-06-28 15:12:15 -07:00
Justin Rodenbostel
44a569ee1f feat(articles): Simple test enhancement (#1659)
* feat(articles): Simple test enhancement

Simple test enhancement proposed by @jrodenbostel.  Eases troubleshooting when Article save fails during test execution.

Further reference here: https://github.com/meanjs/generator-meanjs/pull/257

Fixes #1658

* updated per @simison's request
2017-06-13 15:57:02 -07:00
aanev
d72da37e9b feat(articles): Promisifies article server test set up and clean up (#1774)
Promisifies object creation in beforeEach and afterEach hooks in article server tests.

Fixes #1773
2017-06-12 11:19:11 +03:00
Michael Leanos
e4a3d38b23 fix(users): Duplicate Provider Accounts (#1767)
Fixes an issue where a provider account could be added to the logged in
user's additionalProviderData, when another user has already connected
that same account.

Refactors the saveOAuthUserProfile method to consider the results of the
provider search query, whether or not the current user is logged in.
2017-06-11 00:21:26 -07:00
Liran Tal
e596375b62 fix(tests): removing unused mock-fs library which caused tests to fail (#1751) 2017-04-08 11:49:38 +03:00
Laurence Tennant
f53db0f2e2 Better autofocus (#1664) 2016-12-13 18:51:19 -08:00
Laurence Tennant
2b6cf53d30 fix(users): Better MIME-type checking, remove image cropping library (#1589)
* Cropping remove, nicer UI

* Fix MIME-type checking, add image upload tests

* Change image config settings to uploads.profile.image to build a more
rational structure for configuring other types of uploads
2016-11-15 15:59:47 -08:00
Sujeeth
fb9d9d912c feat(user): add strict validations for username (#1574)
Idea proposed by @sparshy #1204
Suggestions, rules and tests from Trustroots @simison
Added validations on user server model
Added client side validations
Added relevant tests on user server tests
Added relevant tests on user e2e tests

Fixes #1204
2016-10-19 20:40:26 -07:00
itelo
0e2ea65918 fix(users): fix redirect when signup or add provider (#1573)
Fixes the issue of the redirect after Social login authentication, on signup or user profile add provider.
2016-10-19 17:12:47 -07:00
Pierre Brisorgueil
ae638893b2 fix(users): test for usernameOrEmail (#1582) 2016-10-19 18:59:45 +03:00
Pedro Rodrigues
59c11c622e fix(core): fix twitter meta tags (#1581)
I believe the Twitter meta tags are outdated and this PR fixes them.
Taking into account the current MEAN.js tags and the Twitter docs, the most similar feature I found
is the Twitter Summary Card (https://dev.twitter.com/cards/types/summary).
2016-10-19 11:49:02 +03:00
Liran Tal
d824224b2f fix(core): Remove the <base> tag (continues #1230)
fix(core): Remove the <base> tag (continues #1230)
Merge pull request #1544 from mleanos/remove-base-tag
2016-10-12 14:20:37 +03:00
Sujeeth
d5b8ffa50c feat(core): Add error handler for failed requests (#1557)
Add error handle for failed requests(no response from server)
Using Notification.error to show error message
Added test for the notification in Auth Interceptor

Fixes #1556
2016-10-11 20:47:29 -07:00
Michael Leanos
baa291af4e fix(core): Directive file naming convention (#1558)
Renames show-error & autofocus directives to conform to naming
conventions.

Fixes: https://github.com/meanjs/mean/issues/1233
2016-10-11 20:45:06 -07:00
mleanos
99e5803eae Fix client-side tests after removing <base/>
Fixes the client-side tests after the removal of the <base/> tag from
the main layout.

These fixes aren't ideal. At the moment, they will suffice. This comment
(https://github.com/angular-ui/ui-router/issues/212#issuecomment-60803437),
among others in that issue, led me to choose this method as the fix to
avoid having to change any other core code.
2016-10-10 17:11:25 -07:00
mleanos
c065246a23 Update path in tests
Updated tests to account for new "/" prefix in the path.
2016-10-10 16:05:10 -07:00
Cameron Behar
aebaf2ff74 fix(core): Remove the <base> tag. 2016-10-10 16:05:10 -07:00
Michael Leanos
0ea8cec120 fix(express): Incorrest uses of 400 error codes (#1553)
Fixes incorrest usage of 400 HTTP responses being returned from the
server, in favor of using 422.

Also, changed a few return codes to 401 where it was more appropriate.

See this article for reasoning behind moving to 422, and why 400 isn't
appropriate for these cases.

For ref:
6be12f8a06

Related:
https://github.com/meanjs/mean/pull/1547
https://github.com/meanjs/mean/pull/1510
2016-10-10 16:00:24 -07:00
Sujeeth
607ed061e3 feat(core): add notification feedback with angular-ui-notification (#1532)
Added visual notification for user/article updates
angular-ui-notification config added to core client config
Notification idea from #369
2016-10-10 14:51:44 -07:00
shanavas
5725c449c7 Fix(Users): Remove redundant request body (#1554) 2016-10-09 12:00:47 +03:00
itelo
4aa5d77251 feat(core): change console in angular to (#1551)
logs with $log in client idea proposed by @simison
also removed unnecessary consoles in users.password.server.controller.js

Fixes #1541
2016-10-08 21:43:27 -07:00
Michael Leanos
6be12f8a06 fix(core): Add custom 400 and 404 error messages (#1547)
* Added 400 and 404 custom error messages

* nicer error message views

* Sign Up & Sign In error responses

Changed the error responses returned from the Sign Up & Sign In API
calls to use 422 rather than 400.

For insight into why this change was made:
https://github.com/meanjs/mean/pull/1510#issuecomment-247435378

For reference on why to use 422 over 400:
https://www.bennadel.com/blog/2434-http-status-codes-for-invalid-data-400-vs-422.htm
2016-10-07 22:03:31 -07:00
itelo
6a6b630292 feat(users): change username to usernameOrEmail in signin (#1545)
* feat(users): change username to usernameOrEmail in signin

* fix(users): toLowerCase at email in local strategy
2016-10-06 18:34:15 +03:00
hyperreality
73a7c2cf61 feat(core): Minor UI fixes for mobile; autofocus (#1499)
* Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.

* switched to handlebar template for passing the server's owasp config down to the client.

reverted some of the other changes (regarding the http request).

* Removed debug code.

* Changed variable name to owaspConfig

* Fixed minor type-o's and set owasp.config() rather than the underlying configs.

* chore(tidy): tidying up minor lint and layout issues

* fix(lint): CSS alphabetize warnings (#1498)

Fixes css lintings warnings of properties not alphabetized.

* fix(authentication) Stops error on signin/signup (#1495)

Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.

* Moved owasp config into default and reverted other config files.

Modified config to be "shared". This will allow future configurations to be easily passed to the client.

* fixed 403 redirect if not signed in (#1496)

* Update form-article.client.view.html

For New Article, delete function no required

* UI changes for mobile; autofocus

* fixed broken password popover balloon

* add e2e test for autofocus

* Remove test, fix delete social login button

* feat(core): Move template to .github folder

* Deprecated $http success/error promise methods (#1508)

Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479

* rebase
2016-10-04 21:14:57 -07:00
Sujeeth
287f81c6dd fix(user): remove bad request for local.png (#1538)
Removes a bad image request from manage social account settings page
Ideas from #1537, suggestions from @mleanos

Fixes #1537
2016-10-01 17:18:06 -07:00
sujeethk
0736a404c9 fix(user): hide delete button for self (#1535)
Remove delete button for self

Fixes #1531
2016-10-01 12:17:15 -07:00
sujeethk
a7aebbd866 fix(article): add callback for remove article (#1534)
Add callback on remove article for state transition

Fixes #1274
2016-09-30 14:55:10 -07:00
Daron Jones
e3eafa6131 fix(users) Handle missing email - OAuth (#1501)
* fix(users) patch OAuth default email issue

- Intentionally omits setting email in constructor to trigger defaults when
creating user. Handles cases where email is not authorized/given by provider.

Related to issue #1250
2016-09-20 21:24:16 -07:00
Michael Leanos
fa138045e6 Deprecated $http success/error promise methods (#1508)
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479
2016-09-17 12:05:21 -07:00
KULDIP PIPALIYA
7ffbd3ff9e Update form-article.client.view.html
For New Article, delete function no required
2016-09-16 12:39:12 +05:30
hyperreality
8b54669614 fixed 403 redirect if not signed in (#1496) 2016-09-13 12:39:50 -07:00
Liran Tal
4f3a501063 feat(angular): added owasp configuration for frontend
Added configuration for owasp. Synchronize client owap configs with t…
2016-09-13 00:19:41 +03:00
walter
0588eaba48 Moved owasp config into default and reverted other config files.
Modified config to be "shared". This will allow future configurations to be easily passed to the client.
2016-09-12 11:53:22 -07:00
Daron Jones
67d1a5a1f6 fix(authentication) Stops error on signin/signup (#1495)
Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.
2016-09-11 12:29:05 -07:00
Michael Leanos
b2a5cb5b6f fix(lint): CSS alphabetize warnings (#1498)
Fixes css lintings warnings of properties not alphabetized.
2016-09-09 22:28:14 -07:00
walter
8dcf3f6728 Fixed minor type-o's and set owasp.config() rather than the underlying configs. 2016-09-08 12:08:37 -07:00
walter
d73d6baa7c Changed variable name to owaspConfig 2016-09-08 11:28:30 -07:00
walter
c0a1ce5ea5 Removed debug code. 2016-09-08 11:25:05 -07:00
walter
4ddb059346 switched to handlebar template for passing the server's owasp config down to the client.
reverted some of the other changes (regarding the http request).
2016-09-08 11:17:41 -07:00
Mikael Korpela
25c8a6044c fix(tests): Clean out .send() from tests (#1489)
Clean out commented `.send()` from user CRUD test.
2016-09-08 14:45:33 +03:00
walter
d896d07d8b Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.
2016-09-07 19:16:11 -07:00
hyperreality
c2cfc388bf feat(ui): improved social login buttons UI (#1471) 2016-09-04 01:29:43 +03:00
Liran Tal
cf246babd1 feat(config): adds a generic DOMAIN configuration environment (#1469)
Generic DOMAI configuration environment variable, useful for setting links to an app
in reset email templates, and other cases.

Fixes #871 and #847
2016-09-01 22:37:43 +03:00