Commit Graph

229 Commits

Author SHA1 Message Date
Trevor Jennings
5137214972 fix(users): Incorrect UsersService injection (#1283)
* fix bug in edit profile controller.

* fix(users): Incorrect UsersService injection
2016-04-29 14:20:03 -07:00
Michael Leanos
4906611ccc fix(users): GitHub strategy missing email (#1250)
Fixes an issue with an empty/missing/null Email coming from GitHub's
OAuth call response.

Also, introduces the `sparse` index option on the User model's Email
field. This will ensure that we can have multiple User documents without
the Email field.

Adds a server-side User model test for the sparse index setting on the
email field.

Confirms that User documents without the email field are not indexed,
illustrating the sparse option on the schema's email field works
properly.

Added the dropdb task to the Gulp test:client & test:server tasks, to
ensure we have a clean database & that any indexes are rebuilt; this
will ensure any Schema changes (in this case the email index is rebuilt using
the sparse index option) are reflected when the database is started again.

Added a UPGRADE.md for tracking important upgrade information for our
user's to be aware of, when we introduce potentially breaking changes.

Included an explanation of the Sparse index being added, and how to apply it
to an existing MEANJS application's database.

Adds a script for dropping the `email` field's index from the User
collection.

Related #1145
2016-04-29 14:13:46 -07:00
trendzetter
b633dfb964 Revert "Enhancement(core):Relative position attribute added to the header." 2016-04-18 22:11:07 +02:00
Michael Leanos
dde9682073 Merge pull request #1202 from Gym/core-styleguide
feat(core): Modify core module to implement style guidelines.
2016-03-23 21:07:48 -07:00
Ryan Hutchison
b2462ec86c feat(core): Modify core module to implement style guidelines.
Update the core module to implement the style guidelines.
Reduce size of init.js - moved filter logic out to it's own config.
Rename Menus to menuService
2016-03-23 15:41:57 -04:00
Olatunde Garuba
661b3b6461 Enhancement(core):Relative positon attribute added to the header.
Relative positon attribute added to the header. proposed by @generalgmt

Fixes #1275
2016-03-19 16:52:28 +01:00
Liran Tal
80226a2b24 fix(client): lint issues for confirm() messages not referencing the window object 2016-03-17 22:27:53 +02:00
Marek Grzybek
d14d5130af feat(config): Deprecate JSHint in favor of ESLint
Add basic ESLint setup extending well-known Airbnb code style.

Fixes #1072, #1097
2016-03-15 19:11:12 +01:00
Michael Leanos
4e9ad81ad2 Merge pull request #1246 from QiyuLi/fix/supoort_mongo_3.2
fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
2016-03-14 12:19:59 -07:00
Michael Leanos
4c89ce7e2d Merge pull request #1208 from itelo/users-styleguide
feat(users): Modify users module to implement style guidelines.
2016-03-14 11:46:41 -07:00
mleanos
b00498629c fix(core): Remove trailing slash from routes
Adds an angular $urlRouterProvider service Rule to the Core module
configuration, that removes any trailing slashes in the URL for all routes.

The Rule is defined in the core routes configuration. Thus, in order for
this to work on all routes in the application, we have to inject the Core
module into each client module, as a dependecy in the client.module
configuration. Otherwise, we'd have to define the Rule in each module's route
configuration individually.

Adds missing client-side route configuration tests.

Tests demonstrate that the various route configurations can handle a trailing
slash in the URL, and gets resolved to the correct client route.

Fixes #1075
2016-03-06 20:56:29 -08:00
IteloFilho
173b702f6a feat(users): Modify users module to implement style guidelines. 2016-03-06 12:21:51 -03:00
Michael Leanos
8f00edcd82 Merge pull request #1241 from mleanos/fix/connected-accounts-not-shown
fix(users): Missing primary social provider
2016-03-04 16:12:44 -08:00
Qiyu Li
6265aaa7da fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
The new WiredTiger engine is introduced in MongoDB 3.2.
It changes the output errmsg format for violation of unique index.
This commit adds support for the new format.

Fixes #1245
2016-03-04 09:56:15 -05:00
Ilan Biala
049fde9451 Merge pull request #1207 from trendzetter/master
feat(config): Upgrade to angular 1.5
2016-03-02 14:44:55 -05:00
mleanos
f2e18e24f1 fix(users): Missing primary social provider
Adds the User's provider to the list of connect social accounts, when it
is also a social account.

Fixes: #1032
2016-03-02 10:40:34 -08:00
Joris Willems
500d1a62df feat(config): upgrade to angular 1.5
Update bower dependencies to more recent versions.
Resolved hard-coded dependency by updating file upload
PhantomJs to 2.x series for tests (@usta)
Fix assertion in tests for compatibility with MongoDB 3.2 (@rhutchison)
Improve coding style tests to avoid type errors (@ilanbiala)
Fix refresh showing flash of scrollbar in menu
Remove deprecated angular-ui-utils

Fixes #1124
2016-03-02 18:18:53 +01:00
Liran Tal
0ebbdd4935 Merge pull request #1236 from lirantal/bugfix/ignored_errors_on_controller
fix(users) error objects were not handled
2016-02-28 09:58:20 +02:00
Liran Tal
03043dcc90 fix(users): removing unused variable from code 2016-02-27 12:58:46 +02:00
Liran Tal
8e249548d4 fix(users): error objects were not handled 2016-02-27 12:54:54 +02:00
droooney
52faf0697f fix(build): Remove BOM
Remove byte-order mark from source files.

Fixes #1227
2016-02-20 14:49:30 +05:00
Cody B. Daig
a069531b10 Merge pull request #1186 from itelo/ImproveSEO
feat (title): Dynamic Title: Improve SEO
2016-02-13 10:20:54 -07:00
Liran Tal
1cb72bcefa Merge pull request #1203 from Gym/patch-1192
feat(articles): Rename list.articles.client.controller.js to list-art…
2016-02-13 15:01:25 +02:00
Liran Tal
7852144fc1 Merge pull request #1200 from meanjs/node5-support
Update Mocha
2016-02-12 00:41:22 +02:00
Ryan Hutchison
a014ffca9f feat(articles): Rename list.articles.client.controller.js to list-articles.client.controller.js
Closes #1192
2016-02-11 00:36:02 -05:00
Ilan Biala
62095a1114 fix(test): Update Mocha, mock-fs, and fix Node 5 support 2016-02-10 20:47:11 -05:00
Ryan Hutchison
3e6a65d3a0 fix(users): Correct spelling/grammar mistakes
Closes #1156

adjust language
2016-02-10 19:56:42 -05:00
Ilan Biala
7f99fd16d3 Merge pull request #1149 from mleanos/bugfix/article-remove-button-show
fix(articles): Article edit/delete validation
2016-02-10 11:06:30 -05:00
IteloFilho
49f6a83032 feat (title): Dynamic Title: Improve SEO 2016-02-10 12:12:10 -03:00
Francis Daigle
ba85dccb00 fix(core): Add "additionalProvidersData" to "safeUserObject"
Needed for management of social accounts.
2016-02-08 14:49:33 -07:00
mleanos
69b8a05ea2 fix(articles): Article edit/delete validation
Adds a custom field named `isCurrentUserOwner` to the Article document before
it's returned to the client. This field is used to determine if the current
User should is the "owner", and should see the edit/delete controls on the
client-side when viewing a single article. This custom (ad-hoc) field is NOT
persisted to the database; it's merely attached to the document.

Added server-side route tests for verifying the ad-hoc
"isCurrentUserOwner" field is properly set on the a single Article document.

Fixes #1146
2016-02-07 21:29:18 -08:00
Cody B. Daig
43b8caeb58 Merge pull request #1143 from trendzetter/master
feat(config): upgrade angular-bootstrap from 0.13 to 1.0
2016-01-29 11:49:39 -07:00
Andrew Throener
48eabd02ed fix(core menu): Menuize the account routes so they can be added to by submodules
Newlines fix

Removed Comment
2016-01-25 19:40:05 -06:00
Joris Willems
9cd4ceca46 feat(config): Upgrade angular-bootstrap 0.13 to 1.0
Many issues arise when using angular-bootstrap 0.13. Migration to 1.0 is
straightforward, offers a more stable interface, extra directives and fixes
many bugs.
Migration guide:
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

Fixes #1142
Fixes #1131
2016-01-17 22:06:34 +01:00
Liran Tal
6658774569 Merge pull request #1128 from mleanos/bugfix/gh-1127
fix(users): ProfileImageURL sanitize with ngSanitize
2016-01-17 19:16:30 +02:00
Sébastien Combéfis
d2b2dfd606 fix(docs): Fix comments content and style
Changed some bad comments referencing the Articles module in other modules.
Typo fixed in xxx.client.modules.js files ("Application" => "Applicaion")
Full stop character removed at the end of line comments
2016-01-17 11:46:11 +01:00
Ilan Biala
3dee3fc47a Merge pull request #1134 from farajfarook/master
fix(users): Removing redundant variables
2016-01-16 14:09:09 -05:00
Faraj Farook
f9c7403825 fix(users): Removing redundant variables
Removing redundant variables defined and not used
2016-01-16 16:17:07 +05:30
Cody B. Daig
6c5b630b99 Merge pull request #1126 from Gym/article-styleguide
feat(articles): Modify articles module to implement style guidelines.
2016-01-15 14:57:44 -08:00
mleanos
f88f28e035 fix(users): Profile image path is invalid after escaping
Removes the validator.escape on the profileImageUrl field in core server
controller.

The escaping was causing the profileImageUrl field to be an invalid path
for the image. We don't need to worry about xss vulnerabilities on this
field because no user input is provided; the name & path are generated
by the application logic.

Fixes #1127
2016-01-15 12:39:17 -08:00
Liran Tal
b9e3fd1625 Merge pull request #1119 from lirantal/bugfix/xss_and_validations
fix(security): fixing possible xss issue in parsed objects
2016-01-02 10:45:15 +02:00
Ryan Hutchison
b3ad56efa3 feat(articles): Modify articles module to implement style guidelines.
Update the articles module to implement the style guidelines.

Much of this work is from @trainerbill

Closes #874
Closes #339
2016-01-02 01:53:59 -05:00
Cody B. Daig
169d4cd3e2 Merge pull request #1100 from mleanos/bugfix/ClientRoutes-Guest-Access
fix(core): Client routes guest access bug
2015-12-31 08:17:20 -08:00
Ryan Hutchison
5d15e64a6d feat(chat): Modify chat module to implement johnpapa styleguide. 2015-12-30 20:54:35 -05:00
Liran Tal
2b0ae863a0 fix(security): fixing possible xss issue in parsed objects
Fixes #1106
2015-12-30 16:41:05 +02:00
mleanos
bfcfb555ff fix(core): Client routes guest access bug
Adds a check for the existence of the "guest" role in the state configuration
that we're transitioning to, in the core $stateChangeStart event handler. If
it exists, then we allow access.

Also, added validation of Authentication.user object. While writing
tests, I ran into an issue here when the Authentication service wasn't injected
into a controller. Probably best to have this check in place.

Fixes https://github.com/meanjs/mean/issues/1098
2015-12-29 23:28:14 -08:00
Cody B. Daig
b12be5fca5 Merge pull request #1107 from pgrodrigues/master
fix(core): Remove duplicate angular interceptor
2015-12-28 19:41:24 -08:00
Liran Tal
0744ce5d96 fix(tests) fixing assertion test for logger which failed on undefined variable 2015-12-28 10:24:32 +02:00
mleanos
2bdde4e9e2 fix(articles): Orphaned User reference throws server error
Adds an additional check for the existence of a populated user
reference, when determining if the current user has immediate access to
the requested article.

Without this fix, the server will throw an error if the requested
article doesn't have a populated user field.

Modified the article & articles list view's to check if the article has
a populated user. If not, then it will display "Deleted User" in place
of the missing user reference.

Added a server-side test that ensures we can get a single article if
the article.user field is referencing a deleted user.

Fixes #1082
2015-12-21 19:40:25 -08:00
Pedro Rodrigues
996976ac66 fix(core): Remove duplicate angular interceptor
Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096
2015-12-16 14:55:07 +00:00