Commit Graph

123 Commits

Author SHA1 Message Date
Liran Tal
d824224b2f fix(core): Remove the <base> tag (continues #1230)
fix(core): Remove the <base> tag (continues #1230)
Merge pull request #1544 from mleanos/remove-base-tag
2016-10-12 14:20:37 +03:00
Sujeeth
d5b8ffa50c feat(core): Add error handler for failed requests (#1557)
Add error handle for failed requests(no response from server)
Using Notification.error to show error message
Added test for the notification in Auth Interceptor

Fixes #1556
2016-10-11 20:47:29 -07:00
Michael Leanos
baa291af4e fix(core): Directive file naming convention (#1558)
Renames show-error & autofocus directives to conform to naming
conventions.

Fixes: https://github.com/meanjs/mean/issues/1233
2016-10-11 20:45:06 -07:00
Cameron Behar
aebaf2ff74 fix(core): Remove the <base> tag. 2016-10-10 16:05:10 -07:00
Sujeeth
607ed061e3 feat(core): add notification feedback with angular-ui-notification (#1532)
Added visual notification for user/article updates
angular-ui-notification config added to core client config
Notification idea from #369
2016-10-10 14:51:44 -07:00
itelo
4aa5d77251 feat(core): change console in angular to (#1551)
logs with $log in client idea proposed by @simison
also removed unnecessary consoles in users.password.server.controller.js

Fixes #1541
2016-10-08 21:43:27 -07:00
Michael Leanos
6be12f8a06 fix(core): Add custom 400 and 404 error messages (#1547)
* Added 400 and 404 custom error messages

* nicer error message views

* Sign Up & Sign In error responses

Changed the error responses returned from the Sign Up & Sign In API
calls to use 422 rather than 400.

For insight into why this change was made:
https://github.com/meanjs/mean/pull/1510#issuecomment-247435378

For reference on why to use 422 over 400:
https://www.bennadel.com/blog/2434-http-status-codes-for-invalid-data-400-vs-422.htm
2016-10-07 22:03:31 -07:00
hyperreality
73a7c2cf61 feat(core): Minor UI fixes for mobile; autofocus (#1499)
* Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.

* switched to handlebar template for passing the server's owasp config down to the client.

reverted some of the other changes (regarding the http request).

* Removed debug code.

* Changed variable name to owaspConfig

* Fixed minor type-o's and set owasp.config() rather than the underlying configs.

* chore(tidy): tidying up minor lint and layout issues

* fix(lint): CSS alphabetize warnings (#1498)

Fixes css lintings warnings of properties not alphabetized.

* fix(authentication) Stops error on signin/signup (#1495)

Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.

* Moved owasp config into default and reverted other config files.

Modified config to be "shared". This will allow future configurations to be easily passed to the client.

* fixed 403 redirect if not signed in (#1496)

* Update form-article.client.view.html

For New Article, delete function no required

* UI changes for mobile; autofocus

* fixed broken password popover balloon

* add e2e test for autofocus

* Remove test, fix delete social login button

* feat(core): Move template to .github folder

* Deprecated $http success/error promise methods (#1508)

Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479

* rebase
2016-10-04 21:14:57 -07:00
hyperreality
8b54669614 fixed 403 redirect if not signed in (#1496) 2016-09-13 12:39:50 -07:00
Liran Tal
4f3a501063 feat(angular): added owasp configuration for frontend
Added configuration for owasp. Synchronize client owap configs with t…
2016-09-13 00:19:41 +03:00
walter
0588eaba48 Moved owasp config into default and reverted other config files.
Modified config to be "shared". This will allow future configurations to be easily passed to the client.
2016-09-12 11:53:22 -07:00
Michael Leanos
b2a5cb5b6f fix(lint): CSS alphabetize warnings (#1498)
Fixes css lintings warnings of properties not alphabetized.
2016-09-09 22:28:14 -07:00
walter
8dcf3f6728 Fixed minor type-o's and set owasp.config() rather than the underlying configs. 2016-09-08 12:08:37 -07:00
walter
d73d6baa7c Changed variable name to owaspConfig 2016-09-08 11:28:30 -07:00
walter
4ddb059346 switched to handlebar template for passing the server's owasp config down to the client.
reverted some of the other changes (regarding the http request).
2016-09-08 11:17:41 -07:00
Liran Tal
f6e579765f feat(express): introducing handlebars nodejs template system (#1461)
This commit introduces handlebars template system and completely replacing Swig and the Consolidate project to handle multiple template systems.
Fixes #1286
2016-08-29 08:32:21 +03:00
Mikael Korpela
07a860f6b5 feat(angular): disable Angular debug data in production (#1457)
Disable Angular debug data in production for a significant performance
boost.

Passes environment variable from template to app config and from there
to
Angular bootstrap config.

https://docs.angularjs.org/guide/production#disabling-debug-data

See #1294
2016-08-28 14:52:05 +03:00
hyperreality
99c64cf7ca feat(html): support noscript tag on layout for browsers with no javascript (#1454) 2016-08-28 14:28:16 +03:00
aanev
234f0c6850 fix(user): fix changeProfilePicture to overwrite existing files
* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

* update error handler module to handle file upload errors

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

* update error handler module to handle file upload errors

Fixes #1415
2016-08-26 10:10:02 +03:00
hyperreality
246c5d953c feat(profile): Profile picture cropping, mobile uploading and progress bar (#1443)
* Add ng-file-upload and picture cropping

* Update bower.json

Remove bower dependency for angular-file-upload
2016-08-26 09:56:56 +03:00
Steve Fox
5817a484fa Add support for params in menu items
 (#1305)
* Support params to state for menu items.

* feat(core): Add support for params in menu items

Proposed by @scfox

Fixes #1304

* Removed trailing space on test.

* Changed default params to be empty object instead of empty string.
2016-07-25 14:14:39 -07:00
itelo
d5a29f7acc fix(core): fix page-title directive (#1405)
fix Eslint throws "Move the invocation into the parens that contain the function wrap-iife"
fix typo retrict -> restrict
2016-07-21 22:05:41 -07:00
Michael Leanos
828753715f fix(core): fix page-title directive (#1404) 2016-07-17 19:06:31 -07:00
Cody B. Daig
5009a72bf0 feat(core): Enable ng-strict-di (#1389) 2016-07-11 09:10:42 -06:00
Aman Mavai
fde27f0d1e fix(core): Typo in menu.client.service.js (#1355)
* fixed typo in modules/core/client/services/menu.client.service.js
* fixed typo in modules/core/tests/client/menu.client.service.tests.js
2016-06-06 15:29:46 +03:00
Liran Tal
c8cbcd326f feat(logs): replacing unmaintained and vulnerable file-stream-rotator package with winston log facility (#1334)
* replacing file-stream-rotator with a better logging mechanism using winston which can be extended later for other use cases and integrations

* refactoring logger mechanism, accomodating for tests and environment variable configurations

* only enabling morgan logger if config.log.format option was defined, and disabling the app.log file transport option for the test environment

* disabling all kind of logging when in test enviroment
2016-05-22 01:03:18 +03:00
aanev
c61640bfdb fix(core): Typo in page-title.client.directives.js (#1343)
fix typo in modules/core/client/directives/page-title.client.directives.js

Fixes #1332
2016-05-20 11:10:18 +03:00
trendzetter
b633dfb964 Revert "Enhancement(core):Relative position attribute added to the header." 2016-04-18 22:11:07 +02:00
Michael Leanos
dde9682073 Merge pull request #1202 from Gym/core-styleguide
feat(core): Modify core module to implement style guidelines.
2016-03-23 21:07:48 -07:00
Ryan Hutchison
b2462ec86c feat(core): Modify core module to implement style guidelines.
Update the core module to implement the style guidelines.
Reduce size of init.js - moved filter logic out to it's own config.
Rename Menus to menuService
2016-03-23 15:41:57 -04:00
Olatunde Garuba
661b3b6461 Enhancement(core):Relative positon attribute added to the header.
Relative positon attribute added to the header. proposed by @generalgmt

Fixes #1275
2016-03-19 16:52:28 +01:00
Marek Grzybek
d14d5130af feat(config): Deprecate JSHint in favor of ESLint
Add basic ESLint setup extending well-known Airbnb code style.

Fixes #1072, #1097
2016-03-15 19:11:12 +01:00
Michael Leanos
4e9ad81ad2 Merge pull request #1246 from QiyuLi/fix/supoort_mongo_3.2
fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
2016-03-14 12:19:59 -07:00
mleanos
b00498629c fix(core): Remove trailing slash from routes
Adds an angular $urlRouterProvider service Rule to the Core module
configuration, that removes any trailing slashes in the URL for all routes.

The Rule is defined in the core routes configuration. Thus, in order for
this to work on all routes in the application, we have to inject the Core
module into each client module, as a dependecy in the client.module
configuration. Otherwise, we'd have to define the Rule in each module's route
configuration individually.

Adds missing client-side route configuration tests.

Tests demonstrate that the various route configurations can handle a trailing
slash in the URL, and gets resolved to the correct client route.

Fixes #1075
2016-03-06 20:56:29 -08:00
Michael Leanos
8f00edcd82 Merge pull request #1241 from mleanos/fix/connected-accounts-not-shown
fix(users): Missing primary social provider
2016-03-04 16:12:44 -08:00
Qiyu Li
6265aaa7da fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
The new WiredTiger engine is introduced in MongoDB 3.2.
It changes the output errmsg format for violation of unique index.
This commit adds support for the new format.

Fixes #1245
2016-03-04 09:56:15 -05:00
mleanos
f2e18e24f1 fix(users): Missing primary social provider
Adds the User's provider to the list of connect social accounts, when it
is also a social account.

Fixes: #1032
2016-03-02 10:40:34 -08:00
Joris Willems
500d1a62df feat(config): upgrade to angular 1.5
Update bower dependencies to more recent versions.
Resolved hard-coded dependency by updating file upload
PhantomJs to 2.x series for tests (@usta)
Fix assertion in tests for compatibility with MongoDB 3.2 (@rhutchison)
Improve coding style tests to avoid type errors (@ilanbiala)
Fix refresh showing flash of scrollbar in menu
Remove deprecated angular-ui-utils

Fixes #1124
2016-03-02 18:18:53 +01:00
Cody B. Daig
a069531b10 Merge pull request #1186 from itelo/ImproveSEO
feat (title): Dynamic Title: Improve SEO
2016-02-13 10:20:54 -07:00
IteloFilho
49f6a83032 feat (title): Dynamic Title: Improve SEO 2016-02-10 12:12:10 -03:00
Francis Daigle
ba85dccb00 fix(core): Add "additionalProvidersData" to "safeUserObject"
Needed for management of social accounts.
2016-02-08 14:49:33 -07:00
Cody B. Daig
43b8caeb58 Merge pull request #1143 from trendzetter/master
feat(config): upgrade angular-bootstrap from 0.13 to 1.0
2016-01-29 11:49:39 -07:00
Andrew Throener
48eabd02ed fix(core menu): Menuize the account routes so they can be added to by submodules
Newlines fix

Removed Comment
2016-01-25 19:40:05 -06:00
Joris Willems
9cd4ceca46 feat(config): Upgrade angular-bootstrap 0.13 to 1.0
Many issues arise when using angular-bootstrap 0.13. Migration to 1.0 is
straightforward, offers a more stable interface, extra directives and fixes
many bugs.
Migration guide:
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

Fixes #1142
Fixes #1131
2016-01-17 22:06:34 +01:00
Liran Tal
6658774569 Merge pull request #1128 from mleanos/bugfix/gh-1127
fix(users): ProfileImageURL sanitize with ngSanitize
2016-01-17 19:16:30 +02:00
Sébastien Combéfis
d2b2dfd606 fix(docs): Fix comments content and style
Changed some bad comments referencing the Articles module in other modules.
Typo fixed in xxx.client.modules.js files ("Application" => "Applicaion")
Full stop character removed at the end of line comments
2016-01-17 11:46:11 +01:00
mleanos
f88f28e035 fix(users): Profile image path is invalid after escaping
Removes the validator.escape on the profileImageUrl field in core server
controller.

The escaping was causing the profileImageUrl field to be an invalid path
for the image. We don't need to worry about xss vulnerabilities on this
field because no user input is provided; the name & path are generated
by the application logic.

Fixes #1127
2016-01-15 12:39:17 -08:00
Liran Tal
b9e3fd1625 Merge pull request #1119 from lirantal/bugfix/xss_and_validations
fix(security): fixing possible xss issue in parsed objects
2016-01-02 10:45:15 +02:00
Liran Tal
2b0ae863a0 fix(security): fixing possible xss issue in parsed objects
Fixes #1106
2015-12-30 16:41:05 +02:00
mleanos
bfcfb555ff fix(core): Client routes guest access bug
Adds a check for the existence of the "guest" role in the state configuration
that we're transitioning to, in the core $stateChangeStart event handler. If
it exists, then we allow access.

Also, added validation of Authentication.user object. While writing
tests, I ran into an issue here when the Authentication service wasn't injected
into a controller. Probably best to have this check in place.

Fixes https://github.com/meanjs/mean/issues/1098
2015-12-29 23:28:14 -08:00