Commit Graph

285 Commits

Author SHA1 Message Date
Liran Tal
d824224b2f fix(core): Remove the <base> tag (continues #1230)
fix(core): Remove the <base> tag (continues #1230)
Merge pull request #1544 from mleanos/remove-base-tag
2016-10-12 14:20:37 +03:00
Sujeeth
d5b8ffa50c feat(core): Add error handler for failed requests (#1557)
Add error handle for failed requests(no response from server)
Using Notification.error to show error message
Added test for the notification in Auth Interceptor

Fixes #1556
2016-10-11 20:47:29 -07:00
Michael Leanos
baa291af4e fix(core): Directive file naming convention (#1558)
Renames show-error & autofocus directives to conform to naming
conventions.

Fixes: https://github.com/meanjs/mean/issues/1233
2016-10-11 20:45:06 -07:00
mleanos
99e5803eae Fix client-side tests after removing <base/>
Fixes the client-side tests after the removal of the <base/> tag from
the main layout.

These fixes aren't ideal. At the moment, they will suffice. This comment
(https://github.com/angular-ui/ui-router/issues/212#issuecomment-60803437),
among others in that issue, led me to choose this method as the fix to
avoid having to change any other core code.
2016-10-10 17:11:25 -07:00
mleanos
c065246a23 Update path in tests
Updated tests to account for new "/" prefix in the path.
2016-10-10 16:05:10 -07:00
Cameron Behar
aebaf2ff74 fix(core): Remove the <base> tag. 2016-10-10 16:05:10 -07:00
Michael Leanos
0ea8cec120 fix(express): Incorrest uses of 400 error codes (#1553)
Fixes incorrest usage of 400 HTTP responses being returned from the
server, in favor of using 422.

Also, changed a few return codes to 401 where it was more appropriate.

See this article for reasoning behind moving to 422, and why 400 isn't
appropriate for these cases.

For ref:
6be12f8a06

Related:
https://github.com/meanjs/mean/pull/1547
https://github.com/meanjs/mean/pull/1510
2016-10-10 16:00:24 -07:00
Sujeeth
607ed061e3 feat(core): add notification feedback with angular-ui-notification (#1532)
Added visual notification for user/article updates
angular-ui-notification config added to core client config
Notification idea from #369
2016-10-10 14:51:44 -07:00
shanavas
5725c449c7 Fix(Users): Remove redundant request body (#1554) 2016-10-09 12:00:47 +03:00
itelo
4aa5d77251 feat(core): change console in angular to (#1551)
logs with $log in client idea proposed by @simison
also removed unnecessary consoles in users.password.server.controller.js

Fixes #1541
2016-10-08 21:43:27 -07:00
Michael Leanos
6be12f8a06 fix(core): Add custom 400 and 404 error messages (#1547)
* Added 400 and 404 custom error messages

* nicer error message views

* Sign Up & Sign In error responses

Changed the error responses returned from the Sign Up & Sign In API
calls to use 422 rather than 400.

For insight into why this change was made:
https://github.com/meanjs/mean/pull/1510#issuecomment-247435378

For reference on why to use 422 over 400:
https://www.bennadel.com/blog/2434-http-status-codes-for-invalid-data-400-vs-422.htm
2016-10-07 22:03:31 -07:00
itelo
6a6b630292 feat(users): change username to usernameOrEmail in signin (#1545)
* feat(users): change username to usernameOrEmail in signin

* fix(users): toLowerCase at email in local strategy
2016-10-06 18:34:15 +03:00
hyperreality
73a7c2cf61 feat(core): Minor UI fixes for mobile; autofocus (#1499)
* Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.

* switched to handlebar template for passing the server's owasp config down to the client.

reverted some of the other changes (regarding the http request).

* Removed debug code.

* Changed variable name to owaspConfig

* Fixed minor type-o's and set owasp.config() rather than the underlying configs.

* chore(tidy): tidying up minor lint and layout issues

* fix(lint): CSS alphabetize warnings (#1498)

Fixes css lintings warnings of properties not alphabetized.

* fix(authentication) Stops error on signin/signup (#1495)

Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.

* Moved owasp config into default and reverted other config files.

Modified config to be "shared". This will allow future configurations to be easily passed to the client.

* fixed 403 redirect if not signed in (#1496)

* Update form-article.client.view.html

For New Article, delete function no required

* UI changes for mobile; autofocus

* fixed broken password popover balloon

* add e2e test for autofocus

* Remove test, fix delete social login button

* feat(core): Move template to .github folder

* Deprecated $http success/error promise methods (#1508)

Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479

* rebase
2016-10-04 21:14:57 -07:00
Sujeeth
287f81c6dd fix(user): remove bad request for local.png (#1538)
Removes a bad image request from manage social account settings page
Ideas from #1537, suggestions from @mleanos

Fixes #1537
2016-10-01 17:18:06 -07:00
sujeethk
0736a404c9 fix(user): hide delete button for self (#1535)
Remove delete button for self

Fixes #1531
2016-10-01 12:17:15 -07:00
sujeethk
a7aebbd866 fix(article): add callback for remove article (#1534)
Add callback on remove article for state transition

Fixes #1274
2016-09-30 14:55:10 -07:00
Daron Jones
e3eafa6131 fix(users) Handle missing email - OAuth (#1501)
* fix(users) patch OAuth default email issue

- Intentionally omits setting email in constructor to trigger defaults when
creating user. Handles cases where email is not authorized/given by provider.

Related to issue #1250
2016-09-20 21:24:16 -07:00
Michael Leanos
fa138045e6 Deprecated $http success/error promise methods (#1508)
Replaces the $http service calls with promise based methods
of the client-side UsersService for the following:
  Users Change Password
  Users Manage Social Accounts
  Users Password Forgot
  Users Password Reset
  Users Signup
  Users Signin

Modifies tests to reflect changes.

Closes #1479
2016-09-17 12:05:21 -07:00
KULDIP PIPALIYA
7ffbd3ff9e Update form-article.client.view.html
For New Article, delete function no required
2016-09-16 12:39:12 +05:30
hyperreality
8b54669614 fixed 403 redirect if not signed in (#1496) 2016-09-13 12:39:50 -07:00
Liran Tal
4f3a501063 feat(angular): added owasp configuration for frontend
Added configuration for owasp. Synchronize client owap configs with t…
2016-09-13 00:19:41 +03:00
walter
0588eaba48 Moved owasp config into default and reverted other config files.
Modified config to be "shared". This will allow future configurations to be easily passed to the client.
2016-09-12 11:53:22 -07:00
Daron Jones
67d1a5a1f6 fix(authentication) Stops error on signin/signup (#1495)
Uses the passport info object to simplify login and remove the need to
temporarily cache the redirect within the session.
2016-09-11 12:29:05 -07:00
Michael Leanos
b2a5cb5b6f fix(lint): CSS alphabetize warnings (#1498)
Fixes css lintings warnings of properties not alphabetized.
2016-09-09 22:28:14 -07:00
walter
8dcf3f6728 Fixed minor type-o's and set owasp.config() rather than the underlying configs. 2016-09-08 12:08:37 -07:00
walter
d73d6baa7c Changed variable name to owaspConfig 2016-09-08 11:28:30 -07:00
walter
c0a1ce5ea5 Removed debug code. 2016-09-08 11:25:05 -07:00
walter
4ddb059346 switched to handlebar template for passing the server's owasp config down to the client.
reverted some of the other changes (regarding the http request).
2016-09-08 11:17:41 -07:00
Mikael Korpela
25c8a6044c fix(tests): Clean out .send() from tests (#1489)
Clean out commented `.send()` from user CRUD test.
2016-09-08 14:45:33 +03:00
walter
d896d07d8b Added configuration for owasp. Synchronize client owap configs with the server configs.
Also added a time indicator on failed login attempts to give the user feedback on subsequent failed login attempts.
2016-09-07 19:16:11 -07:00
hyperreality
c2cfc388bf feat(ui): improved social login buttons UI (#1471) 2016-09-04 01:29:43 +03:00
Liran Tal
cf246babd1 feat(config): adds a generic DOMAIN configuration environment (#1469)
Generic DOMAI configuration environment variable, useful for setting links to an app
in reset email templates, and other cases.

Fixes #871 and #847
2016-09-01 22:37:43 +03:00
Daron Jones
54ae7dc564 feat(users): prevent route leaking access token (#1417)
The test for authentication use a route /api/users/me. This should probably be upgraded to use
a proper passport mock.

In the meanwhile this should make the returned user object safer - using code from core.

Fixes n/a
2016-08-31 22:50:23 +03:00
Liran Tal
f6e579765f feat(express): introducing handlebars nodejs template system (#1461)
This commit introduces handlebars template system and completely replacing Swig and the Consolidate project to handle multiple template systems.
Fixes #1286
2016-08-29 08:32:21 +03:00
Mikael Korpela
07a860f6b5 feat(angular): disable Angular debug data in production (#1457)
Disable Angular debug data in production for a significant performance
boost.

Passes environment variable from template to app config and from there
to
Angular bootstrap config.

https://docs.angularjs.org/guide/production#disabling-debug-data

See #1294
2016-08-28 14:52:05 +03:00
Mikael Korpela
c35713d352 fix(core): Fixes issues with tests and Node v6 (#1458)
Fixes issues with Mocha tests and Node v6.

Related to #1455
2016-08-28 14:30:27 +03:00
hyperreality
99c64cf7ca feat(html): support noscript tag on layout for browsers with no javascript (#1454) 2016-08-28 14:28:16 +03:00
shanavas
730cca76af fix(users): don't update secure profile fields (#1421)
* Fix(users): Don't update secure profile fields

Avoid updating secure fields as password, salt ..etc through
user profile update.

Fixes #1420

* Refactor variable name
2016-08-27 09:45:06 +03:00
Liran Tal
2f394ecb97 fix(ui): update social login design
* Update social login design 

- Responsive images
- Mobile layout as well

* changes according to hyperreality advices
2016-08-26 21:27:58 +03:00
Michael Leanos
c96f8c0b56 fix(articles): Article controllers name conflicts (#1428)
* fix(articles): Article controllers name conflicts

Fixes the naming conflicts for the Articles controllers.

Due to how Angular injects the controllers into the StateProvider,
naming conflicts were caused between the Articles public & admin module
controllers.

To resolve the issue the referenced controllers in the Articles admin
route configurations must be unique, and match up with the Admin
controllers.

* Client-side tests failing

Fixed the client-side tests that were failing due to the naming
conflicts.
2016-08-26 13:27:43 +03:00
Mikael Korpela
96aec09488 fix(user): specify a digest with crypto.pbkdf2Sync (#1429)
Fixes Node v6 crypto deprecation warning
 “crypto.pbkdf2 without specifying a digest is deprecated. Please specify a digest”
2016-08-26 10:13:51 +03:00
aanev
234f0c6850 fix(user): fix changeProfilePicture to overwrite existing files
* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

* update error handler module to handle file upload errors

Fixes #1415

* fix(user): fix changeProfilePicture

* use promises to simplify callbacks

* use fs.unlink to delete old picture once the profile is updated

* log file errors to console

* update error handler module to handle file upload errors

Fixes #1415
2016-08-26 10:10:02 +03:00
hyperreality
246c5d953c feat(profile): Profile picture cropping, mobile uploading and progress bar (#1443)
* Add ng-file-upload and picture cropping

* Update bower.json

Remove bower dependency for angular-file-upload
2016-08-26 09:56:56 +03:00
9ac345a5509a
24b6e3a3cb fix(chat): fixed profile image not displaying properly on disconnect
hotfix to make sure that the profileImageURL is sent on disconnect
2016-08-06 23:04:57 -04:00
Michael Leanos
89075cb8d3 feat(articles): Article Admin feature (#807)
This feature introduces a breaking change, that restricts the User's that
can create/edit/delete Articles to only those that have the `admin` Role.

Fixed ESLint issues.

Resolved merge conflicts, and moved new client Article Service
`createOrUpdate` functionality to new Admin feature controller.

Removed edit functionality from client-side Article controller.
2016-07-25 17:34:06 -07:00
Steve Fox
5817a484fa Add support for params in menu items
 (#1305)
* Support params to state for menu items.

* feat(core): Add support for params in menu items

Proposed by @scfox

Fixes #1304

* Removed trailing space on test.

* Changed default params to be empty object instead of empty string.
2016-07-25 14:14:39 -07:00
itelo
d5a29f7acc fix(core): fix page-title directive (#1405)
fix Eslint throws "Move the invocation into the parens that contain the function wrap-iife"
fix typo retrict -> restrict
2016-07-21 22:05:41 -07:00
Michael Leanos
828753715f fix(core): fix page-title directive (#1404) 2016-07-17 19:06:31 -07:00
Cody B. Daig
5009a72bf0 feat(core): Enable ng-strict-di (#1389) 2016-07-11 09:10:42 -06:00
Michael Leanos
a7370a7808 feat(articles): ArticlesService extended $resource (#1266)
Extends the ArticlesService $resource object to include a custom method
for creating, or updating, an Article instance.

Related #1260
2016-07-10 17:55:29 -07:00