Commit Graph

196 Commits

Author SHA1 Message Date
Joris Willems
9cd4ceca46 feat(config): Upgrade angular-bootstrap 0.13 to 1.0
Many issues arise when using angular-bootstrap 0.13. Migration to 1.0 is
straightforward, offers a more stable interface, extra directives and fixes
many bugs.
Migration guide:
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

Fixes #1142
Fixes #1131
2016-01-17 22:06:34 +01:00
Liran Tal
6658774569 Merge pull request #1128 from mleanos/bugfix/gh-1127
fix(users): ProfileImageURL sanitize with ngSanitize
2016-01-17 19:16:30 +02:00
Sébastien Combéfis
d2b2dfd606 fix(docs): Fix comments content and style
Changed some bad comments referencing the Articles module in other modules.
Typo fixed in xxx.client.modules.js files ("Application" => "Applicaion")
Full stop character removed at the end of line comments
2016-01-17 11:46:11 +01:00
Ilan Biala
3dee3fc47a Merge pull request #1134 from farajfarook/master
fix(users): Removing redundant variables
2016-01-16 14:09:09 -05:00
Faraj Farook
f9c7403825 fix(users): Removing redundant variables
Removing redundant variables defined and not used
2016-01-16 16:17:07 +05:30
Cody B. Daig
6c5b630b99 Merge pull request #1126 from Gym/article-styleguide
feat(articles): Modify articles module to implement style guidelines.
2016-01-15 14:57:44 -08:00
mleanos
f88f28e035 fix(users): Profile image path is invalid after escaping
Removes the validator.escape on the profileImageUrl field in core server
controller.

The escaping was causing the profileImageUrl field to be an invalid path
for the image. We don't need to worry about xss vulnerabilities on this
field because no user input is provided; the name & path are generated
by the application logic.

Fixes #1127
2016-01-15 12:39:17 -08:00
Liran Tal
b9e3fd1625 Merge pull request #1119 from lirantal/bugfix/xss_and_validations
fix(security): fixing possible xss issue in parsed objects
2016-01-02 10:45:15 +02:00
Ryan Hutchison
b3ad56efa3 feat(articles): Modify articles module to implement style guidelines.
Update the articles module to implement the style guidelines.

Much of this work is from @trainerbill

Closes #874
Closes #339
2016-01-02 01:53:59 -05:00
Cody B. Daig
169d4cd3e2 Merge pull request #1100 from mleanos/bugfix/ClientRoutes-Guest-Access
fix(core): Client routes guest access bug
2015-12-31 08:17:20 -08:00
Ryan Hutchison
5d15e64a6d feat(chat): Modify chat module to implement johnpapa styleguide. 2015-12-30 20:54:35 -05:00
Liran Tal
2b0ae863a0 fix(security): fixing possible xss issue in parsed objects
Fixes #1106
2015-12-30 16:41:05 +02:00
mleanos
bfcfb555ff fix(core): Client routes guest access bug
Adds a check for the existence of the "guest" role in the state configuration
that we're transitioning to, in the core $stateChangeStart event handler. If
it exists, then we allow access.

Also, added validation of Authentication.user object. While writing
tests, I ran into an issue here when the Authentication service wasn't injected
into a controller. Probably best to have this check in place.

Fixes https://github.com/meanjs/mean/issues/1098
2015-12-29 23:28:14 -08:00
Cody B. Daig
b12be5fca5 Merge pull request #1107 from pgrodrigues/master
fix(core): Remove duplicate angular interceptor
2015-12-28 19:41:24 -08:00
Liran Tal
0744ce5d96 fix(tests) fixing assertion test for logger which failed on undefined variable 2015-12-28 10:24:32 +02:00
mleanos
2bdde4e9e2 fix(articles): Orphaned User reference throws server error
Adds an additional check for the existence of a populated user
reference, when determining if the current user has immediate access to
the requested article.

Without this fix, the server will throw an error if the requested
article doesn't have a populated user field.

Modified the article & articles list view's to check if the article has
a populated user. If not, then it will display "Deleted User" in place
of the missing user reference.

Added a server-side test that ensures we can get a single article if
the article.user field is referencing a deleted user.

Fixes #1082
2015-12-21 19:40:25 -08:00
Pedro Rodrigues
996976ac66 fix(core): Remove duplicate angular interceptor
Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096
2015-12-16 14:55:07 +00:00
jloveland
33258f1314 feat(users): Supporting valid email according to HTML5 and RFC 822
Supporting valid email (i.e. root@admin) according to HTML5 and RFC 822
proposed by @jloveland

Fixes #934
2015-11-30 21:47:13 -05:00
mleanos
a871c92556 Duplicate CRUD Test - Profile Picture
Removes a duplicate User CRUD test for Profile Picture.

There are two reasons for this commit.

1) Duplicate of
https://github.com/meanjs/mean/blob/master/modules/users/tests/server/user.server.routes.tests.js#L833-L848
2) This test is problematic in Windows environment.
Related to:
https://github.com/visionmedia/supertest/issues/230
https://github.com/visionmedia/supertest/issues/258

The latter may be an issue with the `.attach` method not completely
loading the file into memory before the 400 status response is sent back
due to no User logged in.
2015-10-28 22:57:28 -07:00
Ilan Biala
63d0d71cf6 Merge pull request #948 from gustavodemari/update-multer-profile-upload
Update profile upload with a new version of multer
Fixes #947
2015-10-25 22:03:23 -04:00
mleanos
8cd2291a6a Enable log options for Morgan
Adds the log options, and format to the Morgan middleware in the Express
configuration.

These options are defined in the environment configurations.

The implementation derived from https://github.com/meanjs/mean/pull/254
by @lirantal, which somehow got overlooked when merging 0.4.0 into
master.

Added tests for the Logger configuration.

Added the log settings to the Test env config.

Added environment variables for the log settings in the Test &
Production env configs.

Moved the Morgan Express middleware outside of the NODE_ENV ===
'development' check. Morgan should be used in all environments, and use
the settings set in each env config.

Changed the wording of the Stream option comments in the env configs.

Added Rotating Logs functionality, and refactored the log Stream
options. Added a new npm package, FileStreamRotator, for use with
Morgan's rotating logs functionality.

Also, refactored the log configuration tests to be more maintainable.

Added more tests, and refactored test suite to use mock-fs.
2015-10-20 21:03:07 -07:00
gustavodemari
7ecf9337ce updating profile upload with a new version of multer 2015-10-18 20:56:12 -02:00
mleanos
e6a5732698 Favicon invalid path
Removed the {{url}} from the Favicon path. This fixes the intermittent
issues with the path resolving to an invalid location.

Removed the url from the twitter:image & og:image tags, to be static
references to the logo.
2015-10-17 16:17:28 -07:00
Ilan Biala
cc486d54c5 Merge pull request #910 from jloveland/hide-password-validator
Hide the password strength progress when the field is empty
2015-10-16 23:34:55 -04:00
Ilan Biala
0323696eaf Format code according to ESLint rules 2015-10-16 20:52:31 -04:00
Liran Tal
e30c3d1249 Merge pull request #957 from mleanos/seeddb-enhance-testability
Seed options - logResults
2015-10-15 17:24:28 +03:00
jloveland
65140442f0 adding tests for directives 2015-10-13 23:23:52 -04:00
jloveland
f733efba5a renaming strength meter, hiding when password field is empty, and refactoring directives to use $validators 2015-10-13 22:47:35 -04:00
Liran Tal
8a12f76a19 Merge pull request #972 from mleanos/mocha-global-timeout-grunt
Global Mocha timeout
2015-10-13 08:39:48 +03:00
Liran Tal
0017886d6e updating travis to support installing a local mail server 2015-10-11 23:19:20 +03:00
Liran Tal
eb7c4f8e91 adding more API tests 2015-10-11 23:19:20 +03:00
mleanos
037878b4ba Global Mocha timeout
Added the timeout option to the Mocha grunt task; set to 10000.

Removed the individual test suite timeouts, for all server tests.

Also, added global timeout for Mocha gulp task.
2015-10-10 23:52:08 -07:00
Liran Tal
19aea2f112 Merge pull request #967 from mleanos/user-model-validate-bug
[bug] Solves User model validation issue with tests [fixes #966]
2015-10-10 21:40:34 +03:00
mleanos
32e0d126ca Synchronous tests
Removed the done() callback method from the config tests that aren't
truly asynchronous.
2015-10-09 16:14:14 -07:00
mleanos
75cf74537a Formatting and Indentation
Changes to formatting and indentation.
2015-10-09 14:06:29 -07:00
mleanos
0560062eab Seed options - logResults
Added an options object to the database seed configuration. Currently,
the only option implemented is `logResults`; set using the seedDB env
config
options (default to "true").

Modified the definition of the env config for seedDB. It's now an
object, with
options.

Setting the logResults option is set to `false` in the core
configuration server test suite.

Also, fixed an issue with how env configs were reading the seedDB
setting from the env variables. Previously, the config was getting set
by
looking for merely the existence of the env variable (MONGO_SEED).
However,
if this setting existed but was set to "false", the seedDB would be
turned on.

Added the SeedDB user details to the env config, and seedDB options.

Added tests to the core server config test suite

should have seedDB configuration set for "regular" user
should have seedDB configuration set for admin user
should seed admin, and "regular" user accounts when NODE_ENV is set to
"test" when they already exist
should ONLY seed admin user account when NODE_ENV is set to "production"
with custom admin
should seed admin, and "regular" user accounts when NODE_ENV is set to
"test" with custom options
should NOT seed admin user account if it already exists when NODE_ENV is
set to "production"
should NOT seed "regular" user account if missing email when NODE_ENV
set to "test"

Added support for environment variables to seedDB env configs; currently
only supporting username & email.

Refactored how the SeedDB rejects were being handled
2015-10-09 13:48:11 -07:00
jloveland
b07af94255 adding return done() to tests 2015-10-09 12:45:16 -04:00
Liran Tal
28ae5d6301 Merge pull request #927 from jloveland/local-session-secret
adding ability to configure session.secret in local env config
2015-10-07 18:49:06 +03:00
Liran Tal
3cfd978e8a Merge pull request #922 from lirantal/feature/travis-add-node-v4-gcc-update
NodeJS v4 support - fixing the failed build
2015-10-06 14:22:47 +03:00
Liran Tal
b7a57abd30 adding the required support to properly build the nodejs v4 edition
updating grunt-node-inspector version to compatible version with nodejs v4
2015-10-06 14:09:04 +03:00
mleanos
288f0b4e63 Solves User model validation bug
This solves the issue of the User model's pre('validate') method,
attempting to validate against a password that was not modified.

Adds the this.isModified('password') check to the condition.
2015-10-05 16:41:14 -07:00
jloveland
2eb0b0970d adding ability to configure session.secret in local env config 2015-10-04 20:45:47 -04:00
Ilan Biala
7a9ee53357 Merge pull request #939 from jloveland/e2e-tests-fix
Fix grunt and gulp e2e tests, Fixes #929
2015-10-04 12:49:42 -04:00
mleanos
3b375e62d8 Mocha test timeouts [fixes #955]
Added a timeout of 10000 ms to each server test file. This is an attempt
to solve the timeout issues that we're experiencing with the Mocha
tests. Especially, this is hoping to address the build fails that are
caused by such timeouts.

Issue is described in https://github.com/meanjs/mean/issues/955
2015-09-30 19:50:07 -07:00
Liran Tal
7fcd4f2ed3 Merge pull request #937 from lirantal/feature/seeddb-refactoring
SeedDB Refactoring
2015-09-30 12:55:49 +03:00
jloveland
fdf1ad571b fixing grunt and gulp e2e tests 2015-09-29 08:21:43 -04:00
Liran Tal
cc80930081 Merge pull request #904 from jloveland/jshint-single-quotes
fixing jshint single quotes issues
2015-09-28 23:47:13 +03:00
Liran Tal
6f8b5bfd58 adding tests for meanjs core server functionality 2015-09-28 11:29:42 +03:00
Liran Tal
988609399a refactoring the seeddb logic to work with promises all over due to all the async behavior 2015-09-28 11:29:39 +03:00
jloveland
96bcd6d646 fixing spacing 2015-09-27 12:58:06 -04:00