Commit Graph

80 Commits

Author SHA1 Message Date
jloveland
1fd6bb6119 adding stronger password requirements for improving security based on OWASP 2015-09-07 22:11:02 -04:00
almegdad
aafa5e69cf Force Lowercase & Remove Sensitive Data
* add directive to force username & email lowercase
* remove sensitive data in password reset
* 2 space indentation  in reset & forgot password views
2015-09-01 21:09:20 +03:00
mleanos
14b8dd4dce Fixed User model tests
PR #840 changed the global var `user` to `user1`. This was merged and
then #858 was merged, which was still referencing the global var as
`user` in the new *roles* tests. This was causing jshint failures from
the new

This change updates the new *roles* tests to use `user1`
2015-08-30 15:53:29 -07:00
Liran Tal
8335aa7070 Merge pull request #858 from mleanos/admin-users-require-role
Admin users require role
2015-08-30 21:55:58 +03:00
Liran Tal
6af137d81a Merge pull request #840 from lirantal/feature/users_module_tests_%
Major Fixing and Refactoring tests
2015-08-30 21:22:28 +03:00
mleanos
263adccd44 User model tests for roles
Added tests for the User model's roles field.

Should be able to update existing user with valid roles
Should NOT be able to update existing user WITHOUT a role
Should NOT be able to update existing user with INVALID role
2015-08-28 18:19:33 -07:00
mleanos
bbbe8772f2 Admin Users require role
These changes make the role field required in the User model. Changes to
the Admin user edit view were added to provide validation for the role
field.

As an added enhancement, the user's roles are displayed in the Admin
user list view.
2015-08-28 17:41:13 -07:00
Liran Tal
6db8a4e4fa Major Fixing and Refactoring tests
1. Refactoring variables usage through-out the tests
2. Fixing correct error handler tests were previously these would report a false positive isue
3. Fixing recent unit tests to be added as part of the main save method suite
4. Fixing an issue with the tests which didn't clean the user1 entry in the db and so tests following it would fail regardless of the validation
5. Fixing one test to actually be valid use case
2015-08-26 22:54:08 +03:00
Sebastien Vaucouleur
ab82acb51b Renamed files using convention verb-object.client.etc. Closes #817
Renamed files using convention verb-object.client.etc. Closes #817
2015-08-26 16:50:15 +02:00
Ryan Hutchison
3bf07fe4ec Remove data- prefix from attributes 2015-08-25 12:34:40 -04:00
Liran Tal
01bd98b386 Merge pull request #759 from Gym/client-side-validation
client-side form validation with ng-messages.
2015-08-25 16:19:22 +03:00
Liran Tal
05355b986d Merge pull request #842 from Gym/fb-enhancements
Facebook authentication
2015-08-25 16:14:06 +03:00
Ryan Hutchison
801547602b client-side form validation with ng-messages.
remove data prefix from attributes.

fix tests
2015-08-25 02:02:18 -04:00
Ryan Hutchison
c6d26831fc do not save state to previous (history) for routes marked ignoreState. 2015-08-23 04:09:36 -04:00
Ryan Hutchison
27d2818834 Closes #202 - if user does not authorize email scope, email will not be mapped. Username will be generated from first initial of first name and last name.
.jshint latedef set to nofunc.
2015-08-23 00:32:36 -04:00
Meistercoach83
4b43c4ef32 Correct <br /> Tags and set Title 2015-08-21 18:18:15 -04:00
Cody B. Daig
5c287f583b [fix] Was storing a 6 char password in plain text [fixes #829] 2015-08-20 09:26:07 -07:00
Cody B. Daig
74f58bbbd6 [test] Allow an email with sub domains 2015-08-19 19:08:44 -07:00
Sebastien Vaucouleur
851973f459 Fixed end tags in page header 2015-08-14 17:26:55 +02:00
Liran Tal
86b16c93f6 Merge pull request #758 from trainerbill/PathRefactor
Initial commit to return /client to the URL include paths
2015-08-14 17:21:49 +03:00
Liran Tal
89050d5628 Adding suite of tests for the e-mail validation field in the users model 2015-08-13 21:56:19 +03:00
Andrew Throener
d319f9203f Initial commit to return /client to the URL include paths
Conflict Resolve

Fixed Karma testing

Added back cacheIDFromPath as I am not sure what that does.  Just removed the replaceing of /client
2015-08-13 11:07:02 -05:00
Liran Tal
609d95824d Merge pull request #771 from lirantal/bugfix/fix_user_module_async_tests
Fixing user model test's last test which fail or report a false positive
2015-08-13 13:42:19 +03:00
Ryan Hutchison
cb9d7e3db6 fix indentation 2015-08-11 01:01:12 -04:00
Liran Tal
463f5b944f fixing up a user model test which was not setup correctly without the async done() callback, which led to false postivies. Adding timeouts to the test ensures that the test completes in time, otherwise mocha's 2s timeout will fail the test 2015-08-08 00:42:11 +03:00
Liran Tal
c967a98562 refactoring the async nature in the user model tests to account for mocha 2 second timeouts causing travis-ci build fails 2015-08-06 16:49:50 +03:00
Liran Tal
346ebd6a67 re-factoring the server model tests to create user model from schema only during tests, so that we can re-use mongodb's _v versioning fields, and also cleaning up user tests on each test iteration 2015-08-05 14:08:09 +03:00
Ryan Hutchison
2747df6310 BUG: Removed a ng-binding to article.content in user-list.client.view.html 2015-07-31 23:45:56 -04:00
Ryan Hutchison
ef3a3f9548 formatting reboot (space-2 and consistency)
JSCS fixes

update editorconfig
2015-07-31 10:04:02 -04:00
Ilan Biala
612a76cda6 Merge pull request #728 from cdriscol/angular_tests
Add client side tests
Fixes #663
2015-07-29 10:31:29 -04:00
Igor Freire
e6a35a7f9a Enable redirection to previous page after login
Two different strategies are adopted, one for when the user authenticates locally and the other through providers. When authenticating locally, the signin function in the client controller redirects to the previous state (storing and using a state name) after successful login. When authenticating through a provider, the first call to provider stores the previous URL (not state, URL) in the session. Then, when provider actually calls the authentication callback, session redirect_to path is used for redirecting user.
2015-07-29 10:55:47 -03:00
cdriscol
d5ea5c99d2 Adding client test coverage. 2015-07-29 06:51:38 -06:00
Ryan Hutchison
4bbc4a30f6 add user route tests 2015-07-28 18:50:11 -04:00
Ryan Hutchison
839f805172 BUG: fix admin access (blocking user PUT) 2015-07-28 18:50:11 -04:00
Ryan Hutchison
60660204ac Admin module base & user admin implementation.
update displayName

implements #700 (client-side role security) on angular routes.
2015-07-24 20:03:35 -04:00
Liran Tal
c8880ea65d Merge pull request #700 from trainerbill/requireLogin
Require login
2015-07-25 01:18:33 +03:00
Andrew Throener
1b54d35305 Final Clean Up after code review 2015-07-24 17:06:55 -05:00
Liran Tal
c671f65c47 Merge pull request #693 from lirantal/feature/clean_angular_hashbang_urls
Feature/clean angular hashbang urls
2015-07-25 01:06:03 +03:00
Andrew Throener
03a4042a33 Updated routes and a logic fix 2015-07-24 16:43:46 -05:00
Liran Tal
de3b890f9d removed /#! in user controllers
Resolved 0.4.0 related conflicts:
	modules/users/server/controllers/users/users.authentication.server.controller.js
2015-07-25 00:39:28 +03:00
Igor Freire
e21805f20a Prepare for role-based access control of states 2015-07-24 16:59:13 -03:00
Igor Freire
9fc88e6e5b Filter states for which login is required during state change
A state parameter was added for the routes that require user authentication. Now, everytime a statechange occurs, the destination state is checked and user is redirected to signin page if necessary. Note the state parameter is added within `data`, so that nested states can inherent its value.
2015-07-24 16:17:14 -03:00
Ilan Biala
8a81cf0168 Merge pull request #688 from codydaig/bugfix/github_undefined_displayname
If displayName in GitHub is undefined use username
Fixes #519
2015-07-24 10:13:26 -04:00
Liran Tal
ac35f0fec8 adding couple more tests to confirm users model works as expected 2015-07-24 09:38:49 +03:00
Cody B. Daig
7605956c99 displayName undefined 2015-07-23 17:00:22 -07:00
Igor Freire
5d4d7cecfe Make emails unique
Emails are made unique. When user attempts to sign in through a provider in which his email is one that is already registered, user is redirected to the signin page with an error passed as a query string parameter.
2015-07-17 14:52:27 -03:00
git-admin
a23290b46e Use validator.js for email validation 2015-07-17 09:27:16 +02:00
trainerbill
a98a84fd20 Fix merge conflicts 2015-07-14 15:46:23 -05:00
Julien Mazé
c572ed7eec JSHint test failing because of missing semicolon
I just cloned the branch and both gulp and grunt fail on the lint task because of the missing semicolon.
2015-07-12 20:54:59 +02:00
Liran Tal
bf79c17bd0 updating the schema save pre hook so that it checks for a modified version of the password field before it tries to re-calculate the new password to save for the user model 2015-07-12 19:25:40 +03:00