Commit Graph

142 Commits

Author SHA1 Message Date
Liran Tal
c95bd7d1cb fix(core): fix ESLint console warnings, Twitter redirect, and and scope usage (#1388)
* Use validator.js instead of regexp for validations in User Schema.

* Disables "Unexpected console statement  no-console" warnings

* Fixes redirection to wrong URL after login with social networks.

* Use ViewModel vm instead of $scope in manage social accounts controller.

* preserving the option to redirect to a specific URL as done in saveOAuthUserProfile() (thanks to @OneOfTheWorld for pointing out)
2016-07-07 01:24:23 +03:00
Michael Leanos
b795ddc7cd feat(users): Edit Profile client controller tests (#1329)
Adds client-side tests for the Users Edit Profile client controller.

1) should have user context
2) should update the user profile
3) should set vm.error if error

Related #1283
2016-06-25 13:52:22 -07:00
Jonathan Trowbridge
2ad422ca9b fix(users): fix for users.profile.server.controller.js security (#1338)
* Fix for users.profile.server.controller.js security (#1338)

Fixes an issue where if req.body._id was not set to the current user it
could potentially log the current user in as another user.

Don't use req.body._id when editing user

Prevents a user from being logged in as another if edit user form _id is
not their own.

Fixes #1338
2016-06-18 18:12:08 +03:00
Trevor Jennings
5137214972 fix(users): Incorrect UsersService injection (#1283)
* fix bug in edit profile controller.

* fix(users): Incorrect UsersService injection
2016-04-29 14:20:03 -07:00
Michael Leanos
4906611ccc fix(users): GitHub strategy missing email (#1250)
Fixes an issue with an empty/missing/null Email coming from GitHub's
OAuth call response.

Also, introduces the `sparse` index option on the User model's Email
field. This will ensure that we can have multiple User documents without
the Email field.

Adds a server-side User model test for the sparse index setting on the
email field.

Confirms that User documents without the email field are not indexed,
illustrating the sparse option on the schema's email field works
properly.

Added the dropdb task to the Gulp test:client & test:server tasks, to
ensure we have a clean database & that any indexes are rebuilt; this
will ensure any Schema changes (in this case the email index is rebuilt using
the sparse index option) are reflected when the database is started again.

Added a UPGRADE.md for tracking important upgrade information for our
user's to be aware of, when we introduce potentially breaking changes.

Included an explanation of the Sparse index being added, and how to apply it
to an existing MEANJS application's database.

Adds a script for dropping the `email` field's index from the User
collection.

Related #1145
2016-04-29 14:13:46 -07:00
Ryan Hutchison
b2462ec86c feat(core): Modify core module to implement style guidelines.
Update the core module to implement the style guidelines.
Reduce size of init.js - moved filter logic out to it's own config.
Rename Menus to menuService
2016-03-23 15:41:57 -04:00
Liran Tal
80226a2b24 fix(client): lint issues for confirm() messages not referencing the window object 2016-03-17 22:27:53 +02:00
Marek Grzybek
d14d5130af feat(config): Deprecate JSHint in favor of ESLint
Add basic ESLint setup extending well-known Airbnb code style.

Fixes #1072, #1097
2016-03-15 19:11:12 +01:00
Michael Leanos
4e9ad81ad2 Merge pull request #1246 from QiyuLi/fix/supoort_mongo_3.2
fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
2016-03-14 12:19:59 -07:00
Michael Leanos
4c89ce7e2d Merge pull request #1208 from itelo/users-styleguide
feat(users): Modify users module to implement style guidelines.
2016-03-14 11:46:41 -07:00
mleanos
b00498629c fix(core): Remove trailing slash from routes
Adds an angular $urlRouterProvider service Rule to the Core module
configuration, that removes any trailing slashes in the URL for all routes.

The Rule is defined in the core routes configuration. Thus, in order for
this to work on all routes in the application, we have to inject the Core
module into each client module, as a dependecy in the client.module
configuration. Otherwise, we'd have to define the Rule in each module's route
configuration individually.

Adds missing client-side route configuration tests.

Tests demonstrate that the various route configurations can handle a trailing
slash in the URL, and gets resolved to the correct client route.

Fixes #1075
2016-03-06 20:56:29 -08:00
IteloFilho
173b702f6a feat(users): Modify users module to implement style guidelines. 2016-03-06 12:21:51 -03:00
Michael Leanos
8f00edcd82 Merge pull request #1241 from mleanos/fix/connected-accounts-not-shown
fix(users): Missing primary social provider
2016-03-04 16:12:44 -08:00
Qiyu Li
6265aaa7da fix(core): Support WiredTiger engine errmsg format in MongoDB 3.2
The new WiredTiger engine is introduced in MongoDB 3.2.
It changes the output errmsg format for violation of unique index.
This commit adds support for the new format.

Fixes #1245
2016-03-04 09:56:15 -05:00
Ilan Biala
049fde9451 Merge pull request #1207 from trendzetter/master
feat(config): Upgrade to angular 1.5
2016-03-02 14:44:55 -05:00
mleanos
f2e18e24f1 fix(users): Missing primary social provider
Adds the User's provider to the list of connect social accounts, when it
is also a social account.

Fixes: #1032
2016-03-02 10:40:34 -08:00
Joris Willems
500d1a62df feat(config): upgrade to angular 1.5
Update bower dependencies to more recent versions.
Resolved hard-coded dependency by updating file upload
PhantomJs to 2.x series for tests (@usta)
Fix assertion in tests for compatibility with MongoDB 3.2 (@rhutchison)
Improve coding style tests to avoid type errors (@ilanbiala)
Fix refresh showing flash of scrollbar in menu
Remove deprecated angular-ui-utils

Fixes #1124
2016-03-02 18:18:53 +01:00
Liran Tal
0ebbdd4935 Merge pull request #1236 from lirantal/bugfix/ignored_errors_on_controller
fix(users) error objects were not handled
2016-02-28 09:58:20 +02:00
Liran Tal
03043dcc90 fix(users): removing unused variable from code 2016-02-27 12:58:46 +02:00
Liran Tal
8e249548d4 fix(users): error objects were not handled 2016-02-27 12:54:54 +02:00
droooney
52faf0697f fix(build): Remove BOM
Remove byte-order mark from source files.

Fixes #1227
2016-02-20 14:49:30 +05:00
Cody B. Daig
a069531b10 Merge pull request #1186 from itelo/ImproveSEO
feat (title): Dynamic Title: Improve SEO
2016-02-13 10:20:54 -07:00
Liran Tal
7852144fc1 Merge pull request #1200 from meanjs/node5-support
Update Mocha
2016-02-12 00:41:22 +02:00
Ilan Biala
62095a1114 fix(test): Update Mocha, mock-fs, and fix Node 5 support 2016-02-10 20:47:11 -05:00
Ryan Hutchison
3e6a65d3a0 fix(users): Correct spelling/grammar mistakes
Closes #1156

adjust language
2016-02-10 19:56:42 -05:00
IteloFilho
49f6a83032 feat (title): Dynamic Title: Improve SEO 2016-02-10 12:12:10 -03:00
Joris Willems
9cd4ceca46 feat(config): Upgrade angular-bootstrap 0.13 to 1.0
Many issues arise when using angular-bootstrap 0.13. Migration to 1.0 is
straightforward, offers a more stable interface, extra directives and fixes
many bugs.
Migration guide:
https://github.com/angular-ui/bootstrap/wiki/Migration-guide-for-prefixes

Fixes #1142
Fixes #1131
2016-01-17 22:06:34 +01:00
Sébastien Combéfis
d2b2dfd606 fix(docs): Fix comments content and style
Changed some bad comments referencing the Articles module in other modules.
Typo fixed in xxx.client.modules.js files ("Application" => "Applicaion")
Full stop character removed at the end of line comments
2016-01-17 11:46:11 +01:00
Faraj Farook
f9c7403825 fix(users): Removing redundant variables
Removing redundant variables defined and not used
2016-01-16 16:17:07 +05:30
Pedro Rodrigues
996976ac66 fix(core): Remove duplicate angular interceptor
Remove the interceptor defined in the users module
Update the interceptor defined in the core module
Update the respective test

Fixes #1096
2015-12-16 14:55:07 +00:00
jloveland
33258f1314 feat(users): Supporting valid email according to HTML5 and RFC 822
Supporting valid email (i.e. root@admin) according to HTML5 and RFC 822
proposed by @jloveland

Fixes #934
2015-11-30 21:47:13 -05:00
mleanos
a871c92556 Duplicate CRUD Test - Profile Picture
Removes a duplicate User CRUD test for Profile Picture.

There are two reasons for this commit.

1) Duplicate of
https://github.com/meanjs/mean/blob/master/modules/users/tests/server/user.server.routes.tests.js#L833-L848
2) This test is problematic in Windows environment.
Related to:
https://github.com/visionmedia/supertest/issues/230
https://github.com/visionmedia/supertest/issues/258

The latter may be an issue with the `.attach` method not completely
loading the file into memory before the 400 status response is sent back
due to no User logged in.
2015-10-28 22:57:28 -07:00
gustavodemari
7ecf9337ce updating profile upload with a new version of multer 2015-10-18 20:56:12 -02:00
Ilan Biala
cc486d54c5 Merge pull request #910 from jloveland/hide-password-validator
Hide the password strength progress when the field is empty
2015-10-16 23:34:55 -04:00
Ilan Biala
0323696eaf Format code according to ESLint rules 2015-10-16 20:52:31 -04:00
jloveland
65140442f0 adding tests for directives 2015-10-13 23:23:52 -04:00
jloveland
f733efba5a renaming strength meter, hiding when password field is empty, and refactoring directives to use $validators 2015-10-13 22:47:35 -04:00
Liran Tal
8a12f76a19 Merge pull request #972 from mleanos/mocha-global-timeout-grunt
Global Mocha timeout
2015-10-13 08:39:48 +03:00
Liran Tal
0017886d6e updating travis to support installing a local mail server 2015-10-11 23:19:20 +03:00
Liran Tal
eb7c4f8e91 adding more API tests 2015-10-11 23:19:20 +03:00
mleanos
037878b4ba Global Mocha timeout
Added the timeout option to the Mocha grunt task; set to 10000.

Removed the individual test suite timeouts, for all server tests.

Also, added global timeout for Mocha gulp task.
2015-10-10 23:52:08 -07:00
Liran Tal
19aea2f112 Merge pull request #967 from mleanos/user-model-validate-bug
[bug] Solves User model validation issue with tests [fixes #966]
2015-10-10 21:40:34 +03:00
Liran Tal
3cfd978e8a Merge pull request #922 from lirantal/feature/travis-add-node-v4-gcc-update
NodeJS v4 support - fixing the failed build
2015-10-06 14:22:47 +03:00
Liran Tal
b7a57abd30 adding the required support to properly build the nodejs v4 edition
updating grunt-node-inspector version to compatible version with nodejs v4
2015-10-06 14:09:04 +03:00
mleanos
288f0b4e63 Solves User model validation bug
This solves the issue of the User model's pre('validate') method,
attempting to validate against a password that was not modified.

Adds the this.isModified('password') check to the condition.
2015-10-05 16:41:14 -07:00
Ilan Biala
7a9ee53357 Merge pull request #939 from jloveland/e2e-tests-fix
Fix grunt and gulp e2e tests, Fixes #929
2015-10-04 12:49:42 -04:00
mleanos
3b375e62d8 Mocha test timeouts [fixes #955]
Added a timeout of 10000 ms to each server test file. This is an attempt
to solve the timeout issues that we're experiencing with the Mocha
tests. Especially, this is hoping to address the build fails that are
caused by such timeouts.

Issue is described in https://github.com/meanjs/mean/issues/955
2015-09-30 19:50:07 -07:00
Liran Tal
7fcd4f2ed3 Merge pull request #937 from lirantal/feature/seeddb-refactoring
SeedDB Refactoring
2015-09-30 12:55:49 +03:00
jloveland
fdf1ad571b fixing grunt and gulp e2e tests 2015-09-29 08:21:43 -04:00
Liran Tal
cc80930081 Merge pull request #904 from jloveland/jshint-single-quotes
fixing jshint single quotes issues
2015-09-28 23:47:13 +03:00